Skip to content

ApplicationModuleSource picks up module identifier from nested modules #1043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
odrotbohm opened this issue Jan 28, 2025 · 0 comments
Closed

ApplicationModuleSource picks up module identifier from nested modules #1043

odrotbohm opened this issue Jan 28, 2025 · 0 comments
Assignees
@odrotbohm
Labels
in: core Core module meta model type: bug Something isn't working
Milestone
1.3.3

Comments

@odrotbohm
Copy link
Member

Back-port of GH-1042.
@odrotbohm odrotbohm added in: core Core module meta model type: bug Something isn't working labels Jan 28, 2025
@odrotbohm odrotbohm added this to the 1.3.3 milestone Jan 28, 2025
@odrotbohm odrotbohm self-assigned this Jan 28, 2025
odrotbohm added a commit that referenced this issue Jan 28, 2025
@odrotbohm
GH-1043 - Fix module identifier lookup in ApplicationModuleSource.
6f24103 
Before this commit, ApplicationModuleSource inspected all package-info.java contained in given packages, including the sub-packages of those. That caused identifiers explicitly defined in an @ApplicationModule on a package-info.java in nested packages picked up for top-level packages. This is now fixed by only considering the files in the top-level packages.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@odrotbohm odrotbohm

Labels
in: core Core module meta model type: bug Something isn't working
Projects
None yet
Milestone
1.3.3
Development

No branches or pull requests
1 participant
@odrotbohm