Version control reports can show notices when the report width is very small

[aminin]

The command

phpcs --standard=PSR2 --encoding=utf-8 -n -p -s --report=gitblame src/

produces warning

PHP Warning:  str_repeat(): Second argument has to be greater than or equal to 0 in /home/anton/.composer/vendor/squizlabs/php_codesniffer/CodeSniffer/Reports/VersionControl.php on line 244

if the sniffed code contains a Squiz.WhiteSpace.ControlStructureSpacing.SpacingBeforeClose error

[gsherwood]

The fix for this issue looks like it is just masking a bigger issue. The width calculations shouldn't make these values go negative at all, but I've been unable to replicate the problem so far so I can't investigate a fix just yet. But I will keep trying and then see if there is a bigger problem with the width calculation.

I can replicate with --report-width=70 on the sample code I'm using, so I'll take a look.

[gsherwood]

There was a bigger problem with report width - the sources were not being truncated like they are in other reports. So I've fixed that, and a minor width issue, and added an indicator for which sources are fixable. Should be good now.

Thanks for reporting the problem.