Capital letter detection for multibyte strings doesn't work correctly #855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why you've closed this? |
Maybe because it breaks the unit tests. The original issue is caused by preg_match returning false, although I don't know what the error is. |
Probably because it's only getting the first byte of the multibyte character rather than a regex issue. |
|
I think I've found the original problem and a possible fix. I'll just turn this into a bug report. |
gsherwood
changed the title
|
Ya sorry my fixe broke unit test I have have no time to investigate further. I mostly changed |
|
@DaazKu Thanks. Your PR was very helpful in finding the problem. |
jrfnl
added a commit
to jrfnl/WordPress-Coding-Standards
that referenced
this pull request
May 2, 2016
A bugfix upstream now causes `Doc comment short description must start with a capital letter` errors for `/* translators: ... */` comments. Excluding the offending rule to continue to allow these type of comments. Ref: squizlabs/PHP_CodeSniffer#855
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accessing string as array actually cut multibyte characters.
That description would pass the test but it shouldn't.
Rewrite the regexes and compare the entire string.