Skip to content

Commit e6d9986

Browse files
feat(node-sdk): make config optional (open-telemetry#331)
* feat(node-sdk): make config optional closes open-telemetry#330 Signed-off-by: Olivier Albertini <[email protected]>
1 parent a0140ec commit e6d9986

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

packages/opentelemetry-node-sdk/src/NodeTracer.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,12 +28,12 @@ export class NodeTracer extends BasicTracer {
2828
/**
2929
* Constructs a new Tracer instance.
3030
*/
31-
constructor(config: NodeTracerConfig) {
31+
constructor(config: NodeTracerConfig = {}) {
3232
if (config.scopeManager === undefined) {
3333
config.scopeManager = new AsyncHooksScopeManager();
3434
config.scopeManager.enable();
3535
}
36-
super(Object.assign({}, { scopeManager: config.scopeManager }, config));
36+
super(Object.assign({ scopeManager: config.scopeManager }, config));
3737

3838
this._pluginLoader = new PluginLoader(this, this.logger);
3939
this._pluginLoader.load(config.plugins || DEFAULT_INSTRUMENTATION_PLUGINS);

packages/opentelemetry-node-sdk/test/NodeTracer.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ describe('NodeTracer', () => {
5353

5454
describe('constructor', () => {
5555
it('should construct an instance with required only options', () => {
56-
tracer = new NodeTracer({});
56+
tracer = new NodeTracer();
5757
assert.ok(tracer instanceof NodeTracer);
5858
});
5959

0 commit comments

Comments
 (0)