DRY DRY DRY

Author: alicewriteswrongs

scripts/bundles/plugins/sizzle-plugin.ts

@@ -32,21 +32,21 @@ export function sizzlePlugin(opts: BuildOptions): Plugin {
       if (id !== 'sizzle') {
         return null;
       }
-      const f = opts.isProd ? 'sizzle.min.js' : 'sizzle.js';
-      const sizzlePath = join(opts.nodeModulesDir, 'sizzle', 'dist', f);
-      const sizzleContent = await fs.readFile(sizzlePath, 'utf8');
-      return getSizzleBundle(opts, sizzleContent);
+      return getSizzleBundle(opts);
     },
   };
 }
 
 /**
  * Creates a sizzle bundle to inline
  * @param opts the options being used during a build of the Stencil compiler
- * @param content the sizzle source contents
  * @returns a modified version of sizzle, wrapped in an immediately invoked function expression (IIFE)
  */
-function getSizzleBundle(opts: BuildOptions, content: string): string {
+async function getSizzleBundle(opts: BuildOptions): Promise<string> {
+  const f = opts.isProd ? 'sizzle.min.js' : 'sizzle.js';
+  const sizzlePath = join(opts.nodeModulesDir, 'sizzle', 'dist', f);
+  const sizzleContent = await fs.readFile(sizzlePath, 'utf8');
+
   return `// Sizzle ${opts.sizzleVersion}
 export default (function() {
 const window = {
@@ -63,18 +63,22 @@ const window = {
 };
 const module = { exports: {} };
 
-${content}
+${sizzleContent}
 
 return module.exports;
 })();
 `;
 }
 
+/**
+ * Write a file containing our patched version of Sizzle to a location on disk
+ * and return the path for that location
+ *
+ * @param opts the build options
+ * @returns a Promise wrapping the path where Sizzle can be found
+ */
 export async function writeSizzleBundle(opts: BuildOptions): Promise<string> {
-  const f = opts.isProd ? 'sizzle.min.js' : 'sizzle.js';
-  const sizzlePath = join(opts.nodeModulesDir, 'sizzle', 'dist', f);
-  const sizzleContent = await fs.readFile(sizzlePath, 'utf8');
-  const patchedSizzle = getSizzleBundle(opts, sizzleContent);
+  const patchedSizzle = await getSizzleBundle(opts);
 
   const fileName = `sizzle--bundle-cache${opts.isProd ? '.min' : ''}.js`;
   const cacheFile = join(opts.scriptsBuildDir, fileName);

scripts/esbuild/mock-doc.ts

@@ -36,6 +36,7 @@ export async function buildMockDoc(opts: BuildOptions) {
     bundle: true,
     alias: mockDocAliases,
     logLevel: 'info',
+    target: 'node16',
   };
 
   const esmOptions: ESBuildOptions = {