feat(jsx): add support for aria-* attributes in JSX typings #6221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christian-bromann
requested changes
Apr 2, 2025
2 tasks
Add typings for ARIA attributes like `aria-labelledby`, `aria-hidden`, etc., to the DOMAttributes interface. This allows better accessibility support and developer experience via type safety and IntelliSense. fixes: stenciljs#6182
AlirezaEbrahimkhani
force-pushed
the
feat/jsx-aria-attributes
branch
from
3fc53e6 to
044a600
Compare
|
Is there a way to ignore this ? One of our components have a Maybe it would be better to list the existing |
|
@duhem-s would you mind raising a PR for this, happy to merge and release it. |
2 tasks
3 tasks
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add typings for ARIA attributes like
aria-labelledby,aria-hidden, etc., to the DOMAttributes interface. This allows better accessibility support and developer experience via type safety and IntelliSense.fixes: #6182
What is the current behavior?
GitHub Issue Number: #6182
Currently, JSX attributes with ARIA prefixes such as aria-label, aria-hidden, etc., are not typed, leading to missing IntelliSense and potential type errors in TypeScript.
What is the new behavior?
JSX ARIA attributes are now explicitly typed in the DOMAttributes interface, enabling proper IntelliSense, autocomplete, and validation in IDEs and TypeScript-aware tooling.
This includes support for all standard ARIA attributes, and optionally, a generic index signature for custom aria-* values.
Documentation
Does this introduce a breaking change?
Testing
Other information