Edit multiple line commit message functionality #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stevelacy I think it is ready for an npm patch level release. Basically, I made incorrect assumptions that newlines in commit messages are the same to using multiple -m "message" arguments. This was a bad assumption as -m "message" adds newline padding (\n\n) under the commit messages whereas \n just ads a single newline. This fixes that incorrect functionality. |
|
Can you update the docs/tests to match? |
Multiple lines should happen by passing an array of messages as message instead of relying upon finding newline characters. A given message can have newline characters without spawning a new -m argument. This fixes this functionality.
|
@stevelacy Sure thing. Updated. |
|
Excellent, merging Thanks! |
stephenlacy
pushed a commit
that referenced
this pull request
May 7, 2015
Edit multiple line commit message functionality
|
Great. As always, thanks for the merge, Steve. |
|
published v1.2.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple lines should happen by passing an array of messages as message
instead of relying upon finding newline characters. A given message can
have newline characters without spawning a new -m argument. This fixes
this functionality.