Eliminate UI polling (#32)

Author: stippi

Cargo.lock

@@ -56,6 +56,7 @@ rand = "0.8.5"
 
 # Diff visualization
 similar = { version = "2.5.0", features = ["inline"] }
+async-channel = "2.3.1"
 
 [dev-dependencies]
 axum = "0.7"

crates/code_assistant/Cargo.toml

@@ -2,7 +2,7 @@ use crate::agent::tool_description_generator::generate_tool_documentation;
 use crate::agent::types::{ToolExecution, ToolRequest};
 use crate::config::ProjectManager;
 use crate::persistence::StatePersistence;
-use crate::tools::core::{ToolContext, ToolRegistry, ToolScope};
+use crate::tools::core::{ResourcesTracker, ToolContext, ToolRegistry, ToolScope};
 use crate::tools::{parse_tool_xml, TOOL_TAG_PREFIX};
 use crate::types::*;
 use crate::ui::{streaming::create_stream_processor, UIMessage, UserInterface};
@@ -112,8 +112,8 @@ impl Agent {
         Ok(())
     }
 
-    pub async fn get_input_from_ui(&self, prompt: &str) -> Result<String> {
-        self.ui.get_input(prompt).await.map_err(|e| e.into())
+    pub async fn get_input_from_ui(&self) -> Result<String> {
+        self.ui.get_input().await.map_err(|e| e.into())
     }
 
     /// Handles the interaction with the LLM to get the next assistant message.
@@ -160,7 +160,7 @@ impl Agent {
     /// Handles the case where no tool requests are made by the LLM.
     /// Prompts the user for input and adds it to the message history.
     async fn solicit_user_input(&mut self) -> Result<()> {
-        let user_input = self.get_input_from_ui("").await?;
+        let user_input = self.get_input_from_ui().await?;
         self.ui
             .display(UIMessage::UserInput(user_input.clone()))
             .await?;
@@ -730,7 +730,7 @@ impl Agent {
 
         // Update status to Running before execution
         self.ui
-            .update_tool_status(&tool_request.id, crate::ui::ToolStatus::Running, None)
+            .update_tool_status(&tool_request.id, crate::ui::ToolStatus::Running, None, None)
             .await?;
 
         // Get the tool - could fail with UnknownTool
@@ -764,9 +764,13 @@ impl Agent {
         // Generate status string from result
         let short_output = result.as_render().status();
 
+        // Generate isolated output from result
+        let mut resources_tracker = ResourcesTracker::new();
+        let output = result.as_render().render(&mut resources_tracker);
+
         // Update tool status with result
         self.ui
-            .update_tool_status(&tool_request.id, status, Some(short_output))
+            .update_tool_status(&tool_request.id, status, Some(short_output), Some(output))
             .await?;
 
         // Create and store the ToolExecution record

crates/code_assistant/src/agent/runner.rs

@@ -378,8 +378,7 @@ fn run_agent_gpui(
                 agent.start_with_task(task_str).await.unwrap();
             } else {
                 // In GUI mode with no task, prompt the user for a task
-                let task_prompt = "Please enter the task you want me to perform:";
-                let task_from_ui = agent.get_input_from_ui(task_prompt).await.unwrap();
+                let task_from_ui = agent.get_input_from_ui().await.unwrap();
                 agent.start_with_task(task_from_ui).await.unwrap();
             }
         });

crates/code_assistant/src/main.rs

@@ -190,7 +190,7 @@ impl UserInterface for MockUI {
         Ok(())
     }
 
-    async fn get_input(&self, _prompt: &str) -> Result<String, UIError> {
+    async fn get_input(&self) -> Result<String, UIError> {
         self.responses
             .lock()
             .unwrap()
@@ -234,6 +234,7 @@ impl UserInterface for MockUI {
         _tool_id: &str,
         _status: ToolStatus,
         _message: Option<String>,
+        _output: Option<String>,
     ) -> Result<(), UIError> {
         // Mock implementation does nothing with the tool status
         Ok(())

crates/code_assistant/src/tests/mocks.rs

@@ -11,8 +11,6 @@ use std::path::PathBuf;
 use crate::tools::impls::{ExecuteCommandTool, ReplaceInFileTool};
 use crate::utils::CommandOutput;
 
-// Make the MockProjectManager public so it can be used by other tests
-
 #[tokio::test]
 async fn test_read_files_tool() -> Result<()> {
     // Create a tool registry

crates/code_assistant/src/tools/tests.rs

@@ -0,0 +1,37 @@
+use crate::ui::gpui::parameter_renderers::ParameterRenderer;
+use gpui::{div, px, rgba, Element, FontWeight, ParentElement, Styled};
+
+/// Renderer for the "content" parameter of the "write_file" tool
+pub struct ContentRenderer;
+
+impl ParameterRenderer for ContentRenderer {
+    fn supported_parameters(&self) -> Vec<(String, String)> {
+        vec![("write_file".to_string(), "content".to_string())]
+    }
+
+    fn render(
+        &self,
+        _tool_name: &str,
+        _param_name: &str,
+        param_value: &str,
+        theme: &gpui_component::theme::Theme,
+    ) -> gpui::AnyElement {
+        // Container for the content - no parameter name shown
+        div()
+            .rounded_md()
+            .bg(if theme.is_dark() {
+                rgba(0x0A0A0AFF) // Darker background in Dark Mode
+            } else {
+                rgba(0xEAEAEAFF) // Lighter background in Light Mode
+            })
+            .p_2()
+            .text_size(px(15.))
+            .font_weight(FontWeight(500.0))
+            .child(param_value.to_string())
+            .into_any()
+    }
+
+    fn is_full_width(&self, _tool_name: &str, _param_name: &str) -> bool {
+        true // Content parameter is always full-width
+    }
+}