fix: enroll mfa totp #693
Merged
fix: enroll mfa totp #693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grdsdev
commented
Mar 25, 2025
Comment on lines
+660
to
+665
| @model_validator_v1_v2_compat | ||
| def validate_phone_required_for_phone_type(cls, values: dict) -> dict: | ||
| if values.get("type") == "phone" and not values.get("phone"): | ||
| raise ValueError("phone is required when type is 'phone'") | ||
| return values | ||
|
|
There was a problem hiding this comment.
@silentworks is this the correct way of doing it?
Pull Request Test Coverage Report for Build 14064176131Details
💛 - Coveralls |
silentworks
approved these changes
Mar 26, 2025
grdsdev
deleted the
guilherme/clibs-122-mfa-bug-can-not-enroll-mfa-use-factor_type-totp
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
fix #684
What is the current behavior?
Please link any relevant issues here.
What is the new behavior?
Feel free to include screenshots if it includes visual changes.
Additional context
Add any other context or screenshots.