feat: merge provider metadata on link account (#1552)

hf · web-flow · commit bd8b5c41dd54 · 2024-04-23T14:44:48.000+02:00
It merges back the identity data into user metadata on link account.
This is safe because the user can just sign-in again and have the
identity data merged back (AccountExists case).
diff --git a/internal/api/external.go b/internal/api/external.go
@@ -298,6 +298,10 @@ func (a *API) createAccountFromExternalIdentity(tx *storage.Connection, r *http.
 			return nil, terr
 		}
 
+		if terr = user.UpdateUserMetaData(tx, identityData); terr != nil {
+			return nil, terr
+		}
+
 		if terr = user.UpdateAppMetaDataProviders(tx); terr != nil {
 			return nil, terr
 		}

Original file line number	Diff line number	Diff line change
`@@ -298,6 +298,10 @@ func (a API) createAccountFromExternalIdentity(tx storage.Connection, r *http.`
`298`	`298`	`return nil, terr`
`299`	`299`	`}`
`300`	`300`
	`301`	`+ if terr = user.UpdateUserMetaData(tx, identityData); terr != nil {`
	`302`	`+ return nil, terr`
	`303`	`+ }`
	`304`	`+`
`301`	`305`	`if terr = user.UpdateAppMetaDataProviders(tx); terr != nil {`
`302`	`306`	`return nil, terr`
`303`	`307`	`}`