Skip to content

Commit bec8b60

Browse files
authored
Merge pull request #282 from symfony-cmf/sf7
symfony 7
2 parents d1e3ba5 + 30cdb43 commit bec8b60

File tree

7 files changed

+26
-18
lines changed

7 files changed

+26
-18
lines changed

.github/ISSUE_TEMPLATE.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,5 +39,5 @@ $ composer show --latest 'symfony-cmf/*'
3939
If it's an error message or piece of code, use code block tags,
4040
and make sure you provide the whole stack trace(s),
4141
not just the first error message you can see.
42-
More details here: https://github.com/symfony-cmf/Routing/blob/master/CONTRIBUTING.md#issues
42+
More details here: https://github.com/symfony-cmf/Routing/blob/3.x/CONTRIBUTING.md#issues
4343
-->

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
| Q | A
22
| ------------- | ---
3-
| Branch? | "master" for new features / the branch of the current release for fixes
3+
| Branch? | default branch for new features / the branch of the current release for fixes
44
| Bug fix? | yes/no
55
| New feature? | yes/no
66
| BC breaks? | yes/no

.github/workflows/test-application.yaml

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ on:
44
pull_request:
55
push:
66
branches:
7-
- "master"
87
- "[0-9]+.x"
98
- "[0-9]+.[0-9]+"
109
- "[0-9]+.[0-9]+.x"
@@ -15,6 +14,7 @@ jobs:
1514
runs-on: "ubuntu-20.04"
1615
env:
1716
SYMFONY_DEPRECATIONS_HELPER: weak
17+
SYMFONY_REQUIRE: ${{ matrix.symfony-version }}
1818

1919
strategy:
2020
fail-fast: false
@@ -27,11 +27,13 @@ jobs:
2727
symfony-version: "6"
2828

2929
- php-version: "8.1"
30-
symfony-version: "6"
30+
- php-version: "8.2"
31+
- php-version: "8.3"
32+
symfony-version: "7"
3133

3234
steps:
3335
- name: "Checkout project"
34-
uses: "actions/checkout@v2"
36+
uses: "actions/checkout@v3"
3537

3638
- name: "Install and configure PHP"
3739
uses: "shivammathur/setup-php@v2"
@@ -40,12 +42,14 @@ jobs:
4042
extensions: "pdo, pdo_sqlite"
4143
tools: "composer:v2"
4244

43-
- name: "Require Specific Symfony Version"
45+
- name: "Flex"
4446
if: "${{ matrix.symfony-version }}"
45-
run: composer require --no-update symfony/flex && composer config extra.symfony.require ${{ matrix.symfony-version}}
47+
run: |
48+
composer global require --no-progress --no-scripts --no-plugins symfony/flex
49+
composer global config --no-plugins allow-plugins.symfony/flex true
4650
4751
- name: "Install dependencies with Composer"
48-
uses: "ramsey/composer-install@v1"
52+
uses: "ramsey/composer-install@v2"
4953
with:
5054
dependency-versions: "${{ matrix.dependencies }}"
5155
composer-options: "--prefer-dist"

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,11 @@
11
Changelog
22
=========
33

4+
3.0.2
5+
-----
6+
7+
* Allow installation with Symfony 7.
8+
49
3.0.1
510
-----
611

composer.json

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -16,16 +16,15 @@
1616
],
1717
"require": {
1818
"php": "^8.0",
19-
"symfony/routing": "^6.0",
20-
"symfony/http-kernel": "^6.0",
19+
"symfony/routing": "^6.0 || ^7.0",
20+
"symfony/http-kernel": "^6.0 || ^7.0",
2121
"psr/log": "^1.0 || ^2.0 || ^3.0"
2222
},
2323
"require-dev": {
24-
"doctrine/annotations": "^1.5",
25-
"symfony/phpunit-bridge": "^6.0",
26-
"symfony/dependency-injection": "^6.0",
27-
"symfony/config": "^6.0",
28-
"symfony/event-dispatcher": "^6.0"
24+
"symfony/phpunit-bridge": "^7.0.3",
25+
"symfony/dependency-injection": "^6.0 || ^7.0",
26+
"symfony/config": "^6.0 || ^7.0",
27+
"symfony/event-dispatcher": "^6.0 || ^7.0"
2928
},
3029
"suggest": {
3130
"symfony/event-dispatcher": "DynamicRouter can optionally trigger an event at the start of matching. Minimal version ^6.0"

src/ChainRouter.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -279,11 +279,11 @@ public function setContext(RequestContext $context): void
279279
$this->context = $context;
280280
}
281281

282-
public function warmUp(string $cacheDir): array
282+
public function warmUp(string $cacheDir, ?string $buildDir = null): array
283283
{
284284
foreach ($this->all() as $router) {
285285
if ($router instanceof WarmableInterface) {
286-
$router->warmUp($cacheDir);
286+
$router->warmUp($cacheDir, $buildDir);
287287
}
288288
}
289289

src/DynamicRouter.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ public function __construct(
7373
/**
7474
* {@inheritdoc}
7575
*/
76-
public function getRouteCollection(): ?RouteCollection
76+
public function getRouteCollection(): RouteCollection
7777
{
7878
if (!$this->routeCollection instanceof RouteCollection) {
7979
$this->routeCollection = $this->provider

0 commit comments

Comments
 (0)