[Routing] Use vsprintf instead of sprintf + unpacking

fancyweb · fancyweb · commit c88686277356 · 2023-07-18T19:29:12.000+02:00
diff --git a/Matcher/Dumper/CompiledUrlMatcherDumper.php b/Matcher/Dumper/CompiledUrlMatcherDumper.php
@@ -139,8 +139,7 @@ private function generateCompiledRoutes(): string
         foreach ($staticRoutes as $path => $routes) {
             $code .= sprintf("    %s => [\n", self::export($path));
             foreach ($routes as $route) {
-                $r = array_map([__CLASS__, 'export'], $route);
-                $code .= sprintf("        [%s, %s, %s, %s, %s, %s, %s],\n", $r[0], $r[1], $r[2], $r[3], $r[4], $r[5], $r[6]);
+                $code .= vsprintf("        [%s, %s, %s, %s, %s, %s, %s],\n", array_map([__CLASS__, 'export'], $route));
             }
             $code .= "    ],\n";
         }
@@ -152,8 +151,7 @@ private function generateCompiledRoutes(): string
         foreach ($dynamicRoutes as $path => $routes) {
             $code .= sprintf("    %s => [\n", self::export($path));
             foreach ($routes as $route) {
-                $r = array_map([__CLASS__, 'export'], $route);
-                $code .= sprintf("        [%s, %s, %s, %s, %s, %s, %s],\n", $r[0], $r[1], $r[2], $r[3], $r[4], $r[5], $r[6]);
+                $code .= vsprintf("        [%s, %s, %s, %s, %s, %s, %s],\n", array_map([__CLASS__, 'export'], $route));
             }
             $code .= "    ],\n";
         }

Original file line number	Diff line number	Diff line change
`@@ -139,8 +139,7 @@ private function generateCompiledRoutes(): string`
`139`	`139`	`foreach ($staticRoutes as $path => $routes) {`
`140`	`140`	`$code .= sprintf(" %s => [\n", self::export($path));`
`141`	`141`	`foreach ($routes as $route) {`
`142`		`- $r = array_map([__CLASS__, 'export'], $route);`
`143`		`- $code .= sprintf(" [%s, %s, %s, %s, %s, %s, %s],\n", $r[0], $r[1], $r[2], $r[3], $r[4], $r[5], $r[6]);`
	`142`	`+ $code .= vsprintf(" [%s, %s, %s, %s, %s, %s, %s],\n", array_map([__CLASS__, 'export'], $route));`
`144`	`143`	`}`
`145`	`144`	`$code .= " ],\n";`
`146`	`145`	`}`
`@@ -152,8 +151,7 @@ private function generateCompiledRoutes(): string`
`152`	`151`	`foreach ($dynamicRoutes as $path => $routes) {`
`153`	`152`	`$code .= sprintf(" %s => [\n", self::export($path));`
`154`	`153`	`foreach ($routes as $route) {`
`155`		`- $r = array_map([__CLASS__, 'export'], $route);`
`156`		`- $code .= sprintf(" [%s, %s, %s, %s, %s, %s, %s],\n", $r[0], $r[1], $r[2], $r[3], $r[4], $r[5], $r[6]);`
	`154`	`+ $code .= vsprintf(" [%s, %s, %s, %s, %s, %s, %s],\n", array_map([__CLASS__, 'export'], $route));`
`157`	`155`	`}`
`158`	`156`	`$code .= " ],\n";`
`159`	`157`	`}`