Work around parse_url() bug

nicolas-grekas · nicolas-grekas · commit c0f81598425c · 2024-09-11T08:50:28.000+02:00
diff --git a/Impersonate/ImpersonateUrlGenerator.php b/Impersonate/ImpersonateUrlGenerator.php
@@ -69,7 +69,7 @@ private function buildExitPath(?string $targetUri = null): string
             $targetUri = $request->getRequestUri();
         }
 
-        $targetUri .= (parse_url($targetUri, \PHP_URL_QUERY) ? '&' : '?').http_build_query([$switchUserConfig['parameter'] => SwitchUserListener::EXIT_VALUE], '', '&');
+        $targetUri .= (str_contains($targetUri, '?') ? '&' : '?').http_build_query([$switchUserConfig['parameter'] => SwitchUserListener::EXIT_VALUE], '', '&');
 
         return $targetUri;
     }

Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,7 @@ private function buildExitPath(?string $targetUri = null): string`
`69`	`69`	`$targetUri = $request->getRequestUri();`
`70`	`70`	`}`
`71`	`71`
`72`		`- $targetUri .= (parse_url($targetUri, \PHP_URL_QUERY) ? '&' : '?').http_build_query([$switchUserConfig['parameter'] => SwitchUserListener::EXIT_VALUE], '', '&');`
	`72`	`+ $targetUri .= (str_contains($targetUri, '?') ? '&' : '?').http_build_query([$switchUserConfig['parameter'] => SwitchUserListener::EXIT_VALUE], '', '&');`
`73`	`73`
`74`	`74`	`return $targetUri;`
`75`	`75`	`}`