Skip to content

Misaligned large indices #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
4 tasks done
wooorm opened this issue Jun 24, 2022 · 1 comment
Closed
4 tasks done

Misaligned large indices #18

wooorm opened this issue Jun 24, 2022 · 1 comment
Labels
💪 phase/solved Post is done 🦋 type/enhancement This is great to have

Comments

@wooorm
Copy link
Member

wooorm commented Jun 24, 2022

Initial checklist

Problem

Indices longer that 9 break the alignment

RootNode[1] (1:1-1:49, 0-48)
└─0 ParagraphNode[1] (1:1-1:49, 0-48)
    └─0 SentenceNode[23] (1:1-1:49, 0-48)
        ├─0 WordNode[1] (1:1-1:2, 0-1)
        │   │ data: {"partOfSpeech":"PRP"}
        │   └─0 TextNode "I" (1:1-1:2, 0-1)
        ...
        ├─11 WordNode[1] (1:22-1:24, 21-23)
        │   │ data: {"partOfSpeech":"TO"}
        │   └─0 TextNode "to" (1:22-1:24, 21-23)

Note the alignment of | before data, textnode.

Solution

  • Align contents
  • Optionally pad all indices lower than 10.

Alternatives

fine as is?

@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Jun 24, 2022
@wooorm wooorm closed this as completed in 42b5370 Jul 23, 2022
@github-actions

This comment has been minimized.

@wooorm wooorm added 🦋 type/enhancement This is great to have 💪 phase/solved Post is done labels Jul 23, 2022
@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label Jul 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 phase/solved Post is done 🦋 type/enhancement This is great to have
Development

No branches or pull requests

1 participant