Skip to content

Commit 3442340

Browse files
sysadmindjaimeyh
authored andcommitted
Refactor snapshots collector (prometheus-community#789)
- Move metric Desc to vars to aid in unused linter checks - Use new Collector interface - Add a util getURL func. Similar funcs are in most of the collectors. The only difference is typically what struct to unmarshal the JSON into. This func just returns []byte so that the caller can handle the unique data structure. This does not adjust the labels on the metrics. I want that to be handled separately to make sure the refactor itself matches existing behavior. Signed-off-by: Joe Adams <[email protected]>
1 parent 422dfac commit 3442340

File tree

5 files changed

+227
-253
lines changed

5 files changed

+227
-253
lines changed

CHANGELOG.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,11 @@
1+
## master / unreleased
2+
3+
BREAKING CHANGES:
4+
5+
The flag `--es.snapshots` has been renamed to `--collector.snapshots`.
6+
7+
* [CHANGE] Rename --es.snapshots to --collector.snapshots #XXX
8+
19
## 1.6.0 / 2023-06-22
210

311
BREAKING CHANGES:

0 commit comments

Comments
 (0)