Skip to content

Commit 573b945

Browse files
vdemeestertekton-robot
authored andcommitted
Remove conversion configuration for ClusterTask
`ClusterTask` only exists in `v1beta1` and will never have a `v1` thus doesn't need to be registered in the conversion webhook. Prior to this commit, some tooling (like https://github.com/openshift/cluster-kube-apiserver-operator/) might assume there is a conversion webhook and then fail to communicate with it (because we do not register `ClusterTask` in the conversion webhook part) ; generating a lot of spam log. As a rules of thumb, if we are not registering/refering an object in `newConversionController` (in `cmd/webhook/main.go`), the `conversion` field in the CRD shouldn't be defined either. Signed-off-by: Vincent Demeester <[email protected]>
1 parent b28f5d6 commit 573b945

File tree

1 file changed

+0
-8
lines changed

1 file changed

+0
-8
lines changed

config/300-clustertask.yaml

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -51,11 +51,3 @@ spec:
5151
- tekton
5252
- tekton-pipelines
5353
scope: Cluster
54-
conversion:
55-
strategy: Webhook
56-
webhook:
57-
conversionReviewVersions: ["v1beta1"]
58-
clientConfig:
59-
service:
60-
name: tekton-pipelines-webhook
61-
namespace: tekton-pipelines

0 commit comments

Comments
 (0)