You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If the workflow below is started, and then a signal and an update are sent in the 2nd Workflow task, the workflow exits without the update handler ever being executed. See @bergundy's original comment #1459 (review)
Fixing this will be backwards incompatible w.r.t. replay of existing workflows, so will need to use an SDK flag.
We did not update that code when we implemented update because core orders the activation jobs and we were planning to eliminate this typescript code, but this decision overlooked the fact that update and signal activation jobs need to be placed into the same batch in order for them all to be executed before giving the chance for an awaitable such as the workflow.condition() above to be unblocked.
The text was updated successfully, but these errors were encountered:
Uh oh!
There was an error while loading. Please reload this page.
If the workflow below is started, and then a signal and an update are sent in the 2nd Workflow task, the workflow exits without the update handler ever being executed. See @bergundy's original comment #1459 (review)
The fix will be to group update activation jobs together with signals here:
sdk-typescript/packages/worker/src/workflow/vm-shared.ts
Lines 314 to 317 in ce0532f
Fixing this will be backwards incompatible w.r.t. replay of existing workflows, so will need to use an SDK flag.
We did not update that code when we implemented update because core orders the activation jobs and we were planning to eliminate this typescript code, but this decision overlooked the fact that update and signal activation jobs need to be placed into the same batch in order for them all to be executed before giving the chance for an awaitable such as the
workflow.condition()
above to be unblocked.The text was updated successfully, but these errors were encountered: