Skip to content

Better error messages for ops forbidden in Eager mode #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rnett opened this issue Nov 21, 2020 · 0 comments · Fixed by #169
Closed

Better error messages for ops forbidden in Eager mode #154

rnett opened this issue Nov 21, 2020 · 0 comments · Fixed by #169

Comments

@rnett
Copy link
Contributor

rnett commented Nov 21, 2020

Currently, if you try to use placeholder in Eager mode you get a cryptic error message that says nothing about it being forbidden in eager in mode (I had to look it up on StackOverflow). As far as I'm aware there's no ops that are eager only, but I think throwing a custom exception for mode-dependent ops is reasonable and helpful.

I'd probably do this in EagerOperationBuilder.build rather than in the ops classes to catch custom created ops. If that's fine I can make a PR if a list of forbidden ops is provided (or just with placeholder).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant