-
Notifications
You must be signed in to change notification settings - Fork 233
Why is There No Typescript Documentation? #974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
P.S. Based on https://github.com/testing-library/react-hooks-testing-library/blob/main/src/types/react.ts it looks like the function actually takes two type arguments:
Even a single line of documentation:
would help clarify things. (Also, the error message above mentioned "2-5" type arguments ... maybe another sentence could cover what those args are?) EDIT: Actually I think I was looking at the wrong place (the perils of trying to make your own docs from unknown source code 😄). It looks like the real type to look at is the It also takes a third |
This project is (probably) not going to be worked on further as evidences by the entire year of inactivity and README comments, and I don't think it's particularly useful (nor common amongst ts libs in my experience) to provide type documentation when typescript itself provides the self-documentation, if not your IDE. For example, with the right LSP/tsserver setup, your IDE will likely tell you/fail compilation instantly as |
This library clearly supports TypeScript, because I see types mentioned in the commit messages, eg.
However, the word "type" doesn't even appear in your documentation or readme file. To be fair, types don't exactly require a ton of docs, but it'd be nice to at least mention how they're supposed to be used.
For instance:
So it seems renderHooks expects 2-5 type arguments ... surely you could spare a few lines in the docs to tell us what those arguments should be?
The text was updated successfully, but these errors were encountered: