Skip to content

Commit 856213b

Browse files
committed
Merge branch 'setup-python-action' into mhegazy/vm-images-no-python
2 parents da89211 + e53a599 commit 856213b

File tree

1 file changed

+9
-11
lines changed

1 file changed

+9
-11
lines changed

.github/workflows/swift-toolchain.yml

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -284,6 +284,10 @@ env:
284284
WORKAROUND_WINDOWS_PINNED_BOOTSTRAP_TOOLCHAIN_REPO: thebrowsercompany/swift-build
285285
WORKAROUND_WINDOWS_PINNED_BOOTSTRAP_TOOLCHAIN_VERSION: 6.0.0-20241216.0
286286

287+
# Workaround to build the early swift-driver without the workaround for the MSVC version.
288+
WORKAROUND_WINDOWS_EARLY_SWIFT_DRIVER_TOOLCHAIN_REPO: thebrowsercompany/swift-build
289+
WORKAROUND_WINDOWS_EARLY_SWIFT_DRIVER_TOOLCHAIN_VERSION: 6.2.0-20250630.0
290+
287291
# Workaround for issues with building with MSVC 14.43.
288292
# See https://github.com/swiftlang/swift/issues/79852 for details.
289293
# TODO: Remove this once the bootstrap toolchain is updated to 6.1.
@@ -785,10 +789,9 @@ jobs:
785789
- uses: ./SourceCache/ci-build/.github/actions/setup-build
786790
id: setup-build
787791
with:
788-
msvc-version: ${{ env.WORKAROUND_BOOTSTRAP_WINDOWS_MSVC_VERSION }}
789792
host-arch: ${{ matrix.arch }}
790-
swift-version: ${{ inputs.build_os == 'Windows' && env.WORKAROUND_WINDOWS_PINNED_BOOTSTRAP_TOOLCHAIN_VERSION || env.PINNED_BOOTSTRAP_TOOLCHAIN_VERSION }}
791-
swift-repo: ${{ inputs.build_os == 'Windows' && env.WORKAROUND_WINDOWS_PINNED_BOOTSTRAP_TOOLCHAIN_REPO || '' }}
793+
swift-version: ${{ inputs.build_os == 'Windows' && env.WORKAROUND_WINDOWS_EARLY_SWIFT_DRIVER_TOOLCHAIN_VERSION || env.PINNED_BOOTSTRAP_TOOLCHAIN_VERSION }}
794+
swift-repo: ${{ inputs.build_os == 'Windows' && env.WORKAROUND_WINDOWS_EARLY_SWIFT_DRIVER_TOOLCHAIN_REPO || '' }}
792795

793796
- uses: actions/[email protected]
794797
with:
@@ -824,14 +827,8 @@ jobs:
824827
- name: Build early swift-driver
825828
run: |
826829
$env:SWIFTCI_USE_LOCAL_DEPS=1
827-
$BuildToolsVersion = "${{ steps.setup-build.outputs.windows-build-tools-version }}"
828-
$ExtraFlags = if ($BuildToolsVersion -ne "") {
829-
@("-Xlinker", "${env:SDKROOT}/usr/lib/swift/windows/${{ matrix.cpu }}/swiftCore.lib",
830-
"-Xswiftc", "-visualc-tools-version", "-Xswiftc", "${BuildToolsVersion}",
831-
"-Xbuild-tools-swiftc", "-visualc-tools-version", "-Xbuild-tools-swiftc", "${BuildToolsVersion}",
832-
"-Xcc", "-Xmicrosoft-visualc-tools-version", "-Xcc", "${BuildToolsVersion}",
833-
"-Xcxx", "-Xmicrosoft-visualc-tools-version", "-Xcxx", "${BuildToolsVersion}"
834-
)
830+
$ExtraFlags = if ("${{ matrix.os }}" -eq "Windows") {
831+
@("-Xlinker", "${env:SDKROOT}/usr/lib/swift/windows/${{ matrix.cpu }}/swiftCore.lib")
835832
} else {
836833
@()
837834
}
@@ -1137,6 +1134,7 @@ jobs:
11371134
-D CLANG_VENDOR_UTI=org.compnerd.dt `
11381135
-D cmark-gfm_DIR=${{ github.workspace }}/BinaryCache/Library/cmark-gfm-${{ inputs.swift_cmark_version }}/usr/lib/cmake `
11391136
-D LibXml2_DIR=${{ github.workspace }}/BinaryCache/Library/libxml2-${{ inputs.libxml2_version }}/usr/lib/cmake/libxml2-${{ inputs.libxml2_version }} `
1137+
-D LLDB_LIBXML2_VERSION="${{ inputs.libxml2_version }}" `
11401138
-D PACKAGE_VENDOR=compnerd.org `
11411139
-D SWIFT_VENDOR=compnerd.org `
11421140
-D LLVM_PARALLEL_LINK_JOBS=8 `

0 commit comments

Comments
 (0)