Merge pull request #9 from moufmouf/master

Methods of extended classes are now properly ignored.

Author: moufmouf

src/Rules/TypeHints/AbstractMissingTypeHintRule.php

@@ -313,6 +313,9 @@ private function isInherited(ReflectionMethod $method, ReflectionClass $class =
 
         $parentClass = $class->getParentClass();
         if ($parentClass !== null) {
+            if ($parentClass->hasMethod($method->getName())) {
+                return true;
+            }
             return $this->isInherited($method, $parentClass);
         }
 

tests/Rules/TypeHints/MissingTypeHintRuleInMethodTest.php

@@ -21,6 +21,11 @@ public function testCheckCatchedException()
 				'In method "Foo::test", parameter $no_type_hint has no type-hint and no @param annotation.',
 				5,
 			],
-		]);
+            [
+                'In method "Baz::notInherited", parameter $no_type_hint has no type-hint and no @param annotation.',
+                36,
+            ],
+
+        ]);
 	}
 }

tests/Rules/TypeHints/data/StubClass.php

@@ -0,0 +1,19 @@
+<?php
+
+
+namespace TheCodingMachine\PHPStan\Rules\TypeHints\data;
+
+class ParentStubClass
+{
+    public function bazbaz($no_type_hint) {
+
+    }
+}
+
+
+class StubClass extends ParentStubClass
+{
+    public function baz($no_type_hint) {
+
+    }
+}

tests/Rules/TypeHints/data/typehints_in_methods.php

@@ -19,3 +19,22 @@ public function foo($no_type_hint): void
     {
     }
 }
+
+class BazClass extends \TheCodingMachine\PHPStan\Rules\TypeHints\data\StubClass
+{
+    // Extended function
+    public function baz($no_type_hint)
+    {
+
+    }
+
+    public function bazbaz($no_type_hint)
+    {
+
+    }
+
+    public function notInherited($no_type_hint): void
+    {
+
+    }
+}