Add non_missing_aes to geom_tile (#4683)

thomasp85 · web-flow · commit 74e11033607d · 2021-12-06T10:41:22.000+01:00
diff --git a/NEWS.md b/NEWS.md
@@ -1,5 +1,8 @@
 # ggplot2 (development version)
 
+* `geom_tile()` now correctly recognises missing data in `xmin`, `xmax`, `ymin`,
+  and `ymax` (@thomasp85 and @sigmapi, #4495)
+
 * `geom_hex()` will now use the binwidth from `stat_bin_hex()` if present, 
   instead of deriving it (@thomasp85, #4580)
   
diff --git a/R/geom-tile.r b/R/geom-tile.r
@@ -113,5 +113,10 @@ GeomTile <- ggproto("GeomTile", GeomRect,
 
   required_aes = c("x", "y"),
 
+  # These aes columns are created by setup_data(). They need to be listed here so
+  # that GeomRect$handle_na() properly removes any bars that fall outside the defined
+  # limits, not just those for which x and y are outside the limits
+  non_missing_aes = c("xmin", "xmax", "ymin", "ymax"),
+
   draw_key = draw_key_polygon
 )

Original file line number	Diff line number	Diff line change
`@@ -113,5 +113,10 @@ GeomTile <- ggproto("GeomTile", GeomRect,`
`113`	`113`
`114`	`114`	`required_aes = c("x", "y"),`
`115`	`115`
	`116`	`+ # These aes columns are created by setup_data(). They need to be listed here so`
	`117`	`+ # that GeomRect$handle_na() properly removes any bars that fall outside the defined`
	`118`	`+ # limits, not just those for which x and y are outside the limits`
	`119`	`+ non_missing_aes = c("xmin", "xmax", "ymin", "ymax"),`
	`120`	`+`
`116`	`121`	`draw_key = draw_key_polygon`
`117`	`122`	`)`