Skip to content

Remove build time code execution #3233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
thomasp85 opened this issue Apr 11, 2019 · 4 comments · Fixed by #3275
Closed

Remove build time code execution #3233

thomasp85 opened this issue Apr 11, 2019 · 4 comments · Fixed by #3275

Comments

@thomasp85
Copy link
Member

One example:

ggplot_global$theme_current <- theme_gray()

but we need to scour the code base for others

@thomasp85 thomasp85 added this to the ggplot2 3.2.0 milestone Apr 11, 2019
@clauswilke
Copy link
Member

I was planning to rewrite how themes work. This line would be part of that. But I'm not sure I can do it before April 30. May have to wait until after ggplot2 3.2.0.

@thomasp85
Copy link
Member Author

yeah... I don't think we can get a whole new theme infrastructure in on this release... The above was just an example — we need to go through it all

@clauswilke
Copy link
Member

However, I do have a half-finished PR (#2784). I'll spend a few hours to see if it can be brought into a mergeable state.

@lock
Copy link

lock bot commented Oct 26, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Oct 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants