Skip to content

tmux-logging/scripts/start_logging.sh in bashrc not working #31

Open
@bedge

Description

@bedge

#28
has some shortcomings. (Unless I'm just being stupid, which is entirely possible)

  • Doesn't observe .tmux/conf settings, eg:
# https://github.com/tmux-plugins/tmux-logging/pull/20
set -g @logging-path "$HOME/log/tmux/%Y-%m-%d"
set -g @logging-filename "#{session_name}-#{window_name}-#{pane_index}.log"

  • requires $log_file already be set elsewhere, negating the logic already provided by the above config settings.

Given the key bindings:

bind-key -T prefix P run-shell /Users/bedge/.tmux/plugins/tmux-logging/scripts/toggle_logging.sh

I would expect being able to run:
~/.tmux/plugins/tmux-logging/scripts/start_logging.sh

to enable logging to the file cfg'd above, but it doesn't.

With that in my bashrc, logging is not enabled, at least not to the file I have configured. (see above)
However when I run
/Users/bedge/.tmux/plugins/tmux-logging/scripts/toggle_logging.sh
I get a "...logging ended" message, implying some component did think it was logging.

Running it again DOES start logging to the right place. WTF am I doing wrong?

This also pops out periodically:

❯ ~/.tmux/plugins/tmux-logging/scripts/toggle_logging.sh
/Users/bedge/.tmux/plugins/tmux-logging/scripts/shared.sh: line 5: [: not: binary operator expected

Great plugin, despite my whining BTW.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions