Fix memory leaks in pool properties handling

rkojedzinszky · tonyhutter · commit 5952fc15b973 · 2025-04-16T09:59:45.000-07:00
Reviewed-by: Alexander Motin <mav@FreeBSD.org> Signed-off-by: Richard Kojedzinszky <richard@kojedz.in> Closes openzfs#17208
diff --git a/lib/libzfs/libzfs_pool.c b/lib/libzfs/libzfs_pool.c
@@ -85,6 +85,7 @@ zpool_get_all_props(zpool_handle_t *zhp)
 		fnvlist_add_string_array(innvl, ZPOOL_GET_PROPS_NAMES,
 		    zhp->zpool_propnames, zhp->zpool_n_propnames);
 		zcmd_write_src_nvlist(hdl, &zc, innvl);
+		fnvlist_free(innvl);
 	}
 
 	zcmd_alloc_dst_nvlist(hdl, &zc, 0);
@@ -332,7 +333,7 @@ zpool_get_prop(zpool_handle_t *zhp, zpool_prop_t prop, char *buf,
 	 */
 	if (prop == ZPOOL_PROP_DEDUPCACHED) {
 		zpool_add_propname(zhp, ZPOOL_DEDUPCACHED_PROP_NAME);
-		(void) zpool_get_all_props(zhp);
+		(void) zpool_props_refresh(zhp);
 	}
 
 	if (zhp->zpool_props == NULL && zpool_get_all_props(zhp) &&

Original file line number	Diff line number	Diff line change
`@@ -85,6 +85,7 @@ zpool_get_all_props(zpool_handle_t *zhp)`
`85`	`85`	`fnvlist_add_string_array(innvl, ZPOOL_GET_PROPS_NAMES,`
`86`	`86`	`zhp->zpool_propnames, zhp->zpool_n_propnames);`
`87`	`87`	`zcmd_write_src_nvlist(hdl, &zc, innvl);`
	`88`	`+ fnvlist_free(innvl);`
`88`	`89`	`}`
`89`	`90`
`90`	`91`	`zcmd_alloc_dst_nvlist(hdl, &zc, 0);`
`@@ -332,7 +333,7 @@ zpool_get_prop(zpool_handle_t zhp, zpool_prop_t prop, char buf,`
`332`	`333`	`*/`
`333`	`334`	`if (prop == ZPOOL_PROP_DEDUPCACHED) {`
`334`	`335`	`zpool_add_propname(zhp, ZPOOL_DEDUPCACHED_PROP_NAME);`
`335`		`- (void) zpool_get_all_props(zhp);`
	`336`	`+ (void) zpool_props_refresh(zhp);`
`336`	`337`	`}`
`337`	`338`
`338`	`339`	`if (zhp->zpool_props == NULL && zpool_get_all_props(zhp) &&`