Skip to content

Commit a14fe16

Browse files
committed
Remove User-Agent override in StatementClient
User-Agent header is already added when HttpClientFactory is used to construct OkHttpClient
1 parent bdf46a9 commit a14fe16

File tree

1 file changed

+1
-6
lines changed

1 file changed

+1
-6
lines changed

client/trino-client/src/main/java/io/trino/client/StatementClientV1.java

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -60,11 +60,9 @@
6060
import static com.google.common.base.Throwables.getCausalChain;
6161
import static com.google.common.collect.ImmutableSet.toImmutableSet;
6262
import static com.google.common.net.HttpHeaders.ACCEPT_ENCODING;
63-
import static com.google.common.net.HttpHeaders.USER_AGENT;
6463
import static io.trino.client.HttpStatusCodes.shouldRetry;
6564
import static io.trino.client.ProtocolHeaders.TRINO_HEADERS;
6665
import static io.trino.client.TrinoJsonCodec.jsonCodec;
67-
import static io.trino.client.UserAgentBuilder.createUserAgent;
6866
import static java.lang.String.format;
6967
import static java.net.HttpURLConnection.HTTP_BAD_METHOD;
7068
import static java.net.HttpURLConnection.HTTP_NOT_FOUND;
@@ -82,7 +80,6 @@ class StatementClientV1
8280
private static final TrinoJsonCodec<QueryResults> QUERY_RESULTS_CODEC = jsonCodec(QueryResults.class);
8381

8482
private static final Splitter COLLECTION_HEADER_SPLITTER = Splitter.on('=').limit(2).trimResults();
85-
private static final String USER_AGENT_VALUE = createUserAgent(StatementClientV1.class.getSimpleName());
8683
private final Call.Factory httpCallFactory;
8784
private final String query;
8885
private final AtomicReference<QueryResults> currentResults = new AtomicReference<>();
@@ -381,9 +378,7 @@ public boolean isClearTransactionId()
381378

382379
private Request.Builder prepareRequest(HttpUrl url)
383380
{
384-
Request.Builder builder = new Request.Builder()
385-
.addHeader(USER_AGENT, USER_AGENT_VALUE)
386-
.url(url);
381+
Request.Builder builder = new Request.Builder().url(url);
387382
user.ifPresent(requestUser -> builder.addHeader(TRINO_HEADERS.requestUser(), requestUser));
388383
originalUser.ifPresent(originalUser -> builder.addHeader(TRINO_HEADERS.requestOriginalUser(), originalUser));
389384
if (compressionDisabled) {

0 commit comments

Comments
 (0)