You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
[BACKEND] Set LLVM_ABI_BREAKING_CHECKS to be able to update the llvm version (#4512)
This PR is setting LLVM_ABI_BREAKING_CHECKS=FORCE_OFF, similar of how we
do it inside Google. In this way, we are forcing the structures that
relies in Hashing.h to use a deterministic seed.
We were not able to update the llvm version. The culprit llvm commit is
llvm/llvm-project@ce80c80,
that basically uses a non-deterministic seed if the previous "Flag" is
set.
There were some discussions in
#4338, and the other option
would be to check/replace code and tests that are overly depending on
the determinism of llvm/include/llvm/ADT/Hashing.h (DenseMap and
DenseSet mostly).
I think that the priority is first to be able to update the llvm
version, but if OpenAI is interested I could work on replacing them (for
MapVector), in order to fix all the failing unit tests, and then we can
set the LLVM_ABI_BREAKING_CHECKS again to "WITH_ASSERTS".
- [x] I am not making a trivial change, such as fixing a typo in a
comment.
- [x] I have written a PR description following these
[rules](https://cbea.ms/git-commit/#why-not-how).
- [x] I have run `pre-commit run --from-ref origin/main --to-ref HEAD`.
- [x] This PR does not need a test because it's just setting a variable
for LLVM.
- [x] I have not added any `lit` tests.
Co-authored-by: Tori Baker <[email protected]>
0 commit comments