Skip to content

add copy icon slug to single/home templates #1675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 26 commits into from
Closed

add copy icon slug to single/home templates #1675

wants to merge 26 commits into from

Conversation

inwardmovement
Copy link
Contributor

@inwardmovement inwardmovement commented Apr 1, 2023

closes #298

@XhmikosR XhmikosR added docs Improvements or additions to documentation enhancement New feature or request labels Apr 1, 2023
@inwardmovement inwardmovement changed the title add copy icon slug to single template add copy icon slug to single/home templates Apr 1, 2023
@inwardmovement
Copy link
Contributor Author

inwardmovement commented Apr 1, 2023

@XhmikosR The home part is a bit inelegant (leveraging he highlight shortcode but hiding it) but it seems to work as I imagined.

@XhmikosR
Copy link
Member

XhmikosR commented Apr 3, 2023

Doesn't look bad!

Please don't rebase/merge so regularly because we are notified each time. Someone will take a look and we'll let you know :)

@XhmikosR XhmikosR requested a review from mdo April 5, 2023 17:44
@XhmikosR
Copy link
Member

XhmikosR commented Apr 5, 2023

@mdo what's your take on this?

@inwardmovement
Copy link
Contributor Author

Maybe we could add a paragraph below the heading that says something like "Useful when dynamically importing the SVG".

@XhmikosR
Copy link
Member

XhmikosR commented Apr 5, 2023

I don't think we need more things in the homepage TBH. The homepage is already too bloated and even this change might be too much with the current state of things.

If we eventually split it, it should be easier.

Another thing we could do is show the copy on hover but it's bad for mobile and not sure about a11y either.

Let's wait to hear if @mdo likes this approach and we'll see how to proceed :)

@inwardmovement
Copy link
Contributor Author

inwardmovement commented Apr 5, 2023

I don't think we need more things in the homepage

I meant on the single page

Another thing we could do is show the copy on hover

It's already showing on hover, no? I see it as a progressive enhancement for desktop, as it's hidden on mobile.

@mdo
Copy link
Member

mdo commented Sep 12, 2023

All the new-ish additions to the sidebar make me think we need a redesign of sorts here. Going to tackle that before merging this one in I think.

@inwardmovement inwardmovement closed this by deleting the head repository Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation enhancement New feature or request
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Copy icon slug to clipboard from single/homepage template
3 participants