-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
add copy icon slug to single/home templates #1675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ovement/icons into docs-copy-icon-slug-home
@XhmikosR The home part is a bit inelegant (leveraging he |
Doesn't look bad! Please don't rebase/merge so regularly because we are notified each time. Someone will take a look and we'll let you know :) |
@mdo what's your take on this? |
Maybe we could add a paragraph below the heading that says something like "Useful when dynamically importing the SVG". |
I don't think we need more things in the homepage TBH. The homepage is already too bloated and even this change might be too much with the current state of things. If we eventually split it, it should be easier. Another thing we could do is show the copy on hover but it's bad for mobile and not sure about a11y either. Let's wait to hear if @mdo likes this approach and we'll see how to proceed :) |
I meant on the single page
It's already showing on hover, no? I see it as a progressive enhancement for desktop, as it's hidden on mobile. |
All the new-ish additions to the sidebar make me think we need a redesign of sorts here. Going to tackle that before merging this one in I think. |
closes #298