Skip to content

Commit b991976

Browse files
Fix modal route registration circular import (#18953)
* fix modal route registration circular import * Update modal-route-registration.controller.ts
1 parent c0f820a commit b991976

File tree

9 files changed

+7
-7
lines changed

9 files changed

+7
-7
lines changed

src/Umbraco.Web.UI.Client/src/packages/core/router/index.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
export * from './components/not-found/route-not-found.element.js';
2-
export * from './components/router-slot/index.js';
1+
export * from './route/index.js';
32
export * from './contexts/index.js';
43
export * from './encode-folder-name.function.js';
54
export * from './modal-registration/modal-route-registration.controller.js';

src/Umbraco.Web.UI.Client/src/packages/core/router/modal-registration/modal-route-registration.controller.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
import { UMB_ROUTE_CONTEXT, UMB_ROUTE_PATH_ADDENDUM_CONTEXT } from '../index.js';
21
import { encodeFolderName } from '../encode-folder-name.function.js';
32
import type { UmbModalRouteRegistration } from './modal-route-registration.interface.js';
43
import type {
@@ -13,6 +12,8 @@ import { UmbControllerBase } from '@umbraco-cms/backoffice/class-api';
1312
import { UmbId } from '@umbraco-cms/backoffice/id';
1413
import type { UmbDeepPartialObject } from '@umbraco-cms/backoffice/utils';
1514
import type { IRouterSlot, Params } from '@umbraco-cms/backoffice/external/router-slot';
15+
import { UMB_ROUTE_PATH_ADDENDUM_CONTEXT } from '../contexts/route-path-addendum.context-token.js';
16+
import { UMB_ROUTE_CONTEXT } from '../route/route.context.js';
1617

1718
export type UmbModalRouteBuilder = (params: { [key: string]: string | number } | null) => string;
1819

src/Umbraco.Web.UI.Client/src/packages/core/router/components/router-slot/index.ts renamed to src/Umbraco.Web.UI.Client/src/packages/core/router/route/index.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
export * from './not-found/route-not-found.element.js';
12
export * from './route.context.js';
23
export * from './router-slot-change.event.js';
34
export * from './router-slot-init.event.js';
Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ import { UmbLitElement } from '@umbraco-cms/backoffice/lit-element';
55
/**
66
* A fallback view to be used in Workspace Views, maybe this can be upgraded at a later point.
77
*/
8-
// TODO: Rename and move this file to a more generic place.
98
@customElement('umb-route-not-found')
109
export class UmbRouteNotFoundElement extends UmbLitElement {
1110
override render() {
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
1-
import { umbGenerateRoutePathBuilder } from '../../generate-route-path-builder.function.js';
2-
import type { UmbModalRouteRegistration } from '../../modal-registration/modal-route-registration.interface.js';
31
import type { UmbRoute } from './route.interface.js';
42
import type { IRouterSlot } from '@umbraco-cms/backoffice/external/router-slot';
53
import { UmbContextToken } from '@umbraco-cms/backoffice/context-api';
64
import type { UmbControllerHost } from '@umbraco-cms/backoffice/controller-api';
75
import { UmbContextBase } from '@umbraco-cms/backoffice/class-api';
86
import { UMB_MODAL_MANAGER_CONTEXT } from '@umbraco-cms/backoffice/modal';
97
import { UmbStringState, mergeObservables } from '@umbraco-cms/backoffice/observable-api';
8+
import type { UmbModalRouteRegistration } from '../modal-registration/modal-route-registration.interface.js';
9+
import { umbGenerateRoutePathBuilder } from '../generate-route-path-builder.function.js';
1010

1111
const EmptyDiv = document.createElement('div');
1212

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
import '@umbraco-cms/backoffice/external/router-slot';
2-
import { UmbRoutePathAddendumResetContext } from '../../contexts/route-path-addendum-reset.context.js';
32
import { UmbRouterSlotInitEvent } from './router-slot-init.event.js';
43
import { UmbRouterSlotChangeEvent } from './router-slot-change.event.js';
54
import type { UmbRoute } from './route.interface.js';
65
import { UmbRouteContext } from './route.context.js';
76
import { css, html, type PropertyValueMap, customElement, property } from '@umbraco-cms/backoffice/external/lit';
87
import { UmbLitElement } from '@umbraco-cms/backoffice/lit-element';
98
import type { IRouterSlot } from '@umbraco-cms/backoffice/external/router-slot';
9+
import { UmbRoutePathAddendumResetContext } from '../contexts/route-path-addendum-reset.context.js';
1010

1111
/**
1212
* @element umb-router-slot

0 commit comments

Comments
 (0)