From fb8bc369ac38f0273a1d7c334c5a0f73866dc675 Mon Sep 17 00:00:00 2001
From: Richard Thompson <richarth@gmail.com>
Date: Mon, 19 Feb 2024 18:37:20 +0000
Subject: [PATCH] Unable to correct an invalid alias on a property

When adding a new property with a short name such as A, an invalid alias will be created.

If you then correct just the alias you won't be able to save your new property.  I've added a Playwright test which demos this.

You can get around this by changing the name and the alias but it isn't immediately obvious, as the error on the name isn't flagged.
---
 .../Settings/documentTypes.spec.ts            | 63 ++++++++++++++++++-
 1 file changed, 60 insertions(+), 3 deletions(-)
 mode change 100644 => 100755 tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/documentTypes.spec.ts

diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/documentTypes.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/documentTypes.spec.ts
old mode 100644
new mode 100755
index 99f578dbd6fd..cd02bbab5298
--- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/documentTypes.spec.ts
+++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/documentTypes.spec.ts
@@ -71,12 +71,69 @@ test.describe('Document types', () => {
 
     // This delete button for some reason does not have the usual general_delete label
     await umbracoUi.clickElement(umbracoUi.getButtonByLabelKey("delete"));
-    
+
     const docTypeLocator = await page.locator("text=" + name);
-    
+
     // Assert
     await expect(docTypeLocator).toHaveCount(0);
-    
+
+    // Clean up
+    await umbracoApi.documentTypes.ensureNameNotExists(name);
+    await umbracoApi.templates.ensureNameNotExists(name);
+  });
+
+  test('Correct an invalid alias for a new property on a new doc type', async ({ page, umbracoApi, umbracoUi }) => {
+    const name = "Test document type 2";
+
+    await umbracoApi.documentTypes.ensureNameNotExists(name);
+    await umbracoApi.templates.ensureNameNotExists(name);
+
+    await umbracoUi.goToSection(ConstantHelper.sections.settings);
+    await umbracoUi.waitForTreeLoad(ConstantHelper.sections.settings);
+    await umbracoUi.clickElement(umbracoUi.getTreeItem("settings", ["Document Types"]), {button: "right"})
+
+    await umbracoUi.clickElement(umbracoUi.getContextMenuAction(ConstantHelper.actions.create));
+    await umbracoUi.clickElement(umbracoUi.getContextMenuAction(ConstantHelper.actions.documentType));
+
+    await umbracoUi.setEditorHeaderName(name);
+
+    // Add a property group
+    await page.locator('[data-element="group-add"]').click();
+    await page.locator('.umb-group-builder__group-title-input').fill('Group name');
+    // Add a property
+    await page.locator('[data-element="property-add"]').click();
+    // enter a label that will generate an invalid alias
+    await page.locator('.editor-label').fill('A');
+    await page.locator('[data-element="editor-add"]').click();
+
+    // Search for textstring
+    await page.locator('#datatype-search').fill('Textstring');
+
+    await page
+      .locator('ul.umb-card-grid li [title="Textstring"]')
+      .locator("xpath=ancestor::li")
+      .click();
+
+    await umbracoUi.clickElement(umbracoUi.getButtonByLabelKey(ConstantHelper.buttons.submit));
+
+    // ensure we got an error that our property alias was invalid
+    await expect(page.locator('[alias="model.property.alias"] .umb-validation-label')).toBeVisible();
+
+    // click the lock icon to change the alias
+    await page.locator('[alias="model.property.alias"] .umb-locked-field__toggle').click();
+
+    // change the property alias to a valid alias
+    await page.locator('[alias="model.property.alias"] [name="lockedField"]').fill('test');
+
+    // submit our new property
+    await umbracoUi.clickElement(umbracoUi.getButtonByLabelKey(ConstantHelper.buttons.submit));
+
+    // ensure we no longer get an error that our property alias is invalid
+    await expect(page.locator('[alias="model.property.alias"] .umb-validation-label')).toBeHidden();
+
+    // Assert that the doc type has now been saved successfully
+    await umbracoUi.isSuccessNotificationVisible();
+
     // Clean up
     await umbracoApi.documentTypes.ensureNameNotExists(name);
     await umbracoApi.templates.ensureNameNotExists(name);