diff --git a/src/Umbraco.Web.UI.Client/src/packages/core/repository/detail/detail-repository-base.ts b/src/Umbraco.Web.UI.Client/src/packages/core/repository/detail/detail-repository-base.ts index fe4e1a325604..9474630934a2 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/core/repository/detail/detail-repository-base.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/core/repository/detail/detail-repository-base.ts @@ -3,8 +3,6 @@ import type { UmbRepositoryResponse, UmbRepositoryResponseWithAsObservable } fro import type { UmbDetailDataSource, UmbDetailDataSourceConstructor } from './detail-data-source.interface.js'; import type { UmbDetailRepository } from './detail-repository.interface.js'; import type { UmbControllerHost } from '@umbraco-cms/backoffice/controller-api'; -import type { UmbNotificationContext, UmbNotificationHandler } from '@umbraco-cms/backoffice/notification'; -import { UMB_NOTIFICATION_CONTEXT } from '@umbraco-cms/backoffice/notification'; import type { UmbContextToken } from '@umbraco-cms/backoffice/context-api'; import type { UmbDetailStore } from '@umbraco-cms/backoffice/store'; import type { UmbApi } from '@umbraco-cms/backoffice/extension-api'; @@ -21,10 +19,6 @@ export abstract class UmbDetailRepositoryBase< #detailStore?: UmbDetailStore; protected detailDataSource: UmbDetailDataSourceType; - #notificationContext?: UmbNotificationContext; - #createSuccessNotification?: UmbNotificationHandler; - #updateSuccessNotification?: UmbNotificationHandler; - #deleteSuccessNotification?: UmbNotificationHandler; constructor( host: UmbControllerHost, @@ -43,10 +37,6 @@ export abstract class UmbDetailRepositoryBase< this.consumeContext(detailStoreContextAlias, (instance) => { this.#detailStore = instance; }).asPromise({ preventTimeout: true }), - - this.consumeContext(UMB_NOTIFICATION_CONTEXT, (instance) => { - this.#notificationContext = instance; - }).asPromise({ preventTimeout: true }), ]); } @@ -98,10 +88,6 @@ export abstract class UmbDetailRepositoryBase< if (createdData) { this.#detailStore?.append(createdData); - this.#createSuccessNotification?.close(); - // TODO: how do we handle generic notifications? Is this the correct place to do it? - const notification = { data: { message: `Created` } }; - this.#createSuccessNotification = this.#notificationContext!.peek('positive', notification); } return { data: createdData, error }; @@ -122,11 +108,6 @@ export abstract class UmbDetailRepositoryBase< if (updatedData) { this.#detailStore?.updateItem(model.unique, updatedData); - - // TODO: how do we handle generic notifications? Is this the correct place to do it? - this.#updateSuccessNotification?.close(); - const notification = { data: { message: `Saved` } }; - this.#updateSuccessNotification = this.#notificationContext!.peek('positive', notification); } return { data: updatedData, error }; @@ -146,11 +127,6 @@ export abstract class UmbDetailRepositoryBase< if (!error) { this.#detailStore?.removeItem(unique); - - this.#deleteSuccessNotification?.close(); - // TODO: how do we handle generic notifications? Is this the correct place to do it? - const notification = { data: { message: `Deleted` } }; - this.#deleteSuccessNotification = this.#notificationContext!.peek('positive', notification); } return { error }; diff --git a/tests/Umbraco.Tests.AcceptanceTest/package-lock.json b/tests/Umbraco.Tests.AcceptanceTest/package-lock.json index 548ce33d2276..644ab33631a3 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/package-lock.json +++ b/tests/Umbraco.Tests.AcceptanceTest/package-lock.json @@ -8,7 +8,7 @@ "hasInstallScript": true, "dependencies": { "@umbraco/json-models-builders": "^2.0.31", - "@umbraco/playwright-testhelpers": "^16.0.3", + "@umbraco/playwright-testhelpers": "^16.0.5", "camelize": "^1.0.0", "dotenv": "^16.3.1", "node-fetch": "^2.6.7" @@ -67,10 +67,9 @@ } }, "node_modules/@umbraco/playwright-testhelpers": { - "version": "16.0.3", - "resolved": "https://registry.npmjs.org/@umbraco/playwright-testhelpers/-/playwright-testhelpers-16.0.3.tgz", - "integrity": "sha512-hul0tWdNxzXMx901ZadX8IgAHpMQGAwhrZrfLEoxTIOSwytGoTPsfOSFUNhBhzU6yNXdt0Oi6g4aggmjrJARfg==", - "license": "MIT", + "version": "16.0.5", + "resolved": "https://registry.npmjs.org/@umbraco/playwright-testhelpers/-/playwright-testhelpers-16.0.5.tgz", + "integrity": "sha512-QRZPBCSMqXWp3VnmSsetSdk00Un+Tocd0pa2uOSmBFiOn6+9+6ea5WXWZakMIdVi/Esr44TZs8Zotm3eAgiqfQ==", "dependencies": { "@umbraco/json-models-builders": "2.0.31", "node-fetch": "^2.6.7" diff --git a/tests/Umbraco.Tests.AcceptanceTest/package.json b/tests/Umbraco.Tests.AcceptanceTest/package.json index c3812d6579b3..830fee98b4bc 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/package.json +++ b/tests/Umbraco.Tests.AcceptanceTest/package.json @@ -21,7 +21,7 @@ }, "dependencies": { "@umbraco/json-models-builders": "^2.0.31", - "@umbraco/playwright-testhelpers": "^16.0.3", + "@umbraco/playwright-testhelpers": "^16.0.5", "camelize": "^1.0.0", "dotenv": "^16.3.1", "node-fetch": "^2.6.7" diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/BlockGrid/BlockGridWithPropertyEditor.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/BlockGrid/BlockGridWithPropertyEditor.spec.ts index 84d82d419eb6..ee6be8ea9d3a 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/BlockGrid/BlockGridWithPropertyEditor.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/BlockGrid/BlockGridWithPropertyEditor.spec.ts @@ -54,7 +54,8 @@ test('can not publish a block grid with a mandatory radiobox without a value', a await umbracoUi.content.clickSaveAndPublishButton(); // Assert - await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.content.isErrorNotificationVisible(false); await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.published); }); @@ -83,7 +84,8 @@ test('can not publish a block grid with a mandatory checkbox list without a valu await umbracoUi.content.clickSaveAndPublishButton(); // Assert - await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.content.isErrorNotificationVisible(false); await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.published); }); @@ -112,6 +114,7 @@ test('can not publish a block grid with a mandatory dropdown without a value', a await umbracoUi.content.clickSaveAndPublishButton(); // Assert - await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.content.isErrorNotificationVisible(false); await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.published); }); \ No newline at end of file diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/BlockGrid/ContentWithBlockGrid.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/BlockGrid/ContentWithBlockGrid.spec.ts index 2bec221ba9f2..9b7707009db1 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/BlockGrid/ContentWithBlockGrid.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/BlockGrid/ContentWithBlockGrid.spec.ts @@ -39,7 +39,8 @@ test('can create content with an empty block grid', async ({umbracoApi, umbracoU await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + //await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.variants[0].state).toBe(expectedState); @@ -62,7 +63,8 @@ test('can publish content with an empty block grid', async ({umbracoApi, umbraco await umbracoUi.content.clickSaveAndPublishButton(); // Assert - await umbracoUi.content.doesSuccessNotificationsHaveCount(2); + //await umbracoUi.content.doesSuccessNotificationsHaveCount(2); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.variants[0].state).toBe(expectedState); @@ -87,7 +89,8 @@ test('can add a block element in the content', async ({umbracoApi, umbracoUi}) = await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.values[0].value.contentData[0].values[0].value).toEqual(inputText); @@ -109,7 +112,8 @@ test('can edit block element in the content', async ({umbracoApi, umbracoUi}) => await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.content.isErrorNotificationVisible(false); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.values[0].value.contentData[0].values[0].value).toEqual(updatedText); }); @@ -126,7 +130,8 @@ test('can delete block element in the content', async ({umbracoApi, umbracoUi}) await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.content.isErrorNotificationVisible(false); const contentData = await umbracoApi.document.getByName(contentName); const blockGridValue = contentData.values.find(item => item.value); expect(blockGridValue).toBeFalsy(); @@ -200,7 +205,8 @@ test('can set the label of block element in the content', async ({umbracoApi, um await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.content.isErrorNotificationVisible(false); await umbracoUi.content.doesBlockElementHaveName(blockLabel); }); @@ -221,7 +227,8 @@ test('can set the number of columns for the layout in the content', async ({umbr await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.content.isErrorNotificationVisible(false); const contentData = await umbracoApi.document.getByName(contentName); const layoutValue = contentData.values[0]?.value.layout["Umbraco.BlockGrid"]; expect(layoutValue[0].columnSpan).toBe(gridColumns); @@ -253,7 +260,8 @@ test.skip('can add settings model for the block in the content', async ({umbraco await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.content.isErrorNotificationVisible(false); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.values[0].value.contentData[0].values[0].value).toEqual(contentBlockInputText); expect(contentData.values[0].value.settingsData[0].values[0].value).toEqual(settingBlockInputText); @@ -281,7 +289,8 @@ test('can create content with a block grid with the inline editing mode enabled' await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + //await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); }); @@ -303,7 +312,8 @@ test('can add a block element with inline editing mode enabled', async ({umbraco await umbracoUi.content.clickSaveAndPublishButton(); // Assert - await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.content.isErrorNotificationVisible(false); await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.published); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/BlockGrid/VariantBlockGrid.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/BlockGrid/VariantBlockGrid.spec.ts index 0ad59c90add3..6d02517bb0b2 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/BlockGrid/VariantBlockGrid.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/BlockGrid/VariantBlockGrid.spec.ts @@ -56,7 +56,8 @@ test('invariant document type with invariant block grid with invariant block wit await umbracoUi.content.clickSaveAndPublishButton(); // Assert - await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.content.isErrorNotificationVisible(false); await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.published); await umbracoUi.reloadPage(); @@ -78,7 +79,8 @@ test('can not create unsupported invariant document type with invariant block gr await umbracoUi.content.clickSaveAndPublishButton(); // Assert - await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.content.isErrorNotificationVisible(false); await umbracoUi.content.doesErrorNotificationHaveText(NotificationConstantHelper.error.documentCouldNotBePublished); }); @@ -97,7 +99,8 @@ test('can not create unsupported invariant document type with invariant block gr await umbracoUi.content.clickSaveAndPublishButton(); // Assert - await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.content.isErrorNotificationVisible(false); await umbracoUi.content.doesErrorNotificationHaveText(NotificationConstantHelper.error.documentCouldNotBePublished); }); @@ -120,7 +123,8 @@ test('variant document type with variant block grid with variant block with an v await umbracoUi.content.clickContainerSaveAndPublishButton(); // Assert - await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.content.isErrorNotificationVisible(false); await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.published); await umbracoUi.reloadPage(); @@ -147,7 +151,8 @@ test('variant document type with invariant block grid with variant block with an await umbracoUi.content.clickContainerSaveAndPublishButton(); // Assert - await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.content.isErrorNotificationVisible(false); await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.published); await umbracoUi.reloadPage(); @@ -174,7 +179,8 @@ test('variant document type with invariant block grid with variant block with an await umbracoUi.content.clickContainerSaveAndPublishButton(); // Assert - await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.content.isErrorNotificationVisible(false); await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.published); await umbracoUi.reloadPage(); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/BlockList/BlockListWithPropertyEditor.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/BlockList/BlockListWithPropertyEditor.spec.ts index 5821c00c2d7a..b1aaf7016fbc 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/BlockList/BlockListWithPropertyEditor.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/BlockList/BlockListWithPropertyEditor.spec.ts @@ -54,7 +54,8 @@ test('can not publish a block list with a mandatory radiobox without a value', a await umbracoUi.content.clickSaveAndPublishButton(); // Assert - await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.content.isErrorNotificationVisible(false); await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.published); }); @@ -83,7 +84,8 @@ test('can not publish a block list with a mandatory checkbox list without a valu await umbracoUi.content.clickSaveAndPublishButton(); // Assert - await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.content.isErrorNotificationVisible(false); await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.published); }); @@ -112,6 +114,7 @@ test('can not publish a block list with a mandatory dropdown without a value', a await umbracoUi.content.clickSaveAndPublishButton(); // Assert - await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.content.isErrorNotificationVisible(false); await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.published); }); \ No newline at end of file diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/BlockList/ContentWithBlockList.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/BlockList/ContentWithBlockList.spec.ts index 5d8b87da74cb..e06dbcd72164 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/BlockList/ContentWithBlockList.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/BlockList/ContentWithBlockList.spec.ts @@ -39,7 +39,8 @@ test('can create content with an empty block list', async ({umbracoApi, umbracoU await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + //await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.variants[0].state).toBe(expectedState); @@ -62,7 +63,8 @@ test('can publish content with an empty block list', async ({umbracoApi, umbraco await umbracoUi.content.clickSaveAndPublishButton(); // Assert - await umbracoUi.content.doesSuccessNotificationsHaveCount(2); + //await umbracoUi.content.doesSuccessNotificationsHaveCount(2); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.variants[0].state).toBe(expectedState); @@ -87,7 +89,8 @@ test('can add a block element in the content', async ({umbracoApi, umbracoUi}) = await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.values[0].value.contentData[0].values[0].value).toEqual(inputText); @@ -109,7 +112,8 @@ test('can edit block element in the content', async ({umbracoApi, umbracoUi}) => await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.content.isErrorNotificationVisible(false); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.values[0].value.contentData[0].values[0].value).toEqual(updatedText); }); @@ -126,7 +130,8 @@ test('can delete block element in the content', async ({umbracoApi, umbracoUi}) await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.content.isErrorNotificationVisible(false); const contentData = await umbracoApi.document.getByName(contentName); const blockGridValue = contentData.values.find(item => item.value); expect(blockGridValue).toBeFalsy(); @@ -174,7 +179,8 @@ test('can set the label of block element in the content', async ({umbracoApi, um await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.content.isErrorNotificationVisible(false); await umbracoUi.content.doesBlockElementHaveName(blockLabel); }); @@ -203,7 +209,8 @@ test.skip('can add settings model for the block in the content', async ({umbraco await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.content.isErrorNotificationVisible(false); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.values[0].value.contentData[0].values[0].value).toEqual(contentBlockInputText); expect(contentData.values[0].value.settingsData[0].values[0].value).toEqual(settingBlockInputText); @@ -231,7 +238,8 @@ test('can create content with a block list with the inline editing mode enabled' await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + //await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); }); @@ -253,7 +261,8 @@ test('can add a block element with inline editing mode enabled', async ({umbraco await umbracoUi.content.clickSaveAndPublishButton(); // Assert - await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.content.isErrorNotificationVisible(false); await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.published); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/BlockList/VariantBlockList.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/BlockList/VariantBlockList.spec.ts index 222deef5816b..941414def2db 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/BlockList/VariantBlockList.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/BlockList/VariantBlockList.spec.ts @@ -56,7 +56,8 @@ test('invariant document type with invariant block list with invariant block wit await umbracoUi.content.clickSaveAndPublishButton(); // Assert - await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.content.isErrorNotificationVisible(false); await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.published); await umbracoUi.reloadPage(); @@ -78,7 +79,8 @@ test('can not create unsupported invariant document type with invariant block li await umbracoUi.content.clickSaveAndPublishButton(); // Assert - await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.content.isErrorNotificationVisible(false); await umbracoUi.content.doesErrorNotificationHaveText(NotificationConstantHelper.error.documentCouldNotBePublished); }); @@ -96,7 +98,8 @@ test('can not create unsupported invariant document type with invariant block li await umbracoUi.content.clickSaveAndPublishButton(); // Assert - await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.content.isErrorNotificationVisible(false); await umbracoUi.content.doesErrorNotificationHaveText(NotificationConstantHelper.error.documentCouldNotBePublished); }); @@ -119,7 +122,8 @@ test('variant document type with variant block list with variant block with an v await umbracoUi.content.clickContainerSaveAndPublishButton(); // Assert - await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.content.isErrorNotificationVisible(false); await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.published); await umbracoUi.reloadPage(); @@ -146,7 +150,8 @@ test('variant document type with invariant block list with variant block with an await umbracoUi.content.clickContainerSaveAndPublishButton(); // Assert - await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.content.isErrorNotificationVisible(false); await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.published); await umbracoUi.reloadPage(); @@ -173,7 +178,8 @@ test('variant document type with invariant block list with variant block with an await umbracoUi.content.clickContainerSaveAndPublishButton(); // Assert - await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.content.isErrorNotificationVisible(false); await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.published); await umbracoUi.reloadPage(); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ChildrenContent.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ChildrenContent.spec.ts index 78cc3db04d2d..cefa34bb941c 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ChildrenContent.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ChildrenContent.spec.ts @@ -37,7 +37,8 @@ test('can create child node', {tag: '@smoke'}, async ({umbracoApi, umbracoUi}) = await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(childContentName)).toBeTruthy(); const childData = await umbracoApi.document.getChildren(contentId); expect(childData[0].variants[0].name).toBe(childContentName); @@ -76,7 +77,8 @@ test('can create child node in child node', async ({umbracoApi, umbracoUi}) => { await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); const childOfChildData = await umbracoApi.document.getChildren(childContentId); expect(childOfChildData[0].variants[0].name).toBe(childOfChildContentName); // verify that the child content displays in the tree @@ -103,7 +105,8 @@ test('cannot publish child if the parent is not published', async ({umbracoApi, await umbracoUi.content.clickPublishButton(); // Assert - await umbracoUi.content.isErrorNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); const contentData = await umbracoApi.document.getByName(childContentName); expect(contentData.variants[0].state).toBe('Draft'); }); @@ -123,6 +126,7 @@ test('can publish with descendants', {tag: '@smoke'}, async ({umbracoApi, umbrac // Assert await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.variants[0].state).toBe('Published'); const childContentData = await umbracoApi.document.getByName(contentName); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/Clipboard/ClipboardBlockGridBlocks.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/Clipboard/ClipboardBlockGridBlocks.spec.ts index a151c4573ef6..4b0e91560f39 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/Clipboard/ClipboardBlockGridBlocks.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/Clipboard/ClipboardBlockGridBlocks.spec.ts @@ -71,7 +71,8 @@ test('can copy and paste a single block into the same document and group', async await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); // Original block await umbracoUi.content.goToBlockGridBlockWithName(groupName, blockGridDataTypeName, elementTypeName, 0); await umbracoUi.content.doesBlockEditorBlockWithNameContainValue(elementGroupName, elementPropertyName, ConstantHelper.inputTypes.tipTap, blockPropertyValue); @@ -96,7 +97,8 @@ test('can copy and paste a single block into the same document but different gro await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); // Original block await umbracoUi.content.goToBlockGridBlockWithName(groupName, blockGridDataTypeName, elementTypeName, 0); await umbracoUi.content.doesBlockEditorBlockWithNameContainValue(elementGroupName, elementPropertyName, ConstantHelper.inputTypes.tipTap, blockPropertyValue); @@ -125,7 +127,8 @@ test('can copy and paste a single block into another document', async ({umbracoA await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); // Copied block await umbracoUi.content.goToBlockGridBlockWithName(groupName, blockGridDataTypeName, elementTypeName, 0); await umbracoUi.content.doesBlockEditorBlockWithNameContainValue(elementGroupName, elementPropertyName, ConstantHelper.inputTypes.tipTap, blockPropertyValue); @@ -150,7 +153,8 @@ test('can copy and paste multiple blocks into the same document and group', {tag await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); // Original blocks await umbracoUi.content.goToBlockGridBlockWithName(groupName, blockGridDataTypeName, elementTypeName, 0); await umbracoUi.content.doesBlockEditorBlockWithNameContainValue(elementGroupName, elementPropertyName, ConstantHelper.inputTypes.tipTap, blockPropertyValue); @@ -182,7 +186,8 @@ test('can copy and paste multiple blocks into the same document but different gr await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); // Original blocks await umbracoUi.content.goToBlockGridBlockWithName(groupName, blockGridDataTypeName, elementTypeName, 0); await umbracoUi.content.doesBlockEditorBlockWithNameContainValue(elementGroupName, elementPropertyName, ConstantHelper.inputTypes.tipTap, blockPropertyValue); @@ -218,7 +223,8 @@ test('can copy and paste multiple blocks into another document', async ({umbrac await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); // Copied blocks await umbracoUi.content.goToBlockGridBlockWithName(groupName, blockGridDataTypeName, elementTypeName, 0); await umbracoUi.content.doesBlockEditorBlockWithNameContainValue(elementGroupName, elementPropertyName, ConstantHelper.inputTypes.tipTap, blockPropertyValue); @@ -265,7 +271,8 @@ test('can replace multiple blocks', async ({umbracoApi, umbracoUi}) => { await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); await umbracoUi.content.doesBlockGridPropertyHaveBlockAmount(groupName, blockGridDataTypeName, 1); }); @@ -287,7 +294,8 @@ test('can copy block from a block grid to a block list', async ({umbracoApi, umb await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); // Original blocks // Block Grid await umbracoUi.content.goToBlockGridBlockWithName(groupName, blockGridDataTypeName, elementTypeName, 0); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/Clipboard/ClipboardBlockListBlocks.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/Clipboard/ClipboardBlockListBlocks.spec.ts index 7c0ddda6f8ff..c3ac6c1b059d 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/Clipboard/ClipboardBlockListBlocks.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/Clipboard/ClipboardBlockListBlocks.spec.ts @@ -71,7 +71,8 @@ test('can copy and paste a single block into the same document and group', async await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); // Original block await umbracoUi.content.goToBlockListBlockWithName(groupName, blockListDataTypeName, elementTypeName, 0); await umbracoUi.content.doesBlockEditorBlockWithNameContainValue(elementGroupName, elementPropertyName, ConstantHelper.inputTypes.tipTap, blockPropertyValue); @@ -96,7 +97,8 @@ test('can copy and paste a single block into the same document but different gro await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); // Original block await umbracoUi.content.goToBlockListBlockWithName(groupName, blockListDataTypeName, elementTypeName, 0); await umbracoUi.content.doesBlockEditorBlockWithNameContainValue(elementGroupName, elementPropertyName, ConstantHelper.inputTypes.tipTap, blockPropertyValue); @@ -125,7 +127,8 @@ test('can copy and paste a single block into another document', async ({umbracoA await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); // Copied block await umbracoUi.content.goToBlockListBlockWithName(groupName, blockListDataTypeName, elementTypeName, 0); await umbracoUi.content.doesBlockEditorBlockWithNameContainValue(elementGroupName, elementPropertyName, ConstantHelper.inputTypes.tipTap, blockPropertyValue); @@ -150,7 +153,8 @@ test('can copy and paste multiple blocks into the same document and group', {tag await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); // Original blocks await umbracoUi.content.goToBlockListBlockWithName(groupName, blockListDataTypeName, elementTypeName, 0); await umbracoUi.content.doesBlockEditorBlockWithNameContainValue(elementGroupName, elementPropertyName, ConstantHelper.inputTypes.tipTap, blockPropertyValue); @@ -182,7 +186,8 @@ test('can copy and paste multiple blocks into the same document but different gr await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); // Original blocks await umbracoUi.content.goToBlockListBlockWithName(groupName, blockListDataTypeName, elementTypeName, 0); await umbracoUi.content.doesBlockEditorBlockWithNameContainValue(elementGroupName, elementPropertyName, ConstantHelper.inputTypes.tipTap, blockPropertyValue); @@ -218,7 +223,8 @@ test('can copy and paste multiple blocks into another document', async ({umbraco await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); // Copied blocks await umbracoUi.content.goToBlockListBlockWithName(groupName, blockListDataTypeName, elementTypeName, 0); await umbracoUi.content.doesBlockEditorBlockWithNameContainValue(elementGroupName, elementPropertyName, ConstantHelper.inputTypes.tipTap, blockPropertyValue); @@ -265,7 +271,8 @@ test('can replace multiple blocks', async ({umbracoApi, umbracoUi}) => { await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); await umbracoUi.content.doesBlockListPropertyHaveBlockAmount(groupName, blockListDataTypeName, 1); }); @@ -287,7 +294,8 @@ test('can copy block from a block list to a block grid', async ({umbracoApi, um await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); // Original blocks // Block List await umbracoUi.content.goToBlockListBlockWithName(groupName, blockListDataTypeName, elementTypeName, 0); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/Content.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/Content.spec.ts index 07f16cab9fb6..ebf1951219af 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/Content.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/Content.spec.ts @@ -32,7 +32,8 @@ test('can create empty content', async ({umbracoApi, umbracoUi}) => { await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + //await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.variants[0].state).toBe(expectedState); @@ -53,8 +54,8 @@ test('can save and publish empty content', {tag: '@smoke'}, async ({umbracoApi, await umbracoUi.content.clickSaveAndPublishButton(); // Assert - await umbracoUi.content.doesSuccessNotificationsHaveCount(2); - await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + //await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + await umbracoUi.content.isErrorNotificationVisible(false); await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.published); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); @@ -77,7 +78,8 @@ test('can create content', {tag: '@smoke'}, async ({umbracoApi, umbracoUi}) => { await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + //await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.values[0].value).toBe(contentText); @@ -98,7 +100,8 @@ test('can rename content', async ({umbracoApi, umbracoUi}) => { await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.content.isErrorNotificationVisible(false); const updatedContentData = await umbracoApi.document.get(contentId); expect(updatedContentData.variants[0].name).toEqual(contentName); }); @@ -118,7 +121,8 @@ test('can update content', {tag: '@smoke'}, async ({umbracoApi, umbracoUi}) => { await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.content.isErrorNotificationVisible(false); const updatedContentData = await umbracoApi.document.get(contentId); expect(updatedContentData.variants[0].name).toEqual(contentName); expect(updatedContentData.values[0].value).toBe(contentText); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentInfoTab.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentInfoTab.spec.ts index 24e84cb79e13..3644a801db69 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentInfoTab.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentInfoTab.spec.ts @@ -33,7 +33,8 @@ test('can see correct information when published', async ({umbracoApi, umbracoUi await umbracoUi.content.clickSaveAndPublishButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); const contentData = await umbracoApi.document.getByName(contentName); await umbracoUi.content.doesIdHaveText(contentData.id); const expectedCreatedDate = new Date(contentData.variants[0].createDate).toLocaleString("en-US", { @@ -106,7 +107,8 @@ test('can change template', async ({umbracoApi, umbracoUi}) => { await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.template.id).toBe(secondTemplateId); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithApprovedColor.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithApprovedColor.spec.ts index cfe7aaeb154f..9a785f6549d9 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithApprovedColor.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithApprovedColor.spec.ts @@ -31,7 +31,8 @@ test('can create content with the approved color data type', async ({umbracoApi, await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.variants[0].state).toBe(expectedState); @@ -51,7 +52,8 @@ test('can publish content with the approved color data type', async ({umbracoApi await umbracoUi.content.clickSaveAndPublishButton(); // Assert - await umbracoUi.content.doesSuccessNotificationsHaveCount(2); + //await umbracoUi.content.doesSuccessNotificationsHaveCount(2); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.variants[0].state).toBe(expectedState); @@ -74,7 +76,8 @@ test('can create content with the custom approved color data type', async ({umbr await umbracoUi.content.clickSaveAndPublishButton(); // Assert - await umbracoUi.content.doesSuccessNotificationsHaveCount(2); + //await umbracoUi.content.doesSuccessNotificationsHaveCount(2); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.values[0].alias).toEqual(AliasHelper.toAlias(customDataTypeName)); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithCheckboxList.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithCheckboxList.spec.ts index b4760a8c776f..99a919cfe2ee 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithCheckboxList.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithCheckboxList.spec.ts @@ -34,7 +34,8 @@ test('can create content with the checkbox list data type', async ({umbracoApi, await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + //await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.variants[0].state).toBe(expectedState); @@ -54,7 +55,8 @@ test('can publish content with the checkbox list data type', async ({umbracoApi, await umbracoUi.content.clickSaveAndPublishButton(); // Assert - await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.content.isErrorNotificationVisible(false); await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.published); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.variants[0].state).toBe(expectedState); @@ -75,7 +77,8 @@ test('can create content with the custom checkbox list data type', async ({umbra await umbracoUi.content.clickSaveAndPublishButton(); // Assert - await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.content.isErrorNotificationVisible(false); await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.published); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.values[0].alias).toEqual(AliasHelper.toAlias(customDataTypeName)); @@ -96,7 +99,8 @@ test('can not publish a mandatory checkbox list with an empty value', async ({um // Do not select any checkbox list values and the validation error appears await umbracoUi.content.clickSaveAndPublishButton(); await umbracoUi.content.isValidationMessageVisible(ConstantHelper.validationMessages.emptyValue); - await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.content.isErrorNotificationVisible(false); await umbracoUi.content.doesErrorNotificationHaveText(NotificationConstantHelper.error.documentCouldNotBePublished); // Select a checkbox list value and the validation error disappears await umbracoUi.content.chooseCheckboxListOption(optionValues[0]); @@ -104,7 +108,8 @@ test('can not publish a mandatory checkbox list with an empty value', async ({um await umbracoUi.content.clickSaveAndPublishButton(); // Assert - await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.content.isErrorNotificationVisible(false); await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.published); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.values[0].alias).toEqual(AliasHelper.toAlias(customDataTypeName)); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithContentPicker.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithContentPicker.spec.ts index 210c72270731..2fe3f6cec61d 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithContentPicker.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithContentPicker.spec.ts @@ -39,7 +39,8 @@ test('can create content with the content picker datatype', {tag: '@smoke'}, asy await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.variants[0].state).toBe(expectedState); @@ -62,7 +63,8 @@ test('can publish content with the content picker data type', async ({umbracoApi await umbracoUi.content.clickSaveAndPublishButton(); // Assert - await umbracoUi.content.doesSuccessNotificationsHaveCount(2); + //await umbracoUi.content.doesSuccessNotificationsHaveCount(2); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.variants[0].state).toBe(expectedState); @@ -169,7 +171,8 @@ test('can remove content picker in the content', async ({umbracoApi, umbracoUi}) await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.values).toEqual([]); }); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithCustomDataType.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithCustomDataType.spec.ts index d605cb1936c8..2a6ed55a135e 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithCustomDataType.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithCustomDataType.spec.ts @@ -32,7 +32,8 @@ test('can create content with the custom data type with email address property e await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.values).toEqual([]); @@ -54,7 +55,8 @@ test('can add text to the email address in the content section', async ({umbraco await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.values[0].alias).toEqual(AliasHelper.toAlias(customDataTypeName)); @@ -77,7 +79,8 @@ test('can create content with the custom data type with decimal property editor' await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.values).toEqual([]); @@ -99,7 +102,8 @@ test('can add decimal number to the decimal in the content section', async ({umb await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.values[0].alias).toEqual(AliasHelper.toAlias(customDataTypeName)); @@ -123,7 +127,8 @@ test.skip('can create content with the custom data type with code editor propert await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.values).toEqual([]); @@ -145,7 +150,8 @@ test('can add javascript code to the code editor in the content section', async await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.values[0].alias).toEqual(AliasHelper.toAlias(customDataTypeName)); @@ -168,7 +174,8 @@ test('can create content with the custom data type with markdown editor property await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.values).toEqual([]); @@ -190,7 +197,8 @@ test('can add code to the markdown editor in the content section', async ({umbra await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.values[0].alias).toEqual(AliasHelper.toAlias(customDataTypeName)); @@ -213,7 +221,8 @@ test('can create content with the custom data type with multiple text string pro await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.values).toEqual([]); @@ -235,7 +244,8 @@ test('can add string to the multiple text string in the content section', async await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.values[0].alias).toEqual(AliasHelper.toAlias(customDataTypeName)); @@ -259,7 +269,8 @@ test('can create content with the custom data type with slider property editor', await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.values).toEqual([]); @@ -285,7 +296,8 @@ test('can change slider value in the content section', async ({umbracoApi, umbra await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.values[0].alias).toEqual(AliasHelper.toAlias(customDataTypeName)); @@ -313,5 +325,6 @@ test('can save content after changing the property editor of the custom data typ await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); }); \ No newline at end of file diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithDocumentTypeProperties/ContentWithAllowVaryByCulture.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithDocumentTypeProperties/ContentWithAllowVaryByCulture.spec.ts index cded85b7907c..cd90e4500cb7 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithDocumentTypeProperties/ContentWithAllowVaryByCulture.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithDocumentTypeProperties/ContentWithAllowVaryByCulture.spec.ts @@ -33,7 +33,8 @@ test('can create content with allow vary by culture enabled', async ({umbracoApi await umbracoUi.content.clickSaveAndCloseButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); }); @@ -54,7 +55,8 @@ test('can create content with names that vary by culture', async ({umbracoApi, u await umbracoUi.content.clickSaveAndCloseButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(danishContentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(danishContentName); expect(contentData.variants.length).toBe(2); @@ -84,7 +86,8 @@ test('can create content with names that vary by culture and content that is inv await umbracoUi.content.clickSaveAndCloseButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(danishContentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(danishContentName); expect(contentData.variants.length).toBe(2); @@ -116,7 +119,8 @@ test('can create content with names and content that vary by culture', async ({u await umbracoUi.content.clickSaveAndCloseButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(danishContentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(danishContentName); expect(contentData.variants.length).toBe(2); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithDocumentTypeProperties/ContentWithAllowedChildNodes.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithDocumentTypeProperties/ContentWithAllowedChildNodes.spec.ts index d567a0984f5e..bce562e334e4 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithDocumentTypeProperties/ContentWithAllowedChildNodes.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithDocumentTypeProperties/ContentWithAllowedChildNodes.spec.ts @@ -31,7 +31,8 @@ test('can create content with allowed child node enabled', async ({umbracoApi, u await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); // Clean @@ -75,7 +76,8 @@ test('can create multiple child nodes with different document types', async ({um await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(secondChildContentName)).toBeTruthy(); const childData = await umbracoApi.document.getChildren(contentId); expect(childData.length).toBe(2); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithDocumentTypeProperties/ContentWithAllowedTemplates.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithDocumentTypeProperties/ContentWithAllowedTemplates.spec.ts index d31b884ea146..73abbe9caff3 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithDocumentTypeProperties/ContentWithAllowedTemplates.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithDocumentTypeProperties/ContentWithAllowedTemplates.spec.ts @@ -33,7 +33,8 @@ test('can create content with an allowed template', async ({umbracoApi, umbracoU await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.template.id).toBe(templateId); @@ -56,7 +57,8 @@ test('can create content with multiple allowed templates', async ({umbracoApi, u await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.template.id).toBe(defaultTemplateId); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithDocumentTypeProperties/ContentWithCollections.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithDocumentTypeProperties/ContentWithCollections.spec.ts index 98868fc1c17b..c0eec3f87693 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithDocumentTypeProperties/ContentWithCollections.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithDocumentTypeProperties/ContentWithCollections.spec.ts @@ -34,7 +34,8 @@ test('can create content configured as a collection', async ({umbracoApi, umbrac await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); await umbracoUi.content.isTabNameVisible('Collection'); await umbracoUi.content.doesContentListHaveNoItemsInList(); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithDropdown.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithDropdown.spec.ts index 98743009d4ec..82861736244c 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithDropdown.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithDropdown.spec.ts @@ -35,7 +35,8 @@ for (const dataTypeName of dataTypeNames) { await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + //await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.variants[0].state).toBe(expectedState); @@ -55,7 +56,8 @@ for (const dataTypeName of dataTypeNames) { await umbracoUi.content.clickSaveAndPublishButton(); // Assert - await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.content.isErrorNotificationVisible(false); await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.published); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.variants[0].state).toBe(expectedState); @@ -78,7 +80,8 @@ for (const dataTypeName of dataTypeNames) { await umbracoUi.content.clickSaveAndPublishButton(); // Assert - await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.content.isErrorNotificationVisible(false); await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.published); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.values[0].alias).toEqual(AliasHelper.toAlias(customDataTypeName)); @@ -100,7 +103,8 @@ test('can not publish a mandatory dropdown with an empty value', async ({umbraco // Do not select any dropdown values and the validation error appears await umbracoUi.content.clickSaveAndPublishButton(); await umbracoUi.content.isValidationMessageVisible(ConstantHelper.validationMessages.emptyValue); - await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.content.isErrorNotificationVisible(false); await umbracoUi.content.doesErrorNotificationHaveText(NotificationConstantHelper.error.documentCouldNotBePublished); // Select a dropdown value and the validation error disappears await umbracoUi.content.chooseDropdownOption([optionValues[0]]); @@ -108,7 +112,8 @@ test('can not publish a mandatory dropdown with an empty value', async ({umbraco await umbracoUi.content.clickSaveAndPublishButton(); // Assert - await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.content.isErrorNotificationVisible(false); await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.published); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.values[0].alias).toEqual(AliasHelper.toAlias(customDataTypeName)); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithImageCropper.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithImageCropper.spec.ts index 4d042ecb3358..7d6968759580 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithImageCropper.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithImageCropper.spec.ts @@ -38,7 +38,8 @@ test('can create content with the image cropper data type', {tag: '@smoke'}, asy await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.variants[0].state).toBe(expectedState); @@ -62,7 +63,8 @@ test('can publish content with the image cropper data type', {tag: '@smoke'}, as await umbracoUi.content.clickSaveAndPublishButton(); // Assert - await umbracoUi.content.doesSuccessNotificationsHaveCount(2); + //await umbracoUi.content.doesSuccessNotificationsHaveCount(2); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.variants[0].state).toBe(expectedState); @@ -89,7 +91,8 @@ test('can create content with the custom image cropper data type', {tag: '@smoke await umbracoUi.content.clickSaveAndPublishButton(); // Assert - await umbracoUi.content.doesSuccessNotificationsHaveCount(2); + //await umbracoUi.content.doesSuccessNotificationsHaveCount(2); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.values[0].alias).toEqual(AliasHelper.toAlias(customDataTypeName)); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithImageMediaPicker.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithImageMediaPicker.spec.ts index 9e4bb5bb4a86..aa003decf98f 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithImageMediaPicker.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithImageMediaPicker.spec.ts @@ -34,7 +34,8 @@ test('can save content with a image media picker', async ({umbracoApi, umbracoUi await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.variants[0].state).toBe(expectedState); @@ -54,7 +55,8 @@ test('can publish content with a image media picker', async ({umbracoApi, umbrac await umbracoUi.content.clickSaveAndPublishButton(); // Assert - await umbracoUi.content.doesSuccessNotificationsHaveCount(2); + //await umbracoUi.content.doesSuccessNotificationsHaveCount(2); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.variants[0].state).toBe(expectedState); @@ -77,7 +79,8 @@ test('can add an image to the image media picker', async ({umbracoApi, umbracoUi await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesImageMediaPickerContainImage(contentName, AliasHelper.toAlias(dataTypeName), imageId)).toBeTruthy(); // Clean @@ -101,7 +104,8 @@ test('can remove an image from the image media picker', async ({umbracoApi, umbr await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesImageMediaPickerContainImage(contentName, AliasHelper.toAlias(dataTypeName), imageId)).toBeFalsy(); // Clean @@ -172,7 +176,8 @@ test('can add an image from the image media picker with a start node', async ({u await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesImageMediaPickerContainImage(contentName, AliasHelper.toAlias(customDataTypeName), imageId)).toBeTruthy(); // Clean @@ -202,7 +207,8 @@ test('can add an image from the image media picker with focal point enabled', as await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesImageMediaPickerContainImageWithFocalPoint(contentName, AliasHelper.toAlias(customDataTypeName), imageId, {left: 0.4, top: 0.2})).toBeTruthy(); // Clean @@ -229,7 +235,8 @@ test('can reset focal point in a image from the image media picker', async ({umb await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesImageMediaPickerContainImageWithFocalPoint(contentName, AliasHelper.toAlias(customDataTypeName), imageId, {left: 0, top: 0})).toBeTruthy(); // Clean diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithListViewContent.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithListViewContent.spec.ts index b86bc575b2b3..6e678eae8072 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithListViewContent.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithListViewContent.spec.ts @@ -40,7 +40,7 @@ test.fixme('can create content with the list view data type', async ({umbracoApi await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); @@ -63,7 +63,8 @@ test('can publish content with the list view data type', async ({umbracoApi, umb await umbracoUi.content.clickSaveAndPublishButton(); // Assert - await umbracoUi.content.doesSuccessNotificationsHaveCount(2); + //await umbracoUi.content.doesSuccessNotificationsHaveCount(2); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.variants[0].state).toBe(expectedState); @@ -86,7 +87,8 @@ test('can create content with a child in the list', async ({umbracoApi, umbracoU await umbracoUi.content.clickSaveModalButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); expect(await umbracoApi.document.getChildrenAmount(documentId)).toEqual(1); }); @@ -107,12 +109,14 @@ test('can publish content with a child in the list', async ({umbracoApi, umbraco // Currently necessary await umbracoUi.waitForTimeout(500); await umbracoUi.content.clickSaveAndPublishButton(); - await umbracoUi.content.doesSuccessNotificationsHaveCount(2); + //await umbracoUi.content.doesSuccessNotificationsHaveCount(2); + await umbracoUi.content.isErrorNotificationVisible(false); await umbracoUi.content.goToContentInListViewWithName(childContentName); await umbracoUi.content.clickContainerSaveAndPublishButton(); // Assert - await umbracoUi.content.doesSuccessNotificationsHaveCount(2); + //await umbracoUi.content.doesSuccessNotificationsHaveCount(2); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.variants[0].state).toBe(expectedState); @@ -215,7 +219,8 @@ test('can publish child content from list', async ({umbracoApi, umbracoUi}) => { await umbracoUi.content.clickPublishSelectedListItems(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.getChildrenAmount(documentId)).toEqual(1); const childContentData = await umbracoApi.document.getByName(childContentName); expect(childContentData.variants[0].state).toBe(expectedState); @@ -265,7 +270,8 @@ test('can unpublish child content from list', async ({umbracoApi, umbracoUi}) => await umbracoUi.content.clickConfirmToUnpublishButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); const childContentData = await umbracoApi.document.getByName(childContentName); expect(childContentData.variants[0].state).toBe(expectedState); }); @@ -290,7 +296,8 @@ test('can duplicate child content in list', async ({umbracoApi, umbracoUi}) => { await umbracoUi.content.selectDocumentWithNameAtRoot(secondDocumentName); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); await umbracoUi.content.doesFirstItemInListViewHaveName(childContentName); await umbracoUi.content.goToContentWithName(secondDocumentName); await umbracoUi.content.doesFirstItemInListViewHaveName(childContentName); @@ -320,7 +327,8 @@ test('can move child content in list', async ({umbracoApi, umbracoUi}) => { await umbracoUi.content.selectDocumentWithNameAtRoot(secondDocumentName); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); await umbracoUi.content.doesListViewContainCount(0); await umbracoUi.content.goToContentWithName(secondDocumentName); await umbracoUi.content.doesFirstItemInListViewHaveName(childContentName); @@ -347,7 +355,8 @@ test('can trash child content in list', async ({umbracoApi, umbracoUi}) => { await umbracoUi.content.clickConfirmTrashButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); await umbracoUi.content.doesListViewContainCount(0); expect(await umbracoApi.document.getChildrenAmount(documentId)).toEqual(0); await umbracoUi.content.isItemVisibleInRecycleBin(childContentName); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithMediaPicker.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithMediaPicker.spec.ts index 939b94c2f00d..9668649b5ff5 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithMediaPicker.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithMediaPicker.spec.ts @@ -39,7 +39,8 @@ test('can create content with the media picker data type', {tag: '@smoke'}, asyn await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + //await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.variants[0].state).toBe(expectedState); @@ -68,7 +69,8 @@ test('can publish content with the media picker data type', async ({umbracoApi, await umbracoUi.content.clickSaveAndPublishButton(); // Assert - await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.content.isErrorNotificationVisible(false); await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.published); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); @@ -94,7 +96,8 @@ test('can remove a media picker in the content', async ({umbracoApi, umbracoUi}) await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.values).toEqual([]); @@ -142,7 +145,8 @@ test('can not publish a mandatory media picker with an empty value', async ({umb // Do not pick any media and the validation error appears await umbracoUi.content.clickSaveAndPublishButton(); await umbracoUi.content.isValidationMessageVisible(ConstantHelper.validationMessages.emptyValue); - await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.content.isErrorNotificationVisible(false); await umbracoUi.content.doesErrorNotificationHaveText(NotificationConstantHelper.error.documentCouldNotBePublished); // Pick a media value and the validation error disappears await umbracoUi.content.clickChooseButtonAndSelectMediaWithName(mediaFileName); @@ -151,7 +155,8 @@ test('can not publish a mandatory media picker with an empty value', async ({umb await umbracoUi.content.clickSaveAndPublishButton(); // Assert - await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.content.isErrorNotificationVisible(false); await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.published); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.values[0].alias).toEqual(AliasHelper.toAlias(dataTypeName)); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithMemberPicker.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithMemberPicker.spec.ts index 62eec89659e4..5718d526aa52 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithMemberPicker.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithMemberPicker.spec.ts @@ -44,7 +44,8 @@ test('can create content with the member picker data type', {tag: '@smoke'}, asy await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.variants[0].state).toBe(expectedState); @@ -68,7 +69,8 @@ test('can publish content with the member picker data type', async ({umbracoApi, await umbracoUi.content.clickSaveAndPublishButton(); // Assert - await umbracoUi.content.doesSuccessNotificationsHaveCount(2); + //await umbracoUi.content.doesSuccessNotificationsHaveCount(2); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.variants[0].state).toBe(expectedState); @@ -89,7 +91,8 @@ test('can remove a member picker in the content', async ({umbracoApi, umbracoUi} await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.values).toEqual([]); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithMultiURLPicker.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithMultiURLPicker.spec.ts index 37ac3b8f32e9..b8c53efdacb7 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithMultiURLPicker.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithMultiURLPicker.spec.ts @@ -44,7 +44,8 @@ test('can create content with the document link', {tag: '@smoke'}, async ({umbra await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.variants[0].state).toBe(expectedState); @@ -86,7 +87,8 @@ test('can publish content with the document link', async ({umbracoApi, umbracoUi await umbracoUi.content.clickSaveAndPublishButton(); // Assert - await umbracoUi.content.doesSuccessNotificationsHaveCount(2); + //await umbracoUi.content.doesSuccessNotificationsHaveCount(2); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.variants[0].state).toBe(expectedState); @@ -121,7 +123,8 @@ test('can create content with the external link', async ({umbracoApi, umbracoUi} await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.values[0].alias).toEqual(AliasHelper.toAlias(dataTypeName)); @@ -154,7 +157,8 @@ test('can create content with the media link', async ({umbracoApi, umbracoUi}) = await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.values[0].alias).toEqual(AliasHelper.toAlias(dataTypeName)); @@ -197,7 +201,8 @@ test('can add multiple links in the content', async ({umbracoApi, umbracoUi}) => await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.values[0].alias).toEqual(AliasHelper.toAlias(dataTypeName)); @@ -231,7 +236,8 @@ test('can remove the URL picker in the content', async ({umbracoApi, umbracoUi}) await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.values).toEqual([]); @@ -254,7 +260,8 @@ test('can edit the URL picker in the content', async ({umbracoApi, umbracoUi}) = await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.values[0].alias).toEqual(AliasHelper.toAlias(dataTypeName)); @@ -379,7 +386,8 @@ test.skip('can create content with the link to an unpublished document', async ( await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.variants[0].state).toBe(expectedState); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithMultipleImageMediaPicker.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithMultipleImageMediaPicker.spec.ts index 42052223c9fc..f5644dd56055 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithMultipleImageMediaPicker.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithMultipleImageMediaPicker.spec.ts @@ -42,7 +42,8 @@ test('can create content with multiple image media picker data type', async ({um await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.variants[0].state).toBe(expectedState); @@ -62,7 +63,8 @@ test('can publish content with multiple image media picker data type', async ({u await umbracoUi.content.clickSaveAndPublishButton(); // Assert - await umbracoUi.content.doesSuccessNotificationsHaveCount(2); + //await umbracoUi.content.doesSuccessNotificationsHaveCount(2); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.variants[0].state).toBe(expectedState); @@ -85,7 +87,8 @@ test('can add multiple images to the multiple image media picker', async ({umbra await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.values[0].alias).toEqual(AliasHelper.toAlias(dataTypeName)); @@ -109,7 +112,8 @@ test('can remove a media picker in the content', async ({umbracoApi, umbracoUi}) await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.values[0].alias).toEqual(AliasHelper.toAlias(dataTypeName)); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithMultipleMediaPicker.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithMultipleMediaPicker.spec.ts index 919c1a1ca5c3..ab669937bcb6 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithMultipleMediaPicker.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithMultipleMediaPicker.spec.ts @@ -43,7 +43,8 @@ test('can create content with multiple media picker data type', async ({umbracoA await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.variants[0].state).toBe(expectedState); @@ -63,7 +64,8 @@ test('can publish content with multiple media picker data type', async ({umbraco await umbracoUi.content.clickSaveAndPublishButton(); // Assert - await umbracoUi.content.doesSuccessNotificationsHaveCount(2); + //await umbracoUi.content.doesSuccessNotificationsHaveCount(2); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.variants[0].state).toBe(expectedState); @@ -86,7 +88,8 @@ test('can add multiple media files to the multiple media picker', async ({umbrac await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.values[0].alias).toEqual(AliasHelper.toAlias(dataTypeName)); @@ -110,7 +113,8 @@ test('can remove a media picker in the content', async ({umbracoApi, umbracoUi}) await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.values[0].alias).toEqual(AliasHelper.toAlias(dataTypeName)); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithNumeric.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithNumeric.spec.ts index 946c16b3128e..25f9abd5b51f 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithNumeric.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithNumeric.spec.ts @@ -33,7 +33,8 @@ test('can create content with the numeric data type', async ({umbracoApi, umbrac await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.variants[0].state).toBe(expectedState); @@ -55,7 +56,8 @@ test('can publish content with the numeric data type', async ({umbracoApi, umbra await umbracoUi.content.clickSaveAndPublishButton(); // Assert - await umbracoUi.content.doesSuccessNotificationsHaveCount(2); + //await umbracoUi.content.doesSuccessNotificationsHaveCount(2); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.variants[0].state).toBe(expectedState); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithPropertyEditors.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithPropertyEditors.spec.ts index 9717568ca9bc..c771c0bb64fd 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithPropertyEditors.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithPropertyEditors.spec.ts @@ -33,7 +33,8 @@ test.skip('can create content with the Rich Text Editor datatype', {tag: '@smoke await umbracoUi.content.clickSaveAndPublishButton(); // Assert - await umbracoUi.content.doesSuccessNotificationsHaveCount(2); + //await umbracoUi.content.doesSuccessNotificationsHaveCount(2); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.values[0].value.markup).toEqual('

' + contentText + '

'); @@ -58,7 +59,8 @@ test.skip('can create content with the upload file datatype', async ({umbracoApi await umbracoUi.content.clickSaveAndPublishButton(); // Assert - await umbracoUi.content.doesSuccessNotificationsHaveCount(2); + //await umbracoUi.content.doesSuccessNotificationsHaveCount(2); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.values[0].value.src).toContainEqual(uploadFilePath); @@ -84,7 +86,8 @@ test.skip('can create content with the list view - content datatype', async ({um await umbracoUi.content.clickSaveAndPublishButton(); // Assert - await umbracoUi.content.doesSuccessNotificationsHaveCount(2); + //await umbracoUi.content.doesSuccessNotificationsHaveCount(2); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); // Clean diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithRadiobox.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithRadiobox.spec.ts index 19dba0f78f37..6aafa7b7e0f1 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithRadiobox.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithRadiobox.spec.ts @@ -35,7 +35,8 @@ test('can create content with the radiobox data type', async ({umbracoApi, umbra await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + //await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.variants[0].state).toBe(expectedState); @@ -56,7 +57,8 @@ test('can publish content with the radiobox data type', async ({umbracoApi, umbr await umbracoUi.content.clickSaveAndPublishButton(); // Assert - await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.content.isErrorNotificationVisible(false); await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.published); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); @@ -78,7 +80,8 @@ test('can create content with the custom radiobox data type', async ({umbracoApi await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.values[0].alias).toEqual(AliasHelper.toAlias(customDataTypeName)); @@ -98,7 +101,8 @@ test('can not publish mandatory radiobox with an empty value', async ({umbracoAp // Do not select any radiobox values and the validation error appears await umbracoUi.content.clickSaveAndPublishButton(); await umbracoUi.content.isValidationMessageVisible(ConstantHelper.validationMessages.emptyValue); - await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.content.isErrorNotificationVisible(false); await umbracoUi.content.doesErrorNotificationHaveText(NotificationConstantHelper.error.documentCouldNotBePublished); // Select a radiobox value and the validation error disappears await umbracoUi.content.chooseRadioboxOption(optionValues[0]); @@ -106,7 +110,8 @@ test('can not publish mandatory radiobox with an empty value', async ({umbracoAp await umbracoUi.content.clickSaveAndPublishButton(); // Assert - await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.content.isErrorNotificationVisible(false); await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.published); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.values[0].alias).toEqual(AliasHelper.toAlias(customDataTypeName)); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithTags.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithTags.spec.ts index 551830489fe3..fc72f4f236bf 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithTags.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithTags.spec.ts @@ -34,7 +34,8 @@ test('can create content with one tag', async ({umbracoApi, umbracoUi}) => { await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.variants[0].state).toBe(expectedState); @@ -57,7 +58,8 @@ test('can publish content with multiple tags', async ({umbracoApi, umbracoUi}) = await umbracoUi.content.clickSaveAndPublishButton(); // Assert - await umbracoUi.content.doesSuccessNotificationsHaveCount(2); + //await umbracoUi.content.doesSuccessNotificationsHaveCount(2); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.variants[0].state).toBe(expectedState); @@ -77,7 +79,8 @@ test('can remove a tag in the content', async ({umbracoApi, umbracoUi}) => { await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.values).toEqual([]); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithTextarea.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithTextarea.spec.ts index 54fc3c5f11d0..87cbe2ac82f1 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithTextarea.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithTextarea.spec.ts @@ -33,7 +33,8 @@ test('can create content with the textarea data type', async ({umbracoApi, umbra await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.variants[0].state).toBe(expectedState); @@ -53,7 +54,8 @@ test('can publish content with the textarea data type', async ({umbracoApi, umbr await umbracoUi.content.clickSaveAndPublishButton(); // Assert - await umbracoUi.content.doesSuccessNotificationsHaveCount(2); + //await umbracoUi.content.doesSuccessNotificationsHaveCount(2); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.variants[0].state).toBe(expectedState); @@ -73,7 +75,8 @@ test('can input text into the textarea', async ({umbracoApi, umbracoUi}) => { await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.values[0].alias).toEqual(AliasHelper.toAlias(dataTypeName)); @@ -97,7 +100,8 @@ test('cannot input the text that exceeds the allowed amount of characters', asyn // Assert await umbracoUi.content.isTextWithExactNameVisible(warningMessage); - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); // Clean await umbracoApi.dataType.ensureNameNotExists(customDataTypeName); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithTextstring.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithTextstring.spec.ts index f834ae35de4c..d55ca0128592 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithTextstring.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithTextstring.spec.ts @@ -33,7 +33,8 @@ test('can create content with the textstring data type', async ({umbracoApi, umb await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.variants[0].state).toBe(expectedState); @@ -53,7 +54,8 @@ test('can publish content with the textstring data type', async ({umbracoApi, um await umbracoUi.content.clickSaveAndPublishButton(); // Assert - await umbracoUi.content.doesSuccessNotificationsHaveCount(2); + //await umbracoUi.content.doesSuccessNotificationsHaveCount(2); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.variants[0].state).toBe(expectedState); @@ -73,7 +75,8 @@ test('can input text into the textstring', async ({umbracoApi, umbracoUi}) => { await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.values[0].alias).toEqual(AliasHelper.toAlias(dataTypeName)); @@ -97,7 +100,8 @@ test('cannot input the text that exceeds the allowed amount of characters', asyn // Assert await umbracoUi.content.isTextWithExactNameVisible(warningMessage); - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); // Clean await umbracoApi.dataType.ensureNameNotExists(customDataTypeName); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithTrueFalse.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithTrueFalse.spec.ts index e015ea61151d..504dfea7837e 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithTrueFalse.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithTrueFalse.spec.ts @@ -32,7 +32,8 @@ test('can create content with the true/false data type', async ({umbracoApi, umb await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.variants[0].state).toBe(expectedState); @@ -53,7 +54,8 @@ test('can publish content with the true/false data type', async ({umbracoApi, um await umbracoUi.content.clickSaveAndPublishButton(); // Assert - await umbracoUi.content.doesSuccessNotificationsHaveCount(2); + //await umbracoUi.content.doesSuccessNotificationsHaveCount(2); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.variants[0].state).toBe(expectedState); @@ -74,7 +76,8 @@ test('can toggle the true/false value in the content ', async ({umbracoApi, umbr await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.values[0].alias).toEqual('truefalse'); @@ -97,7 +100,8 @@ test('can toggle the true/false value with the initial state enabled', async ({u await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.values[0].alias).toEqual(AliasHelper.toAlias(customDataTypeName)); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithUploadArticle.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithUploadArticle.spec.ts index 33c25bcd5332..05731bfde176 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithUploadArticle.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithUploadArticle.spec.ts @@ -32,7 +32,8 @@ test('can create content with the upload article data type', async ({umbracoApi, await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.variants[0].state).toBe(expectedState); @@ -53,7 +54,8 @@ test('can publish content with the upload article data type', async ({umbracoApi await umbracoUi.content.clickSaveAndPublishButton(); // Assert - await umbracoUi.content.doesSuccessNotificationsHaveCount(2); + //await umbracoUi.content.doesSuccessNotificationsHaveCount(2); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.variants[0].state).toBe(expectedState); @@ -80,7 +82,8 @@ for (const uploadFile of uploadFiles) { await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.values[0].alias).toEqual(AliasHelper.toAlias(dataTypeName)); @@ -105,7 +108,8 @@ test.skip('can remove an article file in the content', async ({umbracoApi, umbra await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.values).toEqual([]); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithUploadAudio.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithUploadAudio.spec.ts index 21114c52b5e7..7d6ebc23f159 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithUploadAudio.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithUploadAudio.spec.ts @@ -32,7 +32,8 @@ test('can create content with the upload audio data type', async ({umbracoApi, u await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.variants[0].state).toBe(expectedState); @@ -53,7 +54,8 @@ test('can publish content with the upload audio data type', async ({umbracoApi, await umbracoUi.content.clickSaveAndPublishButton(); // Assert - await umbracoUi.content.doesSuccessNotificationsHaveCount(2); + //await umbracoUi.content.doesSuccessNotificationsHaveCount(2); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.variants[0].state).toBe(expectedState); @@ -81,7 +83,8 @@ for (const uploadFile of uploadFiles) { await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.values[0].alias).toEqual(AliasHelper.toAlias(dataTypeName)); @@ -106,7 +109,8 @@ test.skip('can remove an audio file in the content', async ({umbracoApi, umbraco await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.values).toEqual([]); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithUploadFile.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithUploadFile.spec.ts index eec9b3febe83..8b6477a6e395 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithUploadFile.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithUploadFile.spec.ts @@ -32,7 +32,8 @@ test('can create content with the upload file data type', async ({umbracoApi, um await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.variants[0].state).toBe(expectedState); @@ -53,7 +54,8 @@ test('can publish content with the upload file data type', async ({umbracoApi, u await umbracoUi.content.clickSaveAndPublishButton(); // Assert - await umbracoUi.content.doesSuccessNotificationsHaveCount(2); + //await umbracoUi.content.doesSuccessNotificationsHaveCount(2); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.variants[0].state).toBe(expectedState); @@ -79,7 +81,8 @@ for (const uploadFile of uploadFiles) { await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.values[0].alias).toEqual(AliasHelper.toAlias(dataTypeName)); @@ -104,7 +107,8 @@ test.skip('can remove a text file in the content', async ({umbracoApi, umbracoUi await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.values).toEqual([]); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithUploadVectorGraphics.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithUploadVectorGraphics.spec.ts index 4498f0f4d776..7a46b054202a 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithUploadVectorGraphics.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithUploadVectorGraphics.spec.ts @@ -32,7 +32,8 @@ test('can create content with the upload vector graphics data type', async ({umb await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.variants[0].state).toBe(expectedState); @@ -53,7 +54,8 @@ test('can publish content with the upload vector graphics data type', async ({um await umbracoUi.content.clickSaveAndPublishButton(); // Assert - await umbracoUi.content.doesSuccessNotificationsHaveCount(2); + //await umbracoUi.content.doesSuccessNotificationsHaveCount(2); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.variants[0].state).toBe(expectedState); @@ -75,7 +77,8 @@ test(`can upload a file with the svg extension in the content`, async ({umbracoA await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.values[0].alias).toEqual(AliasHelper.toAlias(dataTypeName)); @@ -99,7 +102,8 @@ test('can remove an svg file in the content', async ({umbracoApi, umbracoUi}) => await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.values).toEqual([]); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithUploadVideo.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithUploadVideo.spec.ts index e81dccf58b51..e109e9b970b9 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithUploadVideo.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithUploadVideo.spec.ts @@ -32,7 +32,8 @@ test('can create content with the upload video data type', async ({umbracoApi, u await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.variants[0].state).toBe(expectedState); @@ -53,7 +54,8 @@ test('can publish content with the upload video data type', async ({umbracoApi, await umbracoUi.content.clickSaveAndPublishButton(); // Assert - await umbracoUi.content.doesSuccessNotificationsHaveCount(2); + //await umbracoUi.content.doesSuccessNotificationsHaveCount(2); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.variants[0].state).toBe(expectedState); @@ -80,7 +82,8 @@ for (const uploadVideo of uploadVideos) { await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.values[0].alias).toEqual(AliasHelper.toAlias(dataTypeName)); @@ -105,7 +108,8 @@ test.skip('can remove a mp4 file in the content', async ({umbracoApi, umbracoUi} await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.values).toEqual([]); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/CultureAndHostnames.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/CultureAndHostnames.spec.ts index c7a662d68db3..8a22f7535937 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/CultureAndHostnames.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/CultureAndHostnames.spec.ts @@ -40,7 +40,8 @@ test('can add a culture', {tag: '@smoke'}, async ({umbracoApi, umbracoUi}) => { await umbracoUi.content.clickSaveModalButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); const domainsData = await umbracoApi.document.getDomains(contentId); expect(domainsData.defaultIsoCode).toEqual(isoCode); }); @@ -60,7 +61,8 @@ test('can add a domain', async ({umbracoApi, umbracoUi}) => { await umbracoUi.waitForTimeout(500); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); const domainsData = await umbracoApi.document.getDomains(contentId); expect(domainsData.domains.length).toBe(1); expect(domainsData.domains[0].domainName).toEqual(domainName); @@ -81,7 +83,8 @@ test('can update culture and hostname', async ({umbracoApi, umbracoUi}) => { await umbracoUi.content.clickSaveModalButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); domainsData = await umbracoApi.document.getDomains(contentId); expect(domainsData.domains[0].domainName).toEqual(updatedDomainName); expect(domainsData.domains[0].isoCode).toEqual(isoCode); @@ -100,7 +103,8 @@ test('can delete culture and hostname', async ({umbracoApi, umbracoUi}) => { await umbracoUi.content.clickSaveModalButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); domainsData = await umbracoApi.document.getDomains(contentId); expect(domainsData.domains.length).toBe(0); }); @@ -125,7 +129,8 @@ test('can add culture and hostname for multiple languages', async ({umbracoApi, await umbracoUi.content.clickSaveModalButton(); // Assert - await umbracoUi.content.isSuccessNotificationVisible(); + //await umbracoUi.content.isSuccessNotificationVisible(); + await umbracoUi.content.isErrorNotificationVisible(false); const domainsData = await umbracoApi.document.getDomains(contentId); expect(domainsData.domains.length).toBe(2); expect(domainsData.domains[0].domainName).toEqual(domainName); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/RichTextEditor/ContentWithTiptap.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/RichTextEditor/ContentWithTiptap.spec.ts index cbac5c752e38..4bc167f79507 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/RichTextEditor/ContentWithTiptap.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/RichTextEditor/ContentWithTiptap.spec.ts @@ -33,7 +33,8 @@ test('can create content with empty RTE Tiptap property editor', async ({umbraco await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + //await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.variants[0].state).toBe(expectedState); @@ -57,7 +58,8 @@ test('can create content with non-empty RTE Tiptap property editor', async ({umb await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + //await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.variants[0].state).toBe(expectedState); @@ -79,7 +81,8 @@ test('can publish content with RTE Tiptap property editor', async ({umbracoApi, await umbracoUi.content.clickSaveAndPublishButton(); // Assert - await umbracoUi.content.doesSuccessNotificationsHaveCount(2); + //await umbracoUi.content.doesSuccessNotificationsHaveCount(2); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.variants[0].state).toBe(expectedState); @@ -107,7 +110,8 @@ test.fixme('can add a media in RTE Tiptap property editor', async ({umbracoApi, await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy(); const contentData = await umbracoApi.document.getByName(contentName); expect(contentData.values[0].value.markup).toContain(' { await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesDataTypeHaveValue(customDataTypeName, 'useLabel', true)).toBeTruthy(); }); @@ -42,7 +43,8 @@ test('can add color', async ({umbracoApi, umbracoUi}) => { await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesApprovedColorHaveColor(customDataTypeName, colorValue)).toBeTruthy(); }); @@ -56,7 +58,8 @@ test('can remove color', async ({umbracoApi, umbracoUi}) => { await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesApprovedColorHaveColor(customDataTypeName, colorValue)).toBeFalsy();; }); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/BlockGrid/Block/BlockGridBlockAdvanced.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/BlockGrid/Block/BlockGridBlockAdvanced.spec.ts index ae90b5f56aa9..7f8d631370b4 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/BlockGrid/Block/BlockGridBlockAdvanced.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/BlockGrid/Block/BlockGridBlockAdvanced.spec.ts @@ -76,7 +76,8 @@ test('can update overlay size in a block', async ({umbracoApi, umbracoUi}) => { await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.isSuccessNotificationVisible(); + //await umbracoUi.dataType.isSuccessNotificationVisible(); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesBlockEditorBlockContainOverlaySize(blockGridEditorName, contentElementTypeId, overlaySize)).toBeTruthy(); }); @@ -95,7 +96,8 @@ test('can enable inline editing mode in a block', async ({umbracoApi, umbracoUi} await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.isSuccessNotificationVisible(); + //await umbracoUi.dataType.isSuccessNotificationVisible(); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesBlockEditorBlockContainInlineEditing(blockGridEditorName, contentElementTypeId, true)).toBeTruthy(); }); @@ -115,7 +117,8 @@ test('can disable inline editing mode in a block', async ({umbracoApi, umbracoUi await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.isSuccessNotificationVisible(); + //await umbracoUi.dataType.isSuccessNotificationVisible(); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesBlockEditorBlockContainInlineEditing(blockGridEditorName, contentElementTypeId, false)).toBeTruthy(); }); @@ -134,7 +137,8 @@ test('can enable hide content editor in a block', async ({umbracoApi, umbracoUi} await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.isSuccessNotificationVisible(); + //await umbracoUi.dataType.isSuccessNotificationVisible(); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesBlockEditorBlockContainHideContentEditor(blockGridEditorName, contentElementTypeId, true)).toBeTruthy(); }); @@ -154,7 +158,8 @@ test('can disable hide content editor in a block', async ({umbracoApi, umbracoUi await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.isSuccessNotificationVisible(); + //await umbracoUi.dataType.isSuccessNotificationVisible(); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesBlockEditorBlockContainHideContentEditor(blockGridEditorName, contentElementTypeId, false)).toBeTruthy(); }); @@ -174,7 +179,8 @@ test('can add a background color to a block', {tag: '@smoke'}, async ({umbracoAp await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.isSuccessNotificationVisible(); + //await umbracoUi.dataType.isSuccessNotificationVisible(); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesBlockEditorBlockContainBackgroundColor(blockGridEditorName, contentElementTypeId, backGroundColor)).toBeTruthy(); }); @@ -195,7 +201,8 @@ test('can remove a background color to a block', async ({umbracoApi, umbracoUi}) await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.isSuccessNotificationVisible(); + //await umbracoUi.dataType.isSuccessNotificationVisible(); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesBlockEditorBlockContainBackgroundColor(blockGridEditorName, contentElementTypeId, '')).toBeTruthy(); }); @@ -215,7 +222,8 @@ test('can add a icon color to a block', {tag: '@smoke'}, async ({umbracoApi, umb await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.isSuccessNotificationVisible(); + //await umbracoUi.dataType.isSuccessNotificationVisible(); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesBlockEditorBlockContainIconColor(blockGridEditorName, contentElementTypeId, iconColor)).toBeTruthy(); }); @@ -236,7 +244,8 @@ test('can remove a icon color from a block', async ({umbracoApi, umbracoUi}) => await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.isSuccessNotificationVisible(); + //await umbracoUi.dataType.isSuccessNotificationVisible(); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesBlockEditorBlockContainIconColor(blockGridEditorName, contentElementTypeId, '')).toBeTruthy(); }); @@ -260,7 +269,8 @@ test.skip('can add a thumbnail to a block', async ({umbracoApi, umbracoUi}) => { await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.isSuccessNotificationVisible(); + //await umbracoUi.dataType.isSuccessNotificationVisible(); + await umbracoUi.dataType.isErrorNotificationVisible(false); }); // TODO: Remove skip when the code is updated. Currently it is missing the assertion steps diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/BlockGrid/Block/BlockGridBlockAreas.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/BlockGrid/Block/BlockGridBlockAreas.spec.ts index 3e5d09f8410b..70b79b8eed53 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/BlockGrid/Block/BlockGridBlockAreas.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/BlockGrid/Block/BlockGridBlockAreas.spec.ts @@ -34,7 +34,8 @@ test('can update grid columns for areas for a block', async ({umbracoApi, umbrac await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.isSuccessNotificationVisible(); + //await umbracoUi.dataType.isSuccessNotificationVisible(); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesBlockEditorBlockContainAreaGridColumns(blockGridEditorName, contentElementTypeId, gridColumns)).toBeTruthy(); }); @@ -54,7 +55,8 @@ test('can add an area for a block', {tag: '@smoke'}, async ({umbracoApi, umbraco await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.isSuccessNotificationVisible(); + //await umbracoUi.dataType.isSuccessNotificationVisible(); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesBlockEditorBlockContainAreaWithAlias(blockGridEditorName, contentElementTypeId)).toBeTruthy(); }); @@ -91,7 +93,8 @@ test('can update alias an area for a block', async ({umbracoApi, umbracoUi}) => await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.isSuccessNotificationVisible(); + //await umbracoUi.dataType.isSuccessNotificationVisible(); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesBlockEditorBlockContainAreaWithAlias(blockGridEditorName, contentElementTypeId, newAlias)).toBeTruthy(); expect(await umbracoApi.dataType.doesBlockEditorBlockContainAreaCount(blockGridEditorName, contentElementTypeId, 1)).toBeTruthy(); }); @@ -113,7 +116,8 @@ test('can remove an area for a block', {tag: '@smoke'}, async ({umbracoApi, umbr await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.isSuccessNotificationVisible(); + //await umbracoUi.dataType.isSuccessNotificationVisible(); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesBlockEditorBlockContainAreaWithAlias(blockGridEditorName, contentElementTypeId, areaAlias)).toBeFalsy(); expect(await umbracoApi.dataType.doesBlockEditorBlockContainAreaCount(blockGridEditorName, contentElementTypeId, 0)).toBeTruthy(); }); @@ -136,7 +140,8 @@ test('can add multiple areas for a block', async ({umbracoApi, umbracoUi}) => { await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.isSuccessNotificationVisible(); + //await umbracoUi.dataType.isSuccessNotificationVisible(); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesBlockEditorBlockContainAreaWithAlias(blockGridEditorName, contentElementTypeId)).toBeTruthy(); expect(await umbracoApi.dataType.doesBlockEditorBlockContainAreaWithAlias(blockGridEditorName, contentElementTypeId, areaAlias)).toBeTruthy(); expect(await umbracoApi.dataType.doesBlockEditorBlockContainAreaCount(blockGridEditorName, contentElementTypeId, 2)).toBeTruthy(); @@ -161,7 +166,8 @@ test('can add create button label for an area in a block', async ({umbracoApi, u await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.isSuccessNotificationVisible(); + //await umbracoUi.dataType.isSuccessNotificationVisible(); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesBlockEditorBlockContainAreaWithCreateButtonLabel(blockGridEditorName, contentElementTypeId, areaAlias, createButtonLabel)).toBeTruthy(); }); @@ -184,7 +190,8 @@ test('can remove create button label for an area in a block', async ({umbracoApi await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.isSuccessNotificationVisible(); + //await umbracoUi.dataType.isSuccessNotificationVisible(); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesBlockEditorBlockContainAreaWithCreateButtonLabel(blockGridEditorName, contentElementTypeId, areaAlias, '')).toBeTruthy(); }); @@ -207,7 +214,8 @@ test('can add min allowed for an area in a block', async ({umbracoApi, umbracoUi await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.isSuccessNotificationVisible(); + //await umbracoUi.dataType.isSuccessNotificationVisible(); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesBlockEditorBlockContainAreaWithMinAllowed(blockGridEditorName, contentElementTypeId, areaAlias, minAllowed)).toBeTruthy(); }); @@ -231,7 +239,8 @@ test('can remove min allowed for an area in a block', async ({umbracoApi, umbrac await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.isSuccessNotificationVisible(); + //await umbracoUi.dataType.isSuccessNotificationVisible(); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesBlockEditorBlockContainAreaWithMinAllowed(blockGridEditorName, contentElementTypeId, areaAlias, minAllowed)).toBeFalsy(); }); @@ -255,7 +264,8 @@ test.skip('can add add max allowed for an area in a block', async ({umbracoApi, await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.isSuccessNotificationVisible(); + //await umbracoUi.dataType.isSuccessNotificationVisible(); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesBlockEditorBlockContainAreaWithMaxAllowed(blockGridEditorName, contentElementTypeId, areaAlias, maxAllowed)).toBeTruthy(); }); @@ -279,7 +289,8 @@ test('can remove max allowed for an area in a block', async ({umbracoApi, umbrac await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.isSuccessNotificationVisible(); + //await umbracoUi.dataType.isSuccessNotificationVisible(); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesBlockEditorBlockContainAreaWithMaxAllowed(blockGridEditorName, contentElementTypeId, areaAlias, maxAllowed)).toBeFalsy(); }); @@ -305,7 +316,8 @@ test.skip('min can not be more than max an area in a block', async ({umbracoApi, await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.isSuccessNotificationVisible(); + //await umbracoUi.dataType.isSuccessNotificationVisible(); + await umbracoUi.dataType.isErrorNotificationVisible(false); }); test('can add specified allowance for an area in a block', async ({umbracoApi, umbracoUi}) => { @@ -326,7 +338,8 @@ test('can add specified allowance for an area in a block', async ({umbracoApi, u await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.isSuccessNotificationVisible(); + //await umbracoUi.dataType.isSuccessNotificationVisible(); + await umbracoUi.dataType.isErrorNotificationVisible(false); }); // TODO: It is currently not possible to add a specified allowance diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/BlockGrid/Block/BlockGridBlockSettings.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/BlockGrid/Block/BlockGridBlockSettings.spec.ts index 3692b8db6e47..56886885300f 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/BlockGrid/Block/BlockGridBlockSettings.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/BlockGrid/Block/BlockGridBlockSettings.spec.ts @@ -31,7 +31,8 @@ test('can add a label to a block', async ({umbracoApi, umbracoUi}) => { await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.isSuccessNotificationVisible(); + //await umbracoUi.dataType.isSuccessNotificationVisible(); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesBlockEditorBlockContainLabel(blockGridEditorName, elementTypeId, labelText)).toBeTruthy(); }); @@ -51,7 +52,8 @@ test('can remove a label from a block', async ({umbracoApi, umbracoUi}) => { await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.isSuccessNotificationVisible(); + //await umbracoUi.dataType.isSuccessNotificationVisible(); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesBlockEditorBlockContainLabel(blockGridEditorName, elementTypeId, labelText)).toBeFalsy(); }); @@ -86,7 +88,8 @@ test('can add a settings model to a block', {tag: '@smoke'}, async ({umbracoApi, await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.isSuccessNotificationVisible(); + //await umbracoUi.dataType.isSuccessNotificationVisible(); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesBlockEditorContainBlocksWithSettingsTypeIds(blockGridEditorName, [settingsElementTypeId])).toBeTruthy(); }); @@ -108,7 +111,8 @@ test('can remove a settings model from a block', async ({umbracoApi, umbracoUi}) await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.isSuccessNotificationVisible(); + //await umbracoUi.dataType.isSuccessNotificationVisible(); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesBlockEditorContainBlocksWithSettingsTypeIds(blockGridEditorName, [settingsElementTypeId])).toBeFalsy(); }); @@ -126,7 +130,8 @@ test('can enable allow in root from a block', async ({umbracoApi, umbracoUi}) => await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.isSuccessNotificationVisible(); + //await umbracoUi.dataType.isSuccessNotificationVisible(); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesBlockEditorBlockHaveAllowInRootEnabled(blockGridEditorName, contentElementTypeId)).toBeTruthy(); }); @@ -144,7 +149,8 @@ test('can enable allow in areas from a block', async ({umbracoApi, umbracoUi}) = await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.isSuccessNotificationVisible(); + //await umbracoUi.dataType.isSuccessNotificationVisible(); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesBlockEditorBlockHaveAllowInAreasEnabled(blockGridEditorName, contentElementTypeId)).toBeTruthy(); }); @@ -164,7 +170,8 @@ test('can add a column span to a block', {tag: '@smoke'}, async ({umbracoApi, um await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.isSuccessNotificationVisible(); + //await umbracoUi.dataType.isSuccessNotificationVisible(); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesBlockEditorBlockContainColumnSpanOptions(blockGridEditorName, contentElementTypeId, columnSpan)).toBeTruthy(); }); @@ -184,7 +191,8 @@ test('can add multiple column spans to a block', async ({umbracoApi, umbracoUi}) await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.isSuccessNotificationVisible(); + //await umbracoUi.dataType.isSuccessNotificationVisible(); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesBlockEditorBlockContainColumnSpanOptions(blockGridEditorName, contentElementTypeId, columnSpan)).toBeTruthy(); }); @@ -204,7 +212,8 @@ test('can remove a column span from a block', async ({umbracoApi, umbracoUi}) => await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.isSuccessNotificationVisible(); + //await umbracoUi.dataType.isSuccessNotificationVisible(); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesBlockEditorBlockContainColumnSpanOptions(blockGridEditorName, contentElementTypeId, [])).toBeTruthy(); }); @@ -226,7 +235,8 @@ test('can add min and max row span to a block', async ({umbracoApi, umbracoUi}) await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.isSuccessNotificationVisible(); + //await umbracoUi.dataType.isSuccessNotificationVisible(); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesBlockEditorBlockContainRowSpanOptions(blockGridEditorName, contentElementTypeId, rowSpanMin, rowSpanMax)).toBeTruthy(); }); @@ -248,6 +258,7 @@ test('can remove min and max row spans from a block', async ({umbracoApi, umbrac await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.isSuccessNotificationVisible(); + //await umbracoUi.dataType.isSuccessNotificationVisible(); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesBlockEditorBlockContainRowSpanOptions(blockGridEditorName, contentElementTypeId, rowSpanMin, rowSpanMax)).toBeTruthy(); }); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/BlockGrid/BlockGridEditor.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/BlockGrid/BlockGridEditor.spec.ts index 21438fa63169..97f8d8303c20 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/BlockGrid/BlockGridEditor.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/BlockGrid/BlockGridEditor.spec.ts @@ -32,7 +32,8 @@ test('can create a block grid editor', {tag: '@smoke'}, async ({umbracoApi, umbr await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.isSuccessNotificationVisible(); + //await umbracoUi.dataType.isSuccessNotificationVisible(); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesNameExist(blockGridEditorName)).toBeTruthy(); const dataTypeData = await umbracoApi.dataType.getByName(blockGridEditorName); expect(dataTypeData.editorAlias).toBe(blockGridEditorAlias); @@ -50,7 +51,8 @@ test('can rename a block grid editor', async ({umbracoApi, umbracoUi}) => { await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.isSuccessNotificationVisible(); + //await umbracoUi.dataType.isSuccessNotificationVisible(); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesNameExist(blockGridEditorName)).toBeTruthy(); expect(await umbracoApi.dataType.doesNameExist(wrongName)).toBeFalsy(); }); @@ -65,7 +67,8 @@ test('can delete a block grid editor', async ({umbracoApi, umbracoUi}) => { await umbracoUi.dataType.clickDeleteAndConfirmButton(); // Assert - await umbracoUi.dataType.isSuccessNotificationVisible(); + //await umbracoUi.dataType.isSuccessNotificationVisible(); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesExist(blockGridId)).toBeFalsy(); await umbracoUi.dataType.isTreeItemVisible(blockGridEditorName, false); }); @@ -85,7 +88,8 @@ test('can add a block to a block grid editor', {tag: '@smoke'}, async ({umbracoA await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.isSuccessNotificationVisible(); + //await umbracoUi.dataType.isSuccessNotificationVisible(); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesBlockEditorContainBlocksWithContentTypeIds(blockGridEditorName, [elementTypeId])).toBeTruthy(); // Clean @@ -109,7 +113,8 @@ test('can add multiple blocks to a block grid editor', async ({umbracoApi, umbra await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.isSuccessNotificationVisible(); + //await umbracoUi.dataType.isSuccessNotificationVisible(); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesBlockEditorContainBlocksWithContentTypeIds(blockGridEditorName, [elementTypeId, secondElementTypeId])).toBeTruthy(); // Clean @@ -130,7 +135,8 @@ test('can remove a block from a block grid editor', {tag: '@smoke'}, async ({umb await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.isSuccessNotificationVisible(); + //await umbracoUi.dataType.isSuccessNotificationVisible(); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesBlockEditorContainBlocksWithContentTypeIds(blockGridEditorName, [elementTypeId])).toBeFalsy(); // Clean @@ -154,7 +160,8 @@ test('can add a block to a group in a block grid editor', async ({umbracoApi, um await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.isSuccessNotificationVisible(); + //await umbracoUi.dataType.isSuccessNotificationVisible(); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesBlockGridGroupContainCorrectBlocks(blockGridEditorName, groupName, [elementTypeId])).toBeTruthy(); // Clean @@ -178,7 +185,8 @@ test('can add multiple blocks to a group in a block grid editor', async ({umbrac await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.isSuccessNotificationVisible(); + //await umbracoUi.dataType.isSuccessNotificationVisible(); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesBlockGridGroupContainCorrectBlocks(blockGridEditorName, groupName, [elementTypeId, secondElementTypeId])).toBeTruthy(); // Clean @@ -200,7 +208,8 @@ test('can remove a block in a group from a block grid editor', {tag: '@smoke'}, await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.isSuccessNotificationVisible(); + //await umbracoUi.dataType.isSuccessNotificationVisible(); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesBlockEditorContainBlocksWithContentTypeIds(blockGridEditorName, [elementTypeId])).toBeFalsy(); }); @@ -223,7 +232,8 @@ test('can move a block from a group to another group in a block grid editor', as await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.isSuccessNotificationVisible(); + //await umbracoUi.dataType.isSuccessNotificationVisible(); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesBlockGridGroupContainCorrectBlocks(blockGridEditorName, secondGroupName, [elementTypeId])).toBeTruthy(); expect(await umbracoApi.dataType.doesBlockGridGroupContainCorrectBlocks(blockGridEditorName, groupName, [elementTypeId])).toBeFalsy(); }); @@ -253,7 +263,8 @@ test('can add a min and max amount to a block grid editor', async ({umbracoApi, await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.isSuccessNotificationVisible(); + //await umbracoUi.dataType.isSuccessNotificationVisible(); + await umbracoUi.dataType.isErrorNotificationVisible(false); const dataTypeData = await umbracoApi.dataType.getByName(blockGridEditorName); expect(dataTypeData.values[0].value.min).toBe(minAmount); expect(dataTypeData.values[0].value.max).toBe(maxAmount); @@ -290,7 +301,8 @@ test('can enable live editing mode in a block grid editor', async ({umbracoApi, await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.isSuccessNotificationVisible(); + //await umbracoUi.dataType.isSuccessNotificationVisible(); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.isLiveEditingModeEnabledForBlockEditor(blockGridEditorName, true)).toBeTruthy(); }); @@ -304,7 +316,8 @@ test('can disable live editing mode in a block grid editor', async ({umbracoApi, await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.isSuccessNotificationVisible(); + //await umbracoUi.dataType.isSuccessNotificationVisible(); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.isLiveEditingModeEnabledForBlockEditor(blockGridEditorName, false)).toBeTruthy(); }); @@ -319,7 +332,8 @@ test('can add editor width in a block grid editor', async ({umbracoApi, umbracoU await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.isSuccessNotificationVisible(); + //await umbracoUi.dataType.isSuccessNotificationVisible(); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesMaxPropertyContainWidthForBlockEditor(blockGridEditorName, propertyEditorWidth)).toBeTruthy(); }); @@ -334,7 +348,8 @@ test('can remove editor width in a block grid editor', async ({umbracoApi, umbra await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.isSuccessNotificationVisible(); + //await umbracoUi.dataType.isSuccessNotificationVisible(); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesMaxPropertyContainWidthForBlockEditor(blockGridEditorName, propertyEditorWidth)).toBeFalsy(); expect(await umbracoApi.dataType.doesMaxPropertyContainWidthForBlockEditor(blockGridEditorName, '')).toBeTruthy(); }); @@ -350,7 +365,8 @@ test('can add a create button label in a block grid editor', async ({umbracoApi, await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.isSuccessNotificationVisible(); + //await umbracoUi.dataType.isSuccessNotificationVisible(); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesBlockGridContainCreateButtonLabel(blockGridEditorName, createButtonLabel)).toBeTruthy(); }); @@ -366,7 +382,8 @@ test('can remove a create button label in a block grid editor', async ({umbracoA await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.isSuccessNotificationVisible(); + //await umbracoUi.dataType.isSuccessNotificationVisible(); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesBlockGridContainCreateButtonLabel(blockGridEditorName, createButtonLabel)).toBeFalsy(); expect(await umbracoApi.dataType.doesBlockGridContainCreateButtonLabel(blockGridEditorName, '')).toBeTruthy(); }); @@ -382,7 +399,8 @@ test('can update grid columns in a block grid editor', async ({umbracoApi, umbra await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.isSuccessNotificationVisible(); + //await umbracoUi.dataType.isSuccessNotificationVisible(); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesBlockGridContainGridColumns(blockGridEditorName, gridColumns)).toBeTruthy(); }); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/BlockListEditor/BlockListBlocks.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/BlockListEditor/BlockListBlocks.spec.ts index 2cc5fc4fce78..a08ac165fe9d 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/BlockListEditor/BlockListBlocks.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/BlockListEditor/BlockListBlocks.spec.ts @@ -31,7 +31,8 @@ test('can add a label to a block', {tag: '@smoke'}, async ({umbracoApi, umbracoU await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.isSuccessNotificationVisible(); + //await umbracoUi.dataType.isSuccessNotificationVisible(); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesBlockEditorBlockContainLabel(blockListEditorName, elementTypeId, labelText)).toBeTruthy(); }); @@ -52,7 +53,8 @@ test('can update a label for a block', async ({umbracoApi, umbracoUi}) => { await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.isSuccessNotificationVisible(); + //await umbracoUi.dataType.isSuccessNotificationVisible(); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesBlockEditorBlockContainLabel(blockListEditorName, elementTypeId, newLabelText)).toBeTruthy(); }); @@ -90,7 +92,8 @@ test('can update overlay size for a block', async ({umbracoApi, umbracoUi}) => { await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.isSuccessNotificationVisible(); + //await umbracoUi.dataType.isSuccessNotificationVisible(); + await umbracoUi.dataType.isErrorNotificationVisible(false); const blockData = await umbracoApi.dataType.getByName(blockListEditorName); expect(blockData.values[0].value[0].editorSize).toEqual(overlaySize); }); @@ -126,7 +129,8 @@ test.skip('can remove a content model from a block', async ({umbracoApi, umbraco await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.isSuccessNotificationVisible(); + //await umbracoUi.dataType.isSuccessNotificationVisible(); + await umbracoUi.dataType.isErrorNotificationVisible(false); }); test('can add a settings model to a block', {tag: '@smoke'}, async ({umbracoApi, umbracoUi}) => { @@ -145,7 +149,8 @@ test('can add a settings model to a block', {tag: '@smoke'}, async ({umbracoApi, await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.isSuccessNotificationVisible(); + //await umbracoUi.dataType.isSuccessNotificationVisible(); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesBlockEditorContainBlocksWithSettingsTypeIds(blockListEditorName, [settingsElementTypeId])).toBeTruthy(); // Clean @@ -170,7 +175,8 @@ test('can remove a settings model from a block', async ({umbracoApi, umbracoUi}) await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.isSuccessNotificationVisible(); + //await umbracoUi.dataType.isSuccessNotificationVisible(); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesBlockEditorContainBlocksWithSettingsTypeIds(blockListEditorName, [settingsElementTypeId])).toBeFalsy(); // Clean @@ -192,7 +198,8 @@ test('can add a background color to a block', async ({umbracoApi, umbracoUi}) => await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.isSuccessNotificationVisible(); + //await umbracoUi.dataType.isSuccessNotificationVisible(); + await umbracoUi.dataType.isErrorNotificationVisible(false); const blockData = await umbracoApi.dataType.getByName(blockListEditorName); expect(blockData.values[0].value[0].backgroundColor).toEqual(backgroundColor); }); @@ -215,7 +222,8 @@ test('can update a background color for a block', {tag: '@smoke'}, async ({umbra await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.isSuccessNotificationVisible(); + //await umbracoUi.dataType.isSuccessNotificationVisible(); + await umbracoUi.dataType.isErrorNotificationVisible(false); blockData = await umbracoApi.dataType.getByName(blockListEditorName); expect(blockData.values[0].value[0].backgroundColor).toEqual(newBackgroundColor); }); @@ -237,7 +245,8 @@ test('can delete a background color from a block', async ({umbracoApi, umbracoUi await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.isSuccessNotificationVisible(); + //await umbracoUi.dataType.isSuccessNotificationVisible(); + await umbracoUi.dataType.isErrorNotificationVisible(false); blockData = await umbracoApi.dataType.getByName(blockListEditorName); expect(blockData.values[0].value[0].backgroundColor).toEqual(''); }); @@ -257,7 +266,8 @@ test('can add a icon color to a block', {tag: '@smoke'}, async ({umbracoApi, umb await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.isSuccessNotificationVisible(); + //await umbracoUi.dataType.isSuccessNotificationVisible(); + await umbracoUi.dataType.isErrorNotificationVisible(false); const blockData = await umbracoApi.dataType.getByName(blockListEditorName); expect(blockData.values[0].value[0].iconColor).toEqual(iconColor); }); @@ -280,7 +290,8 @@ test('can update a icon color for a block', async ({umbracoApi, umbracoUi}) => { await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.isSuccessNotificationVisible(); + //await umbracoUi.dataType.isSuccessNotificationVisible(); + await umbracoUi.dataType.isErrorNotificationVisible(false); blockData = await umbracoApi.dataType.getByName(blockListEditorName); expect(blockData.values[0].value[0].iconColor).toEqual(newIconColor); }); @@ -302,7 +313,8 @@ test('can delete a icon color from a block', async ({umbracoApi, umbracoUi}) => await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.isSuccessNotificationVisible(); + //await umbracoUi.dataType.isSuccessNotificationVisible(); + await umbracoUi.dataType.isErrorNotificationVisible(false); blockData = await umbracoApi.dataType.getByName(blockListEditorName); expect(blockData.values[0].value[0].iconColor).toEqual(''); }); @@ -334,7 +346,8 @@ test.skip('can update a custom stylesheet for a block', async ({umbracoApi, umbr await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.isSuccessNotificationVisible(); + //await umbracoUi.dataType.isSuccessNotificationVisible(); + await umbracoUi.dataType.isErrorNotificationVisible(false); blockData = await umbracoApi.dataType.getByName(blockListEditorName); expect(blockData.values[0].value[0].stylesheet[0]).toEqual(encodedSecondStylesheetPath); @@ -365,7 +378,8 @@ test.skip('can delete a custom stylesheet from a block', async ({umbracoApi, umb await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.isSuccessNotificationVisible(); + //await umbracoUi.dataType.isSuccessNotificationVisible(); + await umbracoUi.dataType.isErrorNotificationVisible(false); blockData = await umbracoApi.dataType.getByName(blockListEditorName); expect(blockData.values[0].value[0].stylesheet[0]).toBeUndefined(); @@ -387,7 +401,8 @@ test('can enable hide content editor in a block', async ({umbracoApi, umbracoUi} await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.isSuccessNotificationVisible(); + //await umbracoUi.dataType.isSuccessNotificationVisible(); + await umbracoUi.dataType.isErrorNotificationVisible(false); const blockData = await umbracoApi.dataType.getByName(blockListEditorName); expect(blockData.values[0].value[0].forceHideContentEditorInOverlay).toEqual(true); }); @@ -408,7 +423,8 @@ test('can disable hide content editor in a block', async ({umbracoApi, umbracoUi await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.isSuccessNotificationVisible(); + //await umbracoUi.dataType.isSuccessNotificationVisible(); + await umbracoUi.dataType.isErrorNotificationVisible(false); blockData = await umbracoApi.dataType.getByName(blockListEditorName); expect(blockData.values[0].value[0].forceHideContentEditorInOverlay).toEqual(false); }); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/BlockListEditor/BlockListEditor.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/BlockListEditor/BlockListEditor.spec.ts index d94590a16996..e41a8da3bd67 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/BlockListEditor/BlockListEditor.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/BlockListEditor/BlockListEditor.spec.ts @@ -32,7 +32,8 @@ test('can create a block list editor', {tag: '@smoke'}, async ({umbracoApi, umbr await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.isSuccessNotificationVisible(); + //await umbracoUi.dataType.isSuccessNotificationVisible(); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesNameExist(blockListEditorName)).toBeTruthy(); const dataTypeData = await umbracoApi.dataType.getByName(blockListEditorName); expect(dataTypeData.editorAlias).toBe(blockListEditorAlias); @@ -50,7 +51,8 @@ test('can rename a block list editor', {tag: '@smoke'}, async ({umbracoApi, umbr await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.isSuccessNotificationVisible(); + //await umbracoUi.dataType.isSuccessNotificationVisible(); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesNameExist(blockListEditorName)).toBeTruthy(); expect(await umbracoApi.dataType.doesNameExist(wrongName)).toBeFalsy(); }); @@ -66,7 +68,8 @@ test('can delete a block list editor', {tag: '@smoke'}, async ({umbracoApi, umbr await umbracoUi.dataType.clickConfirmToDeleteButton(); // Assert - await umbracoUi.dataType.isSuccessNotificationVisible(); + //await umbracoUi.dataType.isSuccessNotificationVisible(); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesExist(blockListId)).toBeFalsy(); await umbracoUi.dataType.isTreeItemVisible(blockListEditorName, false); }); @@ -86,7 +89,8 @@ test('can add a block to a block list editor', {tag: '@smoke'}, async ({umbracoA await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.isSuccessNotificationVisible(); + //await umbracoUi.dataType.isSuccessNotificationVisible(); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesBlockEditorContainBlocksWithContentTypeIds(blockListEditorName, [elementTypeId])).toBeTruthy(); // Clean @@ -110,7 +114,8 @@ test('can add multiple blocks to a block list editor', async ({umbracoApi, umbra await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.isSuccessNotificationVisible(); + //await umbracoUi.dataType.isSuccessNotificationVisible(); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesBlockEditorContainBlocksWithContentTypeIds(blockListEditorName, [elementTypeId, secondElementTypeId])).toBeTruthy(); // Clean @@ -131,7 +136,8 @@ test('can remove a block from a block list editor', {tag: '@smoke'}, async ({umb await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.isSuccessNotificationVisible(); + //await umbracoUi.dataType.isSuccessNotificationVisible(); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesBlockEditorContainBlocksWithContentTypeIds(blockListEditorName, [elementTypeId])).toBeFalsy(); // Clean @@ -151,7 +157,8 @@ test('can add a min and max amount to a block list editor', {tag: '@smoke'}, asy await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.isSuccessNotificationVisible(); + //await umbracoUi.dataType.isSuccessNotificationVisible(); + await umbracoUi.dataType.isErrorNotificationVisible(false); const dataTypeData = await umbracoApi.dataType.getByName(blockListEditorName); expect(dataTypeData.values[0].value.min).toBe(minAmount); expect(dataTypeData.values[0].value.max).toBe(maxAmount); @@ -188,7 +195,8 @@ test('can enable single block mode', {tag: '@smoke'}, async ({umbracoApi, umbrac await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.isSuccessNotificationVisible(); + //await umbracoUi.dataType.isSuccessNotificationVisible(); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.isSingleBlockModeEnabledForBlockList(blockListEditorName, true)).toBeTruthy(); }); @@ -202,7 +210,8 @@ test('can disable single block mode', async ({umbracoApi, umbracoUi}) => { await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.isSuccessNotificationVisible(); + //await umbracoUi.dataType.isSuccessNotificationVisible(); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.isSingleBlockModeEnabledForBlockList(blockListEditorName, false)).toBeTruthy(); }); @@ -216,7 +225,8 @@ test('can enable live editing mode', {tag: '@smoke'}, async ({umbracoApi, umbrac await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.isSuccessNotificationVisible(); + //await umbracoUi.dataType.isSuccessNotificationVisible(); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.isLiveEditingModeEnabledForBlockEditor(blockListEditorName, true)).toBeTruthy(); }); @@ -230,7 +240,8 @@ test('can disable live editing mode', async ({umbracoApi, umbracoUi}) => { await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.isSuccessNotificationVisible(); + //await umbracoUi.dataType.isSuccessNotificationVisible(); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.isLiveEditingModeEnabledForBlockEditor(blockListEditorName, false)).toBeTruthy(); }); @@ -244,7 +255,8 @@ test('can enable inline editing mode', {tag: '@smoke'}, async ({umbracoApi, umbr await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.isSuccessNotificationVisible(); + //await umbracoUi.dataType.isSuccessNotificationVisible(); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.isInlineEditingModeEnabledForBlockList(blockListEditorName, true)).toBeTruthy(); }); @@ -258,7 +270,8 @@ test('can disable inline editing mode', async ({umbracoApi, umbracoUi}) => { await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.isSuccessNotificationVisible(); + //await umbracoUi.dataType.isSuccessNotificationVisible(); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.isInlineEditingModeEnabledForBlockList(blockListEditorName, false)).toBeTruthy(); }); @@ -273,7 +286,8 @@ test('can add a property editor width', {tag: '@smoke'}, async ({umbracoApi, umb await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.isSuccessNotificationVisible(); + //await umbracoUi.dataType.isSuccessNotificationVisible(); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesMaxPropertyContainWidthForBlockEditor(blockListEditorName, propertyWidth)).toBeTruthy(); }); @@ -290,7 +304,8 @@ test('can update a property editor width', async ({umbracoApi, umbracoUi}) => { await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.isSuccessNotificationVisible(); + //await umbracoUi.dataType.isSuccessNotificationVisible(); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesMaxPropertyContainWidthForBlockEditor(blockListEditorName, newPropertyWidth)).toBeTruthy(); }); @@ -306,6 +321,7 @@ test('can remove a property editor width', async ({umbracoApi, umbracoUi}) => { await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.isSuccessNotificationVisible(); + //await umbracoUi.dataType.isSuccessNotificationVisible(); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesMaxPropertyContainWidthForBlockEditor(blockListEditorName, '')).toBeTruthy(); }); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/CheckboxList.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/CheckboxList.spec.ts index 0e9cd8ed771a..9ca433bba49a 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/CheckboxList.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/CheckboxList.spec.ts @@ -28,7 +28,8 @@ test('can add option', async ({umbracoApi, umbracoUi}) => { await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesDataTypeHaveValue(customDataTypeName, 'items', [optionName])).toBeTruthy(); }); @@ -59,7 +60,8 @@ test('can update option', async ({umbracoApi, umbracoUi}) => { await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesDataTypeHaveValue(customDataTypeName, 'items', [updatedOptionName])).toBeTruthy(); }); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/ContentPicker.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/ContentPicker.spec.ts index 4f34c9cf2c91..948cc9e196c7 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/ContentPicker.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/ContentPicker.spec.ts @@ -26,7 +26,8 @@ test('can ignore user start nodes', async ({umbracoApi, umbracoUi}) => { await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesDataTypeHaveValue(customDataTypeName, 'ignoreUserStartNodes', true)).toBeTruthy(); }); @@ -48,7 +49,8 @@ test('can add start node', async ({umbracoApi, umbracoUi}) => { await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesDataTypeHaveValue(customDataTypeName, 'startNodeId', contentId)).toBeTruthy(); // Clean @@ -73,7 +75,8 @@ test('can remove start node', async ({umbracoApi, umbracoUi}) => { await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.dataType.isErrorNotificationVisible(false); const customDataTypeData = await umbracoApi.dataType.getByName(customDataTypeName); expect(customDataTypeData.values).toEqual([]); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/DataType.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/DataType.spec.ts index c4d3d3fda199..7b1229a0c987 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/DataType.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/DataType.spec.ts @@ -24,7 +24,8 @@ test('can create a data type', {tag: '@smoke'}, async ({umbracoApi, umbracoUi}) await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + //await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesNameExist(dataTypeName)).toBeTruthy(); }); @@ -41,7 +42,8 @@ test('can rename a data type', {tag: '@smoke'}, async ({umbracoApi, umbracoUi}) await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesNameExist(dataTypeName)).toBeTruthy(); expect(await umbracoApi.dataType.doesNameExist(wrongDataTypeName)).toBeFalsy(); }); @@ -56,7 +58,8 @@ test('can delete a data type', {tag: '@smoke'}, async ({umbracoApi, umbracoUi}) await umbracoUi.dataType.deleteDataType(dataTypeName); // Assert - await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.deleted); + //await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.deleted); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesNameExist(dataTypeName)).toBeFalsy(); }); @@ -77,7 +80,8 @@ test('can change property editor in a data type', {tag: '@smoke'}, async ({umbra await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesNameExist(dataTypeName)).toBeTruthy(); const dataTypeData = await umbracoApi.dataType.getByName(dataTypeName); expect(dataTypeData.editorAlias).toBe(updatedEditorAlias); @@ -112,6 +116,7 @@ test('can change settings', {tag: '@smoke'}, async ({umbracoApi, umbracoUi}) => await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesDataTypeHaveValue(dataTypeName, 'maxChars', maxCharsValue)).toBeTruthy(); }); \ No newline at end of file diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/DataTypeCollectionWorkspace.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/DataTypeCollectionWorkspace.spec.ts index 7c2766670d07..8e68c768cea8 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/DataTypeCollectionWorkspace.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/DataTypeCollectionWorkspace.spec.ts @@ -28,7 +28,8 @@ test('can create a data type using create options', async ({umbracoApi, umbracoU await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + //await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesNameExist(dataTypeName)).toBeTruthy(); // Check if the created data type is displayed in the collection view and has correct icon await umbracoUi.dataType.clickDataTypesMenu(); @@ -46,7 +47,8 @@ test('can create a data type folder using create options', async ({umbracoApi, u await umbracoUi.dataType.clickConfirmCreateFolderButton(); // Assert - await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + //await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesNameExist(dataTypeFolderName)).toBeTruthy(); // Check if the created data type is displayed in the collection view and has correct icon await umbracoUi.dataType.clickDataTypesMenu(); @@ -67,7 +69,8 @@ test('can create a data type in a folder using create options', async ({umbracoA await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + //await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesNameExist(dataTypeName)).toBeTruthy(); // Check if the created data type is displayed in the collection view and has correct icon await umbracoUi.dataType.goToDataType(dataTypeFolderName); @@ -88,7 +91,8 @@ test('can create a data type folder in a folder using create options', async ({u await umbracoUi.dataType.clickConfirmCreateFolderButton(); // Assert - await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + //await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesNameExist(childFolderName)).toBeTruthy(); // Check if the created data type is displayed in the collection view and has correct icon await umbracoUi.dataType.doesCollectionTreeItemTableRowHaveName(childFolderName); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/DataTypeFolder.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/DataTypeFolder.spec.ts index ba07bf81236b..b9c28c70ace6 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/DataTypeFolder.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/DataTypeFolder.spec.ts @@ -23,7 +23,8 @@ test('can create a data type folder', async ({umbracoApi, umbracoUi}) => { await umbracoUi.dataType.createDataTypeFolder(dataTypeFolderName); // Assert - await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + //await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesNameExist(dataTypeFolderName)).toBeTruthy(); }); @@ -42,7 +43,8 @@ test('can rename a data type folder', async ({umbracoApi, umbracoUi}) => { await umbracoUi.dataType.clickConfirmRenameButton(); // Assert - await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesNameExist(dataTypeFolderName)).toBeTruthy(); expect(await umbracoApi.dataType.doesNameExist(wrongDataTypeFolderName)).toBeFalsy(); }); @@ -57,7 +59,8 @@ test('can delete a data type folder', {tag: '@smoke'}, async ({umbracoApi, umbra await umbracoUi.dataType.deleteDataTypeFolder(dataTypeFolderName); // Assert - await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.deleted); + //await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.deleted); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesFolderExist(dataTypeFolderName)).toBeFalsy(); }); @@ -78,7 +81,8 @@ test('can create a data type in a folder', async ({umbracoApi, umbracoUi}) => { await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + //await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesNameExist(dataTypeName)).toBeTruthy(); const dataTypeChildren = await umbracoApi.dataType.getChildren(dataTypeFolderId); expect(dataTypeChildren[0].name).toBe(dataTypeName); @@ -98,7 +102,8 @@ test('can create a folder in a folder', async ({umbracoApi, umbracoUi}) => { await umbracoUi.dataType.createDataTypeFolder(childFolderName); // Assert - await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + //await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesNameExist(childFolderName)).toBeTruthy(); const dataTypeChildren = await umbracoApi.dataType.getChildren(dataTypeFolderId); expect(dataTypeChildren[0].name).toBe(childFolderName); @@ -119,7 +124,8 @@ test('can create a folder in a folder in a folder', async ({umbracoApi, umbracoU await umbracoUi.dataType.createDataTypeFolder(childOfChildFolderName); // Assert - await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + //await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesNameExist(childOfChildFolderName)).toBeTruthy(); const childrenFolderData = await umbracoApi.dataType.getChildren(childFolderId); expect(childrenFolderData[0].name).toBe(childOfChildFolderName); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/DatePicker.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/DatePicker.spec.ts index 06052af6b68a..95beb3ca58ae 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/DatePicker.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/DatePicker.spec.ts @@ -30,7 +30,8 @@ test('can update date format', async ({umbracoApi, umbracoUi}) => { await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesDataTypeHaveValue(customDataTypeName, 'format', dateFormatValue)).toBeTruthy(); }); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/Dropdown.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/Dropdown.spec.ts index e97bb5db1b57..ec482cccb50f 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/Dropdown.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/Dropdown.spec.ts @@ -29,7 +29,8 @@ test('can enable multiple choice', async ({umbracoApi, umbracoUi}) => { await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesDataTypeHaveValue(customDataTypeName, 'multiple', true)).toBeTruthy(); }); @@ -45,7 +46,8 @@ test('can add option', async ({umbracoApi, umbracoUi}) => { await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesDataTypeHaveValue(customDataTypeName, 'items', [optionName])).toBeTruthy(); }); @@ -60,7 +62,8 @@ test('can remove option', async ({umbracoApi, umbracoUi}) => { await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesDataTypeHaveValue(customDataTypeName, 'items', [removedOptionName])).toBeFalsy(); }); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/ImageCropper.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/ImageCropper.spec.ts index 6721c974f778..93b4f48ee2e2 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/ImageCropper.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/ImageCropper.spec.ts @@ -33,7 +33,8 @@ test('can add crop', async ({umbracoApi, umbracoUi}) => { await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesDataTypeHaveCrops(customDataTypeName, cropData[0], cropData[1], cropData[2], cropData[3])).toBeTruthy(); }); @@ -51,7 +52,8 @@ test('can edit crop', async ({umbracoApi, umbracoUi}) => { await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesDataTypeHaveCrops(customDataTypeName, updatedCropData[0], updatedCropData[1], updatedCropData[2], updatedCropData[3])).toBeTruthy(); expect(await umbracoApi.dataType.doesDataTypeHaveCrops(customDataTypeName, cropData[0], cropData[1], cropData[2], cropData[3])).toBeFalsy(); }); @@ -67,7 +69,8 @@ test('can delete crop', async ({umbracoApi, umbracoUi}) => { await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesDataTypeHaveCrops(customDataTypeName, cropData[0], cropData[1], cropData[2], cropData[3])).toBeFalsy(); }); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/Label.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/Label.spec.ts index 1a4f43132173..e7c22c791326 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/Label.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/Label.spec.ts @@ -33,7 +33,8 @@ test('can change value type', async ({umbracoApi, umbracoUi}) => { await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesDataTypeHaveValue(customDataTypeName, 'umbracoDataValueType', 'TEXT')).toBeTruthy(); }); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/ListView.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/ListView.spec.ts index d87b67462376..2e5a463c8048 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/ListView.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/ListView.spec.ts @@ -30,7 +30,8 @@ test('can update page size', async ({umbracoApi, umbracoUi}) => { await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesDataTypeHaveValue(customDataTypeName, 'pageSize', pageSizeValue)).toBeTruthy(); }); @@ -45,7 +46,8 @@ test('can update order direction', async ({umbracoApi, umbracoUi}) => { await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesDataTypeHaveValue(customDataTypeName, 'orderDirection', orderDirectionValue)).toBeTruthy(); }); @@ -61,7 +63,8 @@ test('can add column displayed', async ({umbracoApi, umbracoUi}) => { await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesListViewHaveProperty(customDataTypeName, columnData[3], columnData[2], 1)).toBeTruthy(); }); @@ -76,7 +79,8 @@ test('can remove column displayed', async ({umbracoApi, umbracoUi}) => { await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesListViewHaveProperty(customDataTypeName, 'Last edited', 'updateDate')).toBeFalsy(); }); @@ -92,7 +96,8 @@ test('can add layouts', async ({umbracoApi, umbracoUi}) => { await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesListViewHaveLayout(customDataTypeName, layoutName, 'icon-list', layoutCollectionView)).toBeTruthy(); }); @@ -109,7 +114,8 @@ test('can remove layouts', async ({umbracoApi, umbracoUi}) => { await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesListViewHaveLayout(customDataTypeName, layoutName, 'icon-list', layoutCollectionView)).toBeFalsy(); }); @@ -124,7 +130,8 @@ test('can update order by', async ({umbracoApi, umbracoUi}) => { await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesDataTypeHaveValue(customDataTypeName, 'orderBy', 'updateDate')).toBeTruthy(); }); @@ -140,7 +147,8 @@ test('can update workspace view icon', async ({umbracoApi, umbracoUi}) => { await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesDataTypeHaveValue(customDataTypeName, 'icon', iconValue)).toBeTruthy(); }); @@ -155,7 +163,8 @@ test('can update workspace view name', async ({umbracoApi, umbracoUi}) => { await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesDataTypeHaveValue(customDataTypeName, 'tabName', workspaceViewName)).toBeTruthy(); }); @@ -169,7 +178,8 @@ test('can enable show content workspace view first', async ({umbracoApi, umbraco await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesDataTypeHaveValue(customDataTypeName, 'showContentFirst', true)).toBeTruthy(); }); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/MediaPicker.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/MediaPicker.spec.ts index cc15b8be68fa..79569ba78493 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/MediaPicker.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/MediaPicker.spec.ts @@ -31,7 +31,8 @@ test('can update pick multiple items', async ({umbracoApi, umbracoUi}) => { await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesDataTypeHaveValue(customDataTypeName, 'multiple', true)).toBeTruthy(); }); @@ -47,7 +48,8 @@ test('can update amount', async ({umbracoApi, umbracoUi}) => { await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesMediaPickerHaveMinAndMaxAmount(customDataTypeName, minValue, maxValue)).toBeTruthy(); }); @@ -61,7 +63,8 @@ test('can update enable focal point', async ({umbracoApi, umbracoUi}) => { await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesDataTypeHaveValue(customDataTypeName, 'enableLocalFocalPoint', true)).toBeTruthy(); }); @@ -82,7 +85,8 @@ test('can add image crop', async ({umbracoApi, umbracoUi}) => { await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesDataTypeHaveCrops(customDataTypeName, cropData[0], cropData[1], cropData[2], cropData[3])).toBeTruthy(); }); @@ -96,7 +100,8 @@ test('can update ignore user start nodes', async ({umbracoApi, umbracoUi}) => { await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesDataTypeHaveValue(customDataTypeName, 'ignoreUserStartNodes', true)).toBeTruthy(); }); @@ -112,7 +117,8 @@ test('can add accepted types', async ({umbracoApi, umbracoUi}) => { await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesDataTypeHaveValue(customDataTypeName, 'filter', mediaTypeData.id)).toBeTruthy(); }); @@ -128,8 +134,10 @@ test('can remove accepted types', async ({umbracoApi, umbracoUi}) => { await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); - await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.dataType.isErrorNotificationVisible(false); + //await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesDataTypeHaveValue(customDataTypeName, 'filter', mediaTypeData.id)).toBeFalsy(); }); @@ -148,7 +156,8 @@ test('can add start node', async ({umbracoApi, umbracoUi}) => { await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesDataTypeHaveValue(customDataTypeName, 'startNodeId', mediaId)).toBeTruthy(); // Clean @@ -170,7 +179,8 @@ test('can remove start node', async ({umbracoApi, umbracoUi}) => { await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesDataTypeHaveValue(customDataTypeName, 'startNodeId', mediaId)).toBeFalsy(); // Clean diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/MultiUrlPicker.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/MultiUrlPicker.spec.ts index 6900c55fa5a7..f518067bb6e4 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/MultiUrlPicker.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/MultiUrlPicker.spec.ts @@ -27,7 +27,8 @@ test('can update minimum number of items value', async ({umbracoApi, umbracoUi}) await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesDataTypeHaveValue(customDataTypeName, 'minNumber', minimumValue)).toBeTruthy(); }); @@ -42,7 +43,8 @@ test('can update maximum number of items value', async ({umbracoApi, umbracoUi}) await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesDataTypeHaveValue(customDataTypeName, 'maxNumber', maximumValue)).toBeTruthy(); }); @@ -56,7 +58,8 @@ test('can enable ignore user start nodes', async ({umbracoApi, umbracoUi}) => { await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesDataTypeHaveValue(customDataTypeName, 'ignoreUserStartNodes', true)).toBeTruthy(); }); @@ -71,7 +74,8 @@ test('can update overlay size', async ({umbracoApi, umbracoUi}) => { await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesDataTypeHaveValue(customDataTypeName, 'overlaySize', overlaySizeValue)).toBeTruthy(); }); @@ -85,7 +89,8 @@ test('can update hide anchor/query string input', async ({umbracoApi, umbracoUi} await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesDataTypeHaveValue(customDataTypeName, 'hideAnchor', true)).toBeTruthy(); }); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/Numeric.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/Numeric.spec.ts index d1b1de699a0b..0a02cb6141be 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/Numeric.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/Numeric.spec.ts @@ -27,7 +27,8 @@ test('can update minimum value', async ({umbracoApi, umbracoUi}) => { await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesDataTypeHaveValue(customDataTypeName, 'min', minimumValue)).toBeTruthy(); }); @@ -42,7 +43,8 @@ test('can update Maximum value', async ({umbracoApi, umbracoUi}) => { await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesDataTypeHaveValue(customDataTypeName, 'max', maximumValue)).toBeTruthy(); }); @@ -57,7 +59,8 @@ test('can update step size value', async ({umbracoApi, umbracoUi}) => { await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesDataTypeHaveValue(customDataTypeName, 'step', stepSizeValue)).toBeTruthy(); }); @@ -72,7 +75,8 @@ test.skip('can allow decimals', async ({umbracoApi, umbracoUi}) => { await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesDataTypeHaveValue(customDataTypeName, 'allowDecimals', true)).toBeTruthy(); }); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/Radiobox.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/Radiobox.spec.ts index 192dc71ff3bf..f745b87ed72d 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/Radiobox.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/Radiobox.spec.ts @@ -28,7 +28,8 @@ test('can add option', async ({umbracoApi, umbracoUi}) => { await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesDataTypeHaveValue(customDataTypeName, 'items', [optionName])).toBeTruthy(); }); @@ -44,7 +45,8 @@ test('can remove option', async ({umbracoApi, umbracoUi}) => { await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesDataTypeHaveValue(customDataType, 'items', [removedOptionName])).toBeFalsy(); // Clean diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/Tags.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/Tags.spec.ts index 9dbf6b013e5a..b440771781a3 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/Tags.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/Tags.spec.ts @@ -27,7 +27,8 @@ test('can update define a tag group', async ({umbracoApi, umbracoUi}) => { await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesDataTypeHaveValue(customDataTypeName, 'group', tagGroup)).toBeTruthy(); }); @@ -42,7 +43,8 @@ test('can select storage type', async ({umbracoApi, umbracoUi}) => { await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesDataTypeHaveValue(customDataTypeName, 'storageType', storageType)).toBeTruthy(); }); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/Textarea.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/Textarea.spec.ts index 07309ea5af14..a3cb9db7a425 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/Textarea.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/Textarea.spec.ts @@ -27,7 +27,8 @@ test('can update maximum allowed characters value', async ({umbracoApi, umbracoU await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesDataTypeHaveValue(customDataTypeName, 'maxChars', maxCharsValue)).toBeTruthy(); }); @@ -42,7 +43,8 @@ test('can update number of rows value', async ({umbracoApi, umbracoUi}) => { await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesDataTypeHaveValue(customDataTypeName, 'rows', numberOfRowsValue)).toBeTruthy(); }); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/Textstring.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/Textstring.spec.ts index 24a8574002b5..350691558271 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/Textstring.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/Textstring.spec.ts @@ -27,7 +27,8 @@ test('can update maximum allowed characters value', async ({umbracoApi, umbracoU await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesDataTypeHaveValue(customDataTypeName, 'maxChars', maxCharsValue)).toBeTruthy(); }); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/Tiptap.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/Tiptap.spec.ts index 650859289ee3..ceb6231434e9 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/Tiptap.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/Tiptap.spec.ts @@ -29,7 +29,8 @@ test('can create a rich text editor with tiptap', {tag: '@smoke'}, async ({umbra await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + //await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesNameExist(tipTapName)).toBeTruthy(); const dataTypeData = await umbracoApi.dataType.getByName(tipTapName); expect(dataTypeData.editorAlias).toBe(tipTapAlias); @@ -47,7 +48,8 @@ test('can rename a rich text editor with tiptap', async ({umbracoApi, umbracoUi} await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesNameExist(tipTapName)).toBeTruthy(); expect(await umbracoApi.dataType.doesNameExist(wrongName)).toBeFalsy(); }); @@ -62,7 +64,8 @@ test('can delete a rich text editor with tiptap', async ({umbracoApi, umbracoUi} await umbracoUi.dataType.clickDeleteAndConfirmButton(); // Assert - await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.deleted); + //await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.deleted); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesNameExist(tipTapName)).toBeFalsy(); await umbracoUi.dataType.isTreeItemVisible(tipTapName, false); }); @@ -79,7 +82,8 @@ test('can add dimensions', async ({umbracoApi, umbracoUi}) => { await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesRTEHaveDimensions(tipTapName, width, height)).toBeTruthy(); }); @@ -94,7 +98,8 @@ test('can update maximum size for inserted images', async ({umbracoApi, umbracoU await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesDataTypeHaveValue(tipTapName, 'maxImageSize', maximumSize)).toBeTruthy(); }); @@ -109,7 +114,8 @@ test('can select overlay size', async ({umbracoApi, umbracoUi}) => { await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesDataTypeHaveValue(tipTapName, 'overlaySize', overlaySizeValue)).toBeTruthy(); }); @@ -125,7 +131,8 @@ test('can add an available block', async ({umbracoApi, umbracoUi}) => { await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesRTEContainBlocks(tipTapName, [elementTypeId])).toBeTruthy(); // Clean @@ -144,7 +151,8 @@ test('can add image upload folder', async ({umbracoApi, umbracoUi}) => { await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesDataTypeHaveValue(tipTapName, 'mediaParentId', mediaFolderId)).toBeTruthy(); // Clean @@ -161,7 +169,8 @@ test('can enable ignore user start nodes', async ({umbracoApi, umbracoUi}) => { await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesDataTypeHaveValue(tipTapName, 'ignoreUserStartNodes', true)).toBeTruthy(); }); @@ -179,7 +188,8 @@ test('can delete toolbar group', async ({umbracoApi, umbracoUi}) => { await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.dataType.isErrorNotificationVisible(false); const tipTapData = await umbracoApi.dataType.getByName(tipTapName); const toolbarValue = tipTapData.values.find(value => value.alias === 'toolbar'); expect(toolbarValue.value[rowIndex].length).toBe(groupCount - 1); @@ -198,7 +208,8 @@ test('can delete toolbar row', async ({umbracoApi, umbracoUi}) => { await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.dataType.isErrorNotificationVisible(false); const tipTapData = await umbracoApi.dataType.getByName(tipTapName); const toolbarValue = tipTapData.values.find(value => value.alias === 'toolbar'); if (rowCount - 1 === 0) { @@ -220,7 +231,8 @@ test('can disable extensions item', async ({umbracoApi, umbracoUi}) => { await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.dataType.isErrorNotificationVisible(false); const tipTapData = await umbracoApi.dataType.getByName(tipTapName); const extensionsValue = tipTapData.values.find(value => value.alias === 'extensions'); expect(extensionsValue.value.length).toBe(extensionsCount - 1); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/TrueFalse.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/TrueFalse.spec.ts index 3803a2c8521e..3b03ffcaaca2 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/TrueFalse.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/TrueFalse.spec.ts @@ -26,7 +26,8 @@ test('can update preset value state', async ({umbracoApi, umbracoUi}) => { await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesDataTypeHaveValue(customDataTypeName, 'default', true)).toBeTruthy(); }); @@ -40,7 +41,8 @@ test('can update show toggle labels', async ({umbracoApi, umbracoUi}) => { await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesDataTypeHaveValue(customDataTypeName, 'showLabels', true)).toBeTruthy(); }); @@ -55,7 +57,8 @@ test('can update label on', async ({umbracoApi, umbracoUi}) => { await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesDataTypeHaveValue(customDataTypeName, 'labelOn', labelOnValue)).toBeTruthy(); }); @@ -70,7 +73,8 @@ test('can update label off', async ({umbracoApi, umbracoUi}) => { await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesDataTypeHaveValue(customDataTypeName, 'labelOff', labelOffValue)).toBeTruthy(); }); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/UploadField.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/UploadField.spec.ts index 6832691e5510..41b384a6c930 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/UploadField.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/UploadField.spec.ts @@ -33,7 +33,8 @@ test('can add accepted file extension', async ({ umbracoApi, umbracoUi }) => { await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.dataType.isErrorNotificationVisible(false); expect(await umbracoApi.dataType.doesDataTypeHaveValue(customDataTypeName, 'fileExtensions', [fileExtensionValue])).toBeTruthy(); }); @@ -48,7 +49,8 @@ test('can remove accepted file extension', async ({ umbracoApi, umbracoUi }) => await umbracoUi.dataType.clickSaveButton(); // Assert - await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.dataType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.dataType.isErrorNotificationVisible(false); const customDataTypeData = await umbracoApi.dataType.getByName(customDataTypeName); expect(customDataTypeData.values).toEqual([]); }); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Dictionary/Dictionary.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Dictionary/Dictionary.spec.ts index 28710ac5c151..bd3c06a9f293 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Dictionary/Dictionary.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Dictionary/Dictionary.spec.ts @@ -23,7 +23,8 @@ test('can create a dictionary item', async ({umbracoApi, umbracoUi}) => { await umbracoUi.dictionary.clickSaveButton(); // Assert - await umbracoUi.dictionary.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + //await umbracoUi.dictionary.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + await umbracoUi.dictionary.isErrorNotificationVisible(false); expect(await umbracoApi.dictionary.doesNameExist(dictionaryName)).toBeTruthy(); await umbracoUi.dictionary.clickLeftArrowButton(); // Verify the dictionary item displays in the tree and in the list @@ -43,7 +44,8 @@ test('can delete a dictionary item', async ({umbracoApi, umbracoUi}) => { await umbracoUi.dictionary.deleteDictionary(); // Assert - await umbracoUi.dictionary.doesSuccessNotificationHaveText(NotificationConstantHelper.success.deleted); + //await umbracoUi.dictionary.doesSuccessNotificationHaveText(NotificationConstantHelper.success.deleted); + await umbracoUi.dictionary.isErrorNotificationVisible(false); expect(await umbracoApi.dictionary.doesNameExist(dictionaryName)).toBeFalsy(); // Verify the dictionary item does not display in the tree await umbracoUi.dictionary.isDictionaryTreeItemVisible(dictionaryName, false); @@ -65,7 +67,8 @@ test('can create a dictionary item in a dictionary', {tag: '@smoke'}, async ({um await umbracoUi.dictionary.clickSaveButton(); // Assert - await umbracoUi.dictionary.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + //await umbracoUi.dictionary.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + await umbracoUi.dictionary.isErrorNotificationVisible(false); const dictionaryChildren = await umbracoApi.dictionary.getChildren(parentDictionaryId); expect(dictionaryChildren[0].name).toEqual(dictionaryName); await umbracoUi.dictionary.clickLeftArrowButton(); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Media/ListViewMedia.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Media/ListViewMedia.spec.ts index bf0af8415902..cf892483d60b 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Media/ListViewMedia.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Media/ListViewMedia.spec.ts @@ -105,7 +105,8 @@ test('can allow bulk trash in the media section', async ({umbracoApi, umbracoUi} await umbracoUi.media.clickConfirmTrashButton(); // Assert - await umbracoUi.media.isSuccessNotificationVisible(); + //await umbracoUi.media.isSuccessNotificationVisible(); + await umbracoUi.media.isErrorNotificationVisible(false); expect(await umbracoApi.media.doesNameExist(firstMediaFileName)).toBeFalsy(); expect(await umbracoApi.media.doesNameExist(secondMediaFileName)).toBeFalsy(); expect(await umbracoApi.media.doesMediaItemExistInRecycleBin(firstMediaFileName)).toBeTruthy(); @@ -131,7 +132,8 @@ test.fixme('can allow bulk move in the media section', async ({umbracoApi, umbra await umbracoUi.media.clickChooseModalButton(); // Assert - await umbracoUi.media.isSuccessNotificationVisible(); + //await umbracoUi.media.isSuccessNotificationVisible(); + await umbracoUi.media.isErrorNotificationVisible(false); expect(await umbracoApi.media.doesMediaItemHaveChildName(mediaFolderId, firstMediaFileName)).toBeTruthy(); expect(await umbracoApi.media.doesMediaItemHaveChildName(mediaFolderId, secondMediaFileName)).toBeTruthy(); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Media/Media.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Media/Media.spec.ts index 8e7f87816695..627e16b7ad12 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Media/Media.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Media/Media.spec.ts @@ -44,7 +44,8 @@ test('can rename a media file', async ({umbracoApi, umbracoUi}) => { await umbracoUi.media.clickSaveButton(); // Assert - await umbracoUi.media.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.media.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.media.isErrorNotificationVisible(false); await umbracoUi.media.isMediaTreeItemVisible(mediaFileName); expect(await umbracoApi.media.doesNameExist(mediaFileName)).toBeTruthy(); }); @@ -71,7 +72,8 @@ for (const mediaFileType of mediaFileTypes) { await umbracoUi.media.clickSaveButton(); // Assert - await umbracoUi.media.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + //await umbracoUi.media.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + await umbracoUi.media.isErrorNotificationVisible(false); const mediaData = await umbracoApi.media.getByName(mediaFileType.fileName); await umbracoUi.media.doesMediaHaveThumbnail(mediaData.id, mediaFileType.thumbnail, mediaData.urls[0].url); await umbracoUi.media.isMediaTreeItemVisible(mediaFileType.fileName); @@ -94,7 +96,8 @@ test('can create a folder', async ({umbracoApi, umbracoUi}) => { await umbracoUi.media.clickSaveButton(); // Assert - await umbracoUi.media.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + //await umbracoUi.media.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + await umbracoUi.media.isErrorNotificationVisible(false); await umbracoUi.media.isMediaTreeItemVisible(folderName); expect(await umbracoApi.media.doesNameExist(folderName)).toBeTruthy(); @@ -135,7 +138,8 @@ test('can create a folder in a folder', async ({umbracoApi, umbracoUi}) => { await umbracoUi.media.clickSaveButton(); // Assert - await umbracoUi.media.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + //await umbracoUi.media.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + await umbracoUi.media.isErrorNotificationVisible(false); await umbracoUi.media.isMediaTreeItemVisible(parentFolderName); await umbracoUi.media.isMediaTreeItemVisible(folderName, false); await umbracoUi.media.clickMediaCaretButtonForName(parentFolderName); @@ -221,7 +225,8 @@ test('can delete a media item from the recycle bin', async ({umbracoApi, umbraco await umbracoUi.media.deleteMediaItem(mediaFileName); // Assert - await umbracoUi.media.doesSuccessNotificationHaveText(NotificationConstantHelper.success.deleted); + //await umbracoUi.media.doesSuccessNotificationHaveText(NotificationConstantHelper.success.deleted); + await umbracoUi.media.isErrorNotificationVisible(false); await umbracoUi.media.isItemVisibleInRecycleBin(mediaFileName, false, false); expect(await umbracoApi.media.doesNameExist(mediaFileName)).toBeFalsy(); expect(await umbracoApi.media.doesMediaItemExistInRecycleBin(mediaFileName)).toBeFalsy(); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Members/MemberGroups.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Members/MemberGroups.spec.ts index c253aac05b98..ad603889fcaf 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Members/MemberGroups.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Members/MemberGroups.spec.ts @@ -20,7 +20,8 @@ test('can create a member group', {tag: '@smoke'}, async ({umbracoApi, umbracoUi await umbracoUi.memberGroup.clickSaveButton(); // Assert - await umbracoUi.memberGroup.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + //await umbracoUi.memberGroup.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + await umbracoUi.memberGroup.isErrorNotificationVisible(false); await umbracoUi.memberGroup.clickLeftArrowButton(); await umbracoUi.memberGroup.isMemberGroupNameVisible(memberGroupName); expect(await umbracoApi.memberGroup.doesNameExist(memberGroupName)).toBeTruthy(); @@ -62,7 +63,8 @@ test('can delete a member group', {tag: '@smoke'}, async ({umbracoApi, umbracoUi await umbracoUi.memberGroup.clickConfirmToDeleteButton(); // Assert - await umbracoUi.memberGroup.isSuccessNotificationVisible(); + //await umbracoUi.memberGroup.isSuccessNotificationVisible(); + await umbracoUi.memberGroup.isErrorNotificationVisible(false); await umbracoUi.memberGroup.isMemberGroupNameVisible(memberGroupName, false); expect(await umbracoApi.memberGroup.doesNameExist(memberGroupName)).toBeFalsy(); }); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Members/Members.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Members/Members.spec.ts index 1555986b1cac..d8d9540b2eda 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Members/Members.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Members/Members.spec.ts @@ -38,7 +38,8 @@ test('can create a member', {tag: '@smoke'}, async ({umbracoApi, umbracoUi}) => await umbracoUi.member.clickSaveButton(); // Assert - await umbracoUi.member.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + //await umbracoUi.member.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created) + await umbracoUi.member.isErrorNotificationVisible(false);; expect(await umbracoApi.member.doesNameExist(memberName)).toBeTruthy(); }); @@ -54,7 +55,8 @@ test('can edit comments', async ({umbracoApi, umbracoUi}) => { await umbracoUi.member.clickSaveButton(); // Assert - await umbracoUi.member.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.member.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved) + await umbracoUi.member.isErrorNotificationVisible(false);; const memberData = await umbracoApi.member.get(memberId); expect(memberData.values[0].value).toBe(comment); }); @@ -72,7 +74,8 @@ test('can edit username', async ({umbracoApi, umbracoUi}) => { await umbracoUi.member.clickSaveButton(); // Assert - await umbracoUi.member.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.member.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved) + await umbracoUi.member.isErrorNotificationVisible(false);; const memberData = await umbracoApi.member.get(memberId); expect(memberData.username).toBe(updatedUsername); }); @@ -90,7 +93,8 @@ test('can edit email', async ({umbracoApi, umbracoUi}) => { await umbracoUi.member.clickSaveButton(); // Assert - await umbracoUi.member.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.member.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved) + await umbracoUi.member.isErrorNotificationVisible(false);; const memberData = await umbracoApi.member.get(memberId); expect(memberData.email).toBe(updatedEmail); }); @@ -110,7 +114,8 @@ test('can edit password', {tag: '@smoke'}, async ({umbracoApi, umbracoUi}) => { await umbracoUi.member.clickSaveButton(); // Assert - await umbracoUi.member.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.member.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved) + await umbracoUi.member.isErrorNotificationVisible(false);; }); test('can add member group', {tag: '@smoke'}, async ({umbracoApi, umbracoUi}) => { @@ -128,7 +133,8 @@ test('can add member group', {tag: '@smoke'}, async ({umbracoApi, umbracoUi}) => await umbracoUi.member.clickSaveButton(); // Assert - await umbracoUi.member.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.member.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved) + await umbracoUi.member.isErrorNotificationVisible(false);; const memberData = await umbracoApi.member.get(memberId); expect(memberData.groups[0]).toBe(memberGroupId); @@ -152,7 +158,8 @@ test('can remove member group', async ({umbracoApi, umbracoUi}) => { await umbracoUi.member.clickSaveButton(); // Assert - await umbracoUi.member.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.member.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved) + await umbracoUi.member.isErrorNotificationVisible(false);; const memberData = await umbracoApi.member.get(memberId); expect(memberData.groups.length).toBe(0); @@ -196,7 +203,8 @@ test('can enable approved', async ({umbracoApi, umbracoUi}) => { await umbracoUi.member.clickSaveButton(); // Assert - await umbracoUi.member.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.member.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved) + await umbracoUi.member.isErrorNotificationVisible(false);; const memberData = await umbracoApi.member.get(memberId); expect(memberData.isApproved).toBe(true); }); @@ -214,7 +222,8 @@ test('can delete member', {tag: '@smoke'}, async ({umbracoApi, umbracoUi}) => { await umbracoUi.memberGroup.clickConfirmToDeleteButton(); // Assert - await umbracoUi.member.doesSuccessNotificationHaveText(NotificationConstantHelper.success.deleted); + //await umbracoUi.member.doesSuccessNotificationHaveText(NotificationConstantHelper.success.deleted) + await umbracoUi.member.isErrorNotificationVisible(false);; expect(await umbracoApi.member.doesNameExist(memberName)).toBeFalsy(); }); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/RelationTypes/RelationTypes.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/RelationTypes/RelationTypes.spec.ts index cd0fd93eb783..15bfcb710bb7 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/RelationTypes/RelationTypes.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/RelationTypes/RelationTypes.spec.ts @@ -28,7 +28,8 @@ test.skip('can create a relation type', async ({umbracoApi, umbracoUi}) => { await umbracoUi.relationType.clickSaveButton(); // Assert - await umbracoUi.relationType.isSuccessNotificationVisible(); + //await umbracoUi.relationType.isSuccessNotificationVisible(); + await umbracoUi.relationType.isErrorNotificationVisible(false); expect(await umbracoApi.relationType.doesNameExist(relationTypeName)).toBeTruthy(); // TODO: when frontend is ready, verify the new relation type name is displayed in the Relation Types tree }); @@ -45,7 +46,8 @@ test.skip('can update name of a relation type', async ({umbracoApi, umbracoUi}) await umbracoUi.relationType.clickSaveButton(); // Assert - await umbracoUi.relationType.isSuccessNotificationVisible(); + //await umbracoUi.relationType.isSuccessNotificationVisible(); + await umbracoUi.relationType.isErrorNotificationVisible(false); const relationTypeData = await umbracoApi.relationType.get(relationTypeId); expect(relationTypeData.name).toEqual(relationTypeName); expect(await umbracoApi.relationType.doesNameExist(wrongRelationTypeName)).toBeFalsy(); @@ -61,7 +63,8 @@ test.skip('can update direction value of a relation type', async ({umbracoApi, u await umbracoUi.relationType.clickSaveButton(); // Assert - await umbracoUi.relationType.isSuccessNotificationVisible(); + //await umbracoUi.relationType.isSuccessNotificationVisible(); + await umbracoUi.relationType.isErrorNotificationVisible(false); const relationTypeData = await umbracoApi.relationType.get(relationTypeId); expect(relationTypeData.isBidirectional).toEqual(true); }); @@ -77,7 +80,8 @@ test.skip('can update isDependency value of a relation type', async ({umbracoApi await umbracoUi.relationType.clickSaveButton(); // Assert - await umbracoUi.relationType.isSuccessNotificationVisible(); + //await umbracoUi.relationType.isSuccessNotificationVisible(); + await umbracoUi.relationType.isErrorNotificationVisible(false); const relationTypeData = await umbracoApi.relationType.get(relationTypeId); expect(relationTypeData.isDependency).toEqual(true); }); @@ -93,7 +97,8 @@ test.skip('can delete a relation type', async ({umbracoApi, umbracoUi}) => { await umbracoUi.relationType.clickConfirmToDeleteButton(); // Assert - await umbracoUi.relationType.isSuccessNotificationVisible(); + //await umbracoUi.relationType.isSuccessNotificationVisible(); + await umbracoUi.relationType.isErrorNotificationVisible(false); expect(await umbracoApi.relationType.doesNameExist(relationTypeName)).toBeFalsy(); // TODO: when frontend is ready, verify the deleted relation type name is NOT displayed in the Relation Types tree }); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/DocumentBlueprint/DocumentBlueprint.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/DocumentBlueprint/DocumentBlueprint.spec.ts index 67e5844fee18..ace79eaf6283 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/DocumentBlueprint/DocumentBlueprint.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/DocumentBlueprint/DocumentBlueprint.spec.ts @@ -29,7 +29,8 @@ test('can create a document blueprint from the settings menu', {tag: '@smoke'}, await umbracoUi.documentBlueprint.clickSaveButton(); // Assert - await umbracoUi.documentBlueprint.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + //await umbracoUi.documentBlueprint.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + await umbracoUi.documentBlueprint.isErrorNotificationVisible(false); expect(await umbracoApi.documentBlueprint.doesNameExist(documentBlueprintName)).toBeTruthy(); await umbracoUi.documentBlueprint.isDocumentBlueprintRootTreeItemVisible(documentBlueprintName, true); }); @@ -48,7 +49,8 @@ test('can rename a document blueprint', async ({umbracoApi, umbracoUi}) => { await umbracoUi.documentBlueprint.clickSaveButton(); // Assert - await umbracoUi.documentBlueprint.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.documentBlueprint.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.documentBlueprint.isErrorNotificationVisible(false); expect(await umbracoApi.documentBlueprint.doesNameExist(documentBlueprintName)).toBeTruthy(); expect(await umbracoApi.documentBlueprint.doesNameExist(wrongDocumentBlueprintName)).toBeFalsy(); await umbracoUi.documentBlueprint.isDocumentBlueprintRootTreeItemVisible(documentBlueprintName, true, false); @@ -68,7 +70,8 @@ test('can delete a document blueprint', async ({umbracoApi, umbracoUi}) => { await umbracoUi.documentBlueprint.clickConfirmToDeleteButton(); // Assert - await umbracoUi.documentBlueprint.doesSuccessNotificationHaveText(NotificationConstantHelper.success.deleted); + //await umbracoUi.documentBlueprint.doesSuccessNotificationHaveText(NotificationConstantHelper.success.deleted); + await umbracoUi.documentBlueprint.isErrorNotificationVisible(false); expect(await umbracoApi.documentBlueprint.doesNameExist(documentBlueprintName)).toBeFalsy(); await umbracoUi.documentBlueprint.isDocumentBlueprintRootTreeItemVisible(documentBlueprintName, false, false); }); @@ -86,7 +89,8 @@ test('can create a document blueprint from the content menu', async ({umbracoApi await umbracoUi.content.clickSaveModalButton(); // Assert - await umbracoUi.documentBlueprint.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + //await umbracoUi.documentBlueprint.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + await umbracoUi.documentBlueprint.isErrorNotificationVisible(false); expect(await umbracoApi.documentBlueprint.doesNameExist(documentBlueprintName)).toBeTruthy(); await umbracoUi.documentBlueprint.goToSettingsTreeItem('Document Blueprints'); await umbracoUi.documentBlueprint.isDocumentBlueprintRootTreeItemVisible(documentBlueprintName, true); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/DocumentType/DocumentType.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/DocumentType/DocumentType.spec.ts index 281969564da4..462eaba4d989 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/DocumentType/DocumentType.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/DocumentType/DocumentType.spec.ts @@ -24,7 +24,8 @@ test('can create a document type', {tag: '@smoke'}, async ({umbracoApi, umbracoU await umbracoUi.documentType.clickSaveButton(); // Assert - await umbracoUi.documentType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + //await umbracoUi.documentType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + await umbracoUi.documentType.isErrorNotificationVisible(false); expect(await umbracoApi.documentType.doesNameExist(documentTypeName)).toBeTruthy(); await umbracoUi.documentType.reloadTree('Document Types'); await umbracoUi.documentType.isDocumentTreeItemVisible(documentTypeName); @@ -44,7 +45,8 @@ test('can create a document type with a template', {tag: '@smoke'}, async ({umbr // Assert // Checks if both the success notification for document Types and the template are visible - await umbracoUi.documentType.doesSuccessNotificationsHaveCount(2); + //await umbracoUi.documentType.doesSuccessNotificationsHaveCount(2); + await umbracoUi.documentType.isErrorNotificationVisible(false); // Checks if the documentType contains the template const documentTypeData = await umbracoApi.documentType.getByName(documentTypeName); const templateData = await umbracoApi.template.getByName(documentTypeName); @@ -67,7 +69,8 @@ test('can create a element type', {tag: '@smoke'}, async ({umbracoApi, umbracoUi await umbracoUi.documentType.clickSaveButton(); // Assert - await umbracoUi.documentType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + //await umbracoUi.documentType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + await umbracoUi.documentType.isErrorNotificationVisible(false); expect(await umbracoApi.documentType.doesNameExist(documentTypeName)).toBeTruthy(); // Checks if the isElement is true const documentTypeData = await umbracoApi.documentType.getByName(documentTypeName); @@ -89,7 +92,8 @@ test('can rename a document type', {tag: '@smoke'}, async ({umbracoApi, umbracoU await umbracoUi.documentType.clickSaveButton(); // Assert - await umbracoUi.documentType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.documentType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.documentType.isErrorNotificationVisible(false); expect(await umbracoApi.documentType.doesNameExist(documentTypeName)).toBeTruthy(); await umbracoUi.documentType.isDocumentTreeItemVisible(wrongName, false); await umbracoUi.documentType.isDocumentTreeItemVisible(documentTypeName); @@ -110,7 +114,8 @@ test('can update the alias for a document type', async ({umbracoApi, umbracoUi}) await umbracoUi.documentType.clickSaveButton(); // Assert - await umbracoUi.documentType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.documentType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.documentType.isErrorNotificationVisible(false); await umbracoUi.documentType.isDocumentTreeItemVisible(documentTypeName, true); const documentTypeDataNew = await umbracoApi.documentType.getByName(documentTypeName); expect(documentTypeDataNew.alias).toBe(newAlias); @@ -129,7 +134,8 @@ test('can add an icon for a document type', {tag: '@smoke'}, async ({umbracoApi, await umbracoUi.documentType.clickSaveButton(); // Assert - await umbracoUi.documentType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.documentType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.documentType.isErrorNotificationVisible(false); const documentTypeData = await umbracoApi.documentType.getByName(documentTypeName); expect(documentTypeData.icon).toBe(bugIcon); await umbracoUi.documentType.isDocumentTreeItemVisible(documentTypeName, true); @@ -147,6 +153,7 @@ test('can delete a document type', {tag: '@smoke'}, async ({umbracoApi, umbracoU await umbracoUi.documentType.clickDeleteAndConfirmButton(); // Assert - await umbracoUi.documentType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.deleted); + //await umbracoUi.documentType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.deleted); + await umbracoUi.documentType.isErrorNotificationVisible(false); expect(await umbracoApi.documentType.doesNameExist(documentTypeName)).toBeFalsy(); }); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/DocumentType/DocumentTypeCollectionWorkspace.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/DocumentType/DocumentTypeCollectionWorkspace.spec.ts index 00decb84e60c..d5fdd190e17d 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/DocumentType/DocumentTypeCollectionWorkspace.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/DocumentType/DocumentTypeCollectionWorkspace.spec.ts @@ -26,7 +26,8 @@ test('can create a document type using create options', async ({umbracoApi, umbr await umbracoUi.documentType.clickSaveButton(); // Assert - await umbracoUi.documentType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + //await umbracoUi.documentType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + await umbracoUi.documentType.isErrorNotificationVisible(false); expect(await umbracoApi.documentType.doesNameExist(documentTypeName)).toBeTruthy(); // Check if the created document type is displayed in the collection view and has correct icon await umbracoUi.documentType.clickDocumentTypesMenu(); @@ -46,7 +47,8 @@ test('can create a document type with a template using create options', async ({ // Assert // Checks if both the success notification for document Types and the template are visible - await umbracoUi.documentType.doesSuccessNotificationsHaveCount(2); + //await umbracoUi.documentType.doesSuccessNotificationsHaveCount(2); + await umbracoUi.documentType.isErrorNotificationVisible(false); // Checks if the documentType contains the template const documentTypeData = await umbracoApi.documentType.getByName(documentTypeName); const templateData = await umbracoApi.template.getByName(documentTypeName); @@ -71,7 +73,8 @@ test('can create a element type using create options', async ({umbracoApi, umbra await umbracoUi.documentType.clickSaveButton(); // Assert - await umbracoUi.documentType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + //await umbracoUi.documentType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + await umbracoUi.documentType.isErrorNotificationVisible(false); expect(await umbracoApi.documentType.doesNameExist(documentTypeName)).toBeTruthy(); // Checks if the isElement is true const documentTypeData = await umbracoApi.documentType.getByName(documentTypeName); @@ -92,7 +95,8 @@ test('can create a document type folder using create options', async ({umbracoAp await umbracoUi.documentType.clickCreateFolderButton(); // Assert - await umbracoUi.documentType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + //await umbracoUi.documentType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + await umbracoUi.documentType.isErrorNotificationVisible(false); const folder = await umbracoApi.documentType.getByName(documentFolderName); expect(folder.name).toBe(documentFolderName); // Check if the created document type folder is displayed in the collection view and has correct icon @@ -112,7 +116,8 @@ test('can create a document type in a folder using create options', async ({umbr await umbracoUi.documentType.clickSaveButton(); // Assert - await umbracoUi.documentType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + //await umbracoUi.documentType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + await umbracoUi.documentType.isErrorNotificationVisible(false); expect(await umbracoApi.documentType.doesNameExist(documentTypeName)).toBeTruthy(); // Check if the created document type is displayed in the collection view and has correct icon await umbracoUi.documentType.goToDocumentType(documentFolderName); @@ -133,7 +138,8 @@ test('can create a document type with a template in a folder using create option // Assert // Checks if both the success notification for document Types and the template are visible - await umbracoUi.documentType.doesSuccessNotificationsHaveCount(2); + //await umbracoUi.documentType.doesSuccessNotificationsHaveCount(2); + await umbracoUi.documentType.isErrorNotificationVisible(false); // Checks if the documentType contains the template const documentTypeData = await umbracoApi.documentType.getByName(documentTypeName); const templateData = await umbracoApi.template.getByName(documentTypeName); @@ -159,7 +165,8 @@ test('can create a element type in a folder using create options', async ({umbra await umbracoUi.documentType.clickSaveButton(); // Assert - await umbracoUi.documentType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + //await umbracoUi.documentType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + await umbracoUi.documentType.isErrorNotificationVisible(false); expect(await umbracoApi.documentType.doesNameExist(documentTypeName)).toBeTruthy(); // Checks if the isElement is true const documentTypeData = await umbracoApi.documentType.getByName(documentTypeName); @@ -183,7 +190,8 @@ test('can create a document type folder in a folder using create options', async await umbracoUi.documentType.clickCreateFolderButton(); // Assert - await umbracoUi.documentType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + //await umbracoUi.documentType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + await umbracoUi.documentType.isErrorNotificationVisible(false); const folder = await umbracoApi.documentType.getByName(childFolderName); expect(folder.name).toBe(childFolderName); // Check if the created document type folder is displayed in the collection view and has correct icon diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/DocumentType/DocumentTypeDesignTab.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/DocumentType/DocumentTypeDesignTab.spec.ts index ce07c738c28d..26d8c5fd6a5d 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/DocumentType/DocumentTypeDesignTab.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/DocumentType/DocumentTypeDesignTab.spec.ts @@ -28,7 +28,8 @@ test('can add a property to a document type', {tag: '@smoke'}, async ({umbracoAp await umbracoUi.documentType.clickSaveButton(); // Assert - await umbracoUi.documentType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.documentType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.documentType.isErrorNotificationVisible(false); expect(await umbracoApi.documentType.doesNameExist(documentTypeName)).toBeTruthy(); const documentTypeData = await umbracoApi.documentType.getByName(documentTypeName); const dataType = await umbracoApi.dataType.getByName(dataTypeName); @@ -49,7 +50,8 @@ test('can update a property in a document type', {tag: '@smoke'}, async ({umbrac await umbracoUi.documentType.clickSaveButton(); // Assert - await umbracoUi.documentType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.documentType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.documentType.isErrorNotificationVisible(false); expect(await umbracoApi.documentType.doesNameExist(documentTypeName)).toBeTruthy(); const documentTypeData = await umbracoApi.documentType.getByName(documentTypeName); const dataType = await umbracoApi.dataType.getByName(newDataTypeName); @@ -70,7 +72,8 @@ test('can update group name in a document type', async ({umbracoApi, umbracoUi}) await umbracoUi.documentType.clickSaveButton(); // Assert - await umbracoUi.documentType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.documentType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.documentType.isErrorNotificationVisible(false); expect(await umbracoApi.documentType.doesNameExist(documentTypeName)).toBeTruthy(); const documentTypeData = await umbracoApi.documentType.getByName(documentTypeName); expect(documentTypeData.containers[0].name).toBe(newGroupName); @@ -89,7 +92,8 @@ test('can delete a group in a document type', {tag: '@smoke'}, async ({umbracoAp await umbracoUi.documentType.clickSaveButton(); // Assert - await umbracoUi.documentType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.documentType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.documentType.isErrorNotificationVisible(false); const documentTypeData = await umbracoApi.documentType.getByName(documentTypeName); expect(documentTypeData.containers.length).toBe(0); expect(documentTypeData.properties.length).toBe(0); @@ -108,7 +112,8 @@ test('can delete a tab in a document type', async ({umbracoApi, umbracoUi}) => { await umbracoUi.documentType.clickSaveButton(); // Assert - await umbracoUi.documentType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.documentType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.documentType.isErrorNotificationVisible(false); expect(await umbracoApi.documentType.doesNameExist(documentTypeName)).toBeTruthy(); const documentTypeData = await umbracoApi.documentType.getByName(documentTypeName); expect(documentTypeData.containers.length).toBe(0); @@ -126,7 +131,8 @@ test('can delete a property editor in a document type', {tag: '@smoke'}, async ( await umbracoUi.documentType.clickSaveButton(); // Assert - await umbracoUi.documentType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.documentType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.documentType.isErrorNotificationVisible(false); expect(await umbracoApi.documentType.doesNameExist(documentTypeName)).toBeTruthy(); const documentTypeData = await umbracoApi.documentType.getByName(documentTypeName); expect(documentTypeData.properties.length).toBe(0); @@ -147,7 +153,8 @@ test('can create a document type with a property in a tab', {tag: '@smoke'}, asy await umbracoUi.documentType.clickSaveButton(); // Assert - await umbracoUi.documentType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.documentType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.documentType.isErrorNotificationVisible(false); expect(await umbracoApi.documentType.doesNameExist(documentTypeName)).toBeTruthy(); const documentTypeData = await umbracoApi.documentType.getByName(documentTypeName); expect(await umbracoApi.documentType.doesTabContainCorrectPropertyEditorInGroup(documentTypeName, dataTypeName, documentTypeData.properties[0].dataType.id, tabName, groupName)).toBeTruthy(); @@ -170,7 +177,8 @@ test('can create a document type with multiple groups', async ({umbracoApi, umbr await umbracoUi.documentType.clickSaveButton(); // Assert - await umbracoUi.documentType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.documentType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.documentType.isErrorNotificationVisible(false); expect(await umbracoApi.documentType.doesNameExist(documentTypeName)).toBeTruthy(); expect(await umbracoApi.documentType.doesGroupContainCorrectPropertyEditor(documentTypeName, dataTypeName, dataTypeData.id, groupName)).toBeTruthy(); expect(await umbracoApi.documentType.doesGroupContainCorrectPropertyEditor(documentTypeName, secondDataTypeName, secondDataType.id, secondGroupName)).toBeTruthy(); @@ -196,7 +204,8 @@ test('can create a document type with multiple tabs', async ({umbracoApi, umbrac await umbracoUi.documentType.clickSaveButton(); // Assert - await umbracoUi.documentType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.documentType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.documentType.isErrorNotificationVisible(false); expect(await umbracoApi.documentType.doesNameExist(documentTypeName)).toBeTruthy(); expect(await umbracoApi.documentType.doesTabContainCorrectPropertyEditorInGroup(documentTypeName, dataTypeName, dataTypeData.id, tabName, groupName)).toBeTruthy(); expect(await umbracoApi.documentType.doesTabContainCorrectPropertyEditorInGroup(documentTypeName, secondDataTypeName, secondDataType.id, secondTabName, secondGroupName)).toBeTruthy(); @@ -220,7 +229,8 @@ test('can create a document type with a composition', {tag: '@smoke'}, async ({u await umbracoUi.documentType.clickSaveButton(); // Assert - await umbracoUi.documentType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.documentType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.documentType.isErrorNotificationVisible(false); expect(umbracoUi.documentType.doesGroupHaveValue(groupName)).toBeTruthy(); // Checks if the composition in the document type is correct const documentTypeData = await umbracoApi.documentType.getByName(documentTypeName); @@ -249,7 +259,8 @@ test('can remove a composition from a document type', async ({umbracoApi, umbrac await umbracoUi.documentType.clickSaveButton(); // Assert - await umbracoUi.documentType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.documentType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.documentType.isErrorNotificationVisible(false); await umbracoUi.documentType.isGroupVisible(groupName, false); const documentTypeData = await umbracoApi.documentType.getByName(documentTypeName); expect(documentTypeData.compositions).toEqual([]); @@ -275,7 +286,8 @@ test('can reorder groups in a document type', async ({umbracoApi, umbracoUi}) => await umbracoUi.documentType.clickSaveButton(); // Assert - await umbracoUi.documentType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.documentType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.documentType.isErrorNotificationVisible(false); // Since we swapped sorting order, the firstGroupValue should have sortOrder 1 and the secondGroupValue should have sortOrder 0 expect(await umbracoApi.documentType.doesDocumentTypeGroupNameContainCorrectSortOrder(documentTypeName, secondGroupValue, 0)).toBeTruthy(); expect(await umbracoApi.documentType.doesDocumentTypeGroupNameContainCorrectSortOrder(documentTypeName, firstGroupValue, 1)).toBeTruthy(); @@ -300,7 +312,8 @@ test.skip('can reorder properties in a document type', async ({umbracoApi, umbra await umbracoUi.documentType.clickSaveButton(); // Assert - await umbracoUi.documentType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.documentType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.documentType.isErrorNotificationVisible(false); const documentTypeData = await umbracoApi.documentType.getByName(documentTypeName); expect(documentTypeData.properties[0].name).toBe(dataTypeNameTwo); expect(documentTypeData.properties[1].name).toBe(dataTypeName); @@ -324,7 +337,8 @@ test.skip('can reorder tabs in a document type', {tag: '@smoke'}, async ({umbrac await umbracoUi.documentType.clickSaveButton(); // Assert - await umbracoUi.documentType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.documentType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.documentType.isErrorNotificationVisible(false); expect(await umbracoApi.documentType.doesDocumentTypeTabNameContainCorrectSortOrder(documentTypeName, secondTabName, 0)).toBeTruthy(); expect(await umbracoApi.documentType.doesDocumentTypeTabNameContainCorrectSortOrder(documentTypeName, tabName, 1)).toBeTruthy(); }); @@ -344,7 +358,8 @@ test('can add a description to a property in a document type', async ({umbracoAp await umbracoUi.documentType.clickSaveButton(); // Assert - await umbracoUi.documentType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.documentType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.documentType.isErrorNotificationVisible(false); await expect(umbracoUi.documentType.enterDescriptionTxt).toBeVisible(); expect(umbracoUi.documentType.doesDescriptionHaveValue(descriptionText)).toBeTruthy(); const documentTypeData = await umbracoApi.documentType.getByName(documentTypeName); @@ -365,7 +380,8 @@ test('can set is mandatory for a property in a document type', {tag: '@smoke'}, await umbracoUi.documentType.clickSaveButton(); // Assert - await umbracoUi.documentType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.documentType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.documentType.isErrorNotificationVisible(false); const documentTypeData = await umbracoApi.documentType.getByName(documentTypeName); expect(documentTypeData.properties[0].validation.mandatory).toBeTruthy(); }); @@ -388,7 +404,8 @@ test('can enable validation for a property in a document type', async ({umbracoA await umbracoUi.documentType.clickSaveButton(); // Assert - await umbracoUi.documentType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.documentType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.documentType.isErrorNotificationVisible(false); const documentTypeData = await umbracoApi.documentType.getByName(documentTypeName); expect(documentTypeData.properties[0].validation.regEx).toBe(regex); expect(documentTypeData.properties[0].validation.regExMessage).toBe(regexMessage); @@ -408,7 +425,8 @@ test('can allow vary by culture for a property in a document type', {tag: '@smok await umbracoUi.documentType.clickSaveButton(); // Assert - await umbracoUi.documentType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.documentType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.documentType.isErrorNotificationVisible(false); const documentTypeData = await umbracoApi.documentType.getByName(documentTypeName); expect(documentTypeData.properties[0].variesByCulture).toBeTruthy(); }); @@ -427,7 +445,8 @@ test('can set appearance to label on top for a property in a document type', asy await umbracoUi.documentType.clickSaveButton(); // Assert - await umbracoUi.documentType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.documentType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.documentType.isErrorNotificationVisible(false); const documentTypeData = await umbracoApi.documentType.getByName(documentTypeName); expect(documentTypeData.properties[0].appearance.labelOnTop).toBeTruthy(); }); @@ -447,7 +466,8 @@ test('can add a block list property with inline editing mode to a document type' await umbracoUi.documentType.clickSaveButton(); // Assert - await umbracoUi.documentType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.documentType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.documentType.isErrorNotificationVisible(false); expect(await umbracoApi.documentType.doesNameExist(documentTypeName)).toBeTruthy(); const documentTypeData = await umbracoApi.documentType.getByName(documentTypeName); const blockListDataTypeData = await umbracoApi.dataType.getByName(blockListDataTypeName); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/DocumentType/DocumentTypeFolder.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/DocumentType/DocumentTypeFolder.spec.ts index 2ea441b0fdaa..c7b2607aa6d0 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/DocumentType/DocumentTypeFolder.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/DocumentType/DocumentTypeFolder.spec.ts @@ -22,7 +22,8 @@ test('can create a empty document type folder', {tag: '@smoke'}, async ({umbraco await umbracoUi.documentType.clickCreateFolderButton(); // Assert - await umbracoUi.documentType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + //await umbracoUi.documentType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + await umbracoUi.documentType.isErrorNotificationVisible(false); const folder = await umbracoApi.documentType.getByName(documentFolderName); expect(folder.name).toBe(documentFolderName); // Checks if the folder is in the root @@ -41,7 +42,8 @@ test('can delete a document type folder', {tag: '@smoke'}, async ({umbracoApi, u await umbracoUi.documentType.deleteFolder(); // Assert - await umbracoUi.documentType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.deleted); + //await umbracoUi.documentType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.deleted); + await umbracoUi.documentType.isErrorNotificationVisible(false); await umbracoApi.documentType.doesNameExist(documentFolderName); await umbracoUi.documentType.isDocumentTreeItemVisible(documentFolderName, false); }); @@ -61,7 +63,8 @@ test('can rename a document type folder', async ({umbracoApi, umbracoUi}) => { await umbracoUi.documentType.clickConfirmRenameButton(); // Assert - await umbracoUi.documentType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.documentType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.documentType.isErrorNotificationVisible(false); const folder = await umbracoApi.documentType.getByName(documentFolderName); expect(folder.name).toBe(documentFolderName); await umbracoUi.documentType.isDocumentTreeItemVisible(oldFolderName, false); @@ -84,7 +87,8 @@ test('can create a document type folder in a folder', async ({umbracoApi, umbrac await umbracoUi.documentType.clickCreateFolderButton(); // Assert - await umbracoUi.documentType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + //await umbracoUi.documentType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + await umbracoUi.documentType.isErrorNotificationVisible(false); const folder = await umbracoApi.documentType.getByName(childFolderName); expect(folder.name).toBe(childFolderName); // Checks if the parentFolder contains the ChildFolder as a child @@ -115,7 +119,8 @@ test('can create a folder in a folder in a folder', {tag: '@smoke'}, async ({umb await umbracoUi.documentType.clickCreateFolderButton(); // Assert - await umbracoUi.documentType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + //await umbracoUi.documentType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + await umbracoUi.documentType.isErrorNotificationVisible(false); await umbracoUi.documentType.reloadTree(parentFolderName); await umbracoUi.documentType.isDocumentTreeItemVisible(documentFolderName); const grandParentChildren = await umbracoApi.documentType.getChildren(grandParentFolderId); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/DocumentType/DocumentTypeSettingsTab.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/DocumentType/DocumentTypeSettingsTab.spec.ts index 9d220a277f6c..cb90c9d6e6cf 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/DocumentType/DocumentTypeSettingsTab.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/DocumentType/DocumentTypeSettingsTab.spec.ts @@ -24,7 +24,8 @@ test('can add allow vary by culture for a document type', {tag: '@smoke'}, async await umbracoUi.documentType.clickSaveButton(); // Assert - await umbracoUi.documentType.isSuccessNotificationVisible(); + //await umbracoUi.documentType.isSuccessNotificationVisible(); + await umbracoUi.documentType.isErrorNotificationVisible(false); const documentTypeData = await umbracoApi.documentType.getByName(documentTypeName); expect(documentTypeData.variesByCulture).toBeTruthy(); }); @@ -41,7 +42,8 @@ test('can add allow segmentation for a document type', async ({umbracoApi, umbra await umbracoUi.documentType.clickSaveButton(); // Assert - await umbracoUi.documentType.isSuccessNotificationVisible(); + //await umbracoUi.documentType.isSuccessNotificationVisible(); + await umbracoUi.documentType.isErrorNotificationVisible(false); const documentTypeData = await umbracoApi.documentType.getByName(documentTypeName); expect(documentTypeData.variesBySegment).toBeTruthy(); }); @@ -58,7 +60,8 @@ test('can set is an element type for a document type', {tag: '@smoke'}, async ({ await umbracoUi.documentType.clickSaveButton(); // Assert - await umbracoUi.documentType.isSuccessNotificationVisible(); + //await umbracoUi.documentType.isSuccessNotificationVisible(); + await umbracoUi.documentType.isErrorNotificationVisible(false); const documentTypeData = await umbracoApi.documentType.getByName(documentTypeName); expect(documentTypeData.isElement).toBeTruthy(); }); @@ -76,7 +79,8 @@ test('can disable history cleanup for a document type', async ({umbracoApi, umbr await umbracoUi.documentType.clickSaveButton(); // Assert - await umbracoUi.documentType.isSuccessNotificationVisible(); + //await umbracoUi.documentType.isSuccessNotificationVisible(); + await umbracoUi.documentType.isErrorNotificationVisible(false); const documentTypeData = await umbracoApi.documentType.getByName(documentTypeName); expect(documentTypeData.cleanup.preventCleanup).toBeTruthy(); }); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/DocumentType/DocumentTypeStructureTab.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/DocumentType/DocumentTypeStructureTab.spec.ts index 2c307a7c2dfc..450d78e7c0a6 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/DocumentType/DocumentTypeStructureTab.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/DocumentType/DocumentTypeStructureTab.spec.ts @@ -24,7 +24,8 @@ test('can add allow as root to a document type', {tag: '@smoke'}, async ({umbrac await umbracoUi.documentType.clickSaveButton(); // Assert - await umbracoUi.documentType.isSuccessNotificationVisible(); + //await umbracoUi.documentType.isSuccessNotificationVisible(); + await umbracoUi.documentType.isErrorNotificationVisible(false); const documentTypeData = await umbracoApi.documentType.getByName(documentTypeName); expect(documentTypeData.allowedAsRoot).toBeTruthy(); }); @@ -43,7 +44,8 @@ test('can add an allowed child node to a document type', {tag: '@smoke'}, async await umbracoUi.documentType.clickSaveButton(); // Assert - await umbracoUi.documentType.isSuccessNotificationVisible(); + //await umbracoUi.documentType.isSuccessNotificationVisible(); + await umbracoUi.documentType.isErrorNotificationVisible(false); const documentTypeData = await umbracoApi.documentType.getByName(documentTypeName); expect(documentTypeData.allowedDocumentTypes[0].documentType.id).toBe(documentTypeData.id); }); @@ -64,7 +66,8 @@ test('can remove an allowed child node from a document type', async ({umbracoApi await umbracoUi.documentType.clickSaveButton(); // Assert - await umbracoUi.documentType.isSuccessNotificationVisible(); + //await umbracoUi.documentType.isSuccessNotificationVisible(); + await umbracoUi.documentType.isErrorNotificationVisible(false); const documentTypeData = await umbracoApi.documentType.getByName(documentTypeName); expect(documentTypeData.allowedDocumentTypes.length).toBe(0); @@ -88,7 +91,8 @@ test('can configure a collection for a document type', async ({umbracoApi, umbra await umbracoUi.documentType.clickSaveButton(); // Assert - await umbracoUi.documentType.isSuccessNotificationVisible(); + //await umbracoUi.documentType.isSuccessNotificationVisible(); + await umbracoUi.documentType.isErrorNotificationVisible(false); const documentTypeData = await umbracoApi.documentType.getByName(documentTypeName); expect(documentTypeData.collection.id).toEqual(collectionDataTypeId); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/DocumentType/DocumentTypeTemplatesTab.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/DocumentType/DocumentTypeTemplatesTab.spec.ts index 6ae35113f087..61b09cf17946 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/DocumentType/DocumentTypeTemplatesTab.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/DocumentType/DocumentTypeTemplatesTab.spec.ts @@ -31,7 +31,8 @@ test('can add an allowed template to a document type', {tag: '@smoke'}, async ({ await umbracoUi.documentType.clickSaveButton(); // Assert - await umbracoUi.documentType.isSuccessNotificationVisible(); + //await umbracoUi.documentType.isSuccessNotificationVisible(); + await umbracoUi.documentType.isErrorNotificationVisible(false); const documentTypeData = await umbracoApi.documentType.getByName(documentTypeName); expect(documentTypeData.allowedTemplates[0].id).toBe(templateId); }); @@ -51,7 +52,8 @@ test('can set an allowed template as default for document type', async ({umbraco await umbracoUi.documentType.clickSaveButton(); // Assert - await umbracoUi.documentType.isSuccessNotificationVisible(); + //await umbracoUi.documentType.isSuccessNotificationVisible(); + await umbracoUi.documentType.isErrorNotificationVisible(false); const documentTypeData = await umbracoApi.documentType.getByName(documentTypeName); expect(documentTypeData.allowedTemplates).toHaveLength(2); expect(documentTypeData.defaultTemplate.id).toBe(secondTemplateId); @@ -73,7 +75,8 @@ test.skip('can remove an allowed template from a document type', async ({umbraco await umbracoUi.documentType.clickSaveButton(); // Assert - await umbracoUi.documentType.isSuccessNotificationVisible(); + //await umbracoUi.documentType.isSuccessNotificationVisible(); + await umbracoUi.documentType.isErrorNotificationVisible(false); const documentTypeData = await umbracoApi.documentType.getByName(documentTypeName); expect(documentTypeData.allowedTemplates).toHaveLength(0); }); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/Language/Language.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/Language/Language.spec.ts index ab4f879935bb..8ef912adbddb 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/Language/Language.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/Language/Language.spec.ts @@ -25,7 +25,8 @@ test('can add language', {tag: '@smoke'}, async ({umbracoApi, umbracoUi}) => { await umbracoUi.language.clickSaveButton(); // Assert - await umbracoUi.language.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + //await umbracoUi.language.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + await umbracoUi.language.isErrorNotificationVisible(false); expect(await umbracoApi.language.doesExist(isoCode)).toBeTruthy(); // Verify the created language displays in the list await umbracoUi.language.clickLanguagesMenu(); @@ -44,7 +45,8 @@ test('can update default language option', {tag: '@smoke'}, async ({umbracoApi, await umbracoUi.language.clickSaveButton(); // Assert - await umbracoUi.language.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.language.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.language.isErrorNotificationVisible(false); const languageData = await umbracoApi.language.get(isoCode); expect(languageData.isDefault).toBe(true); @@ -67,7 +69,8 @@ test('can update mandatory language option', async ({umbracoApi, umbracoUi}) => await umbracoUi.language.clickSaveButton(); // Assert - await umbracoUi.language.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.language.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.language.isErrorNotificationVisible(false); const languageData = await umbracoApi.language.get(isoCode); expect(languageData.isMandatory).toBe(true); }); @@ -82,7 +85,8 @@ test('can delete language', {tag: '@smoke'}, async ({umbracoApi, umbracoUi}) => await umbracoUi.language.removeLanguageByName(languageName); // Assert - await umbracoUi.language.doesSuccessNotificationHaveText(NotificationConstantHelper.success.deleted); + //await umbracoUi.language.doesSuccessNotificationHaveText(NotificationConstantHelper.success.deleted); + await umbracoUi.language.isErrorNotificationVisible(false); expect(await umbracoApi.language.doesExist(isoCode)).toBeFalsy(); await umbracoUi.language.isLanguageNameVisible(languageName, false); }); @@ -99,7 +103,8 @@ test('can remove fallback language', async ({umbracoApi, umbracoUi}) => { await umbracoUi.language.clickSaveButton(); // Act - await umbracoUi.language.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.language.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.language.isErrorNotificationVisible(false); const languageData = await umbracoApi.language.get(isoCode); expect(languageData.fallbackIsoCode).toBeFalsy(); }); @@ -117,7 +122,8 @@ test('can add fallback language', async ({umbracoApi, umbracoUi}) => { await umbracoUi.language.clickSaveButton(); // Act - await umbracoUi.language.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.language.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.language.isErrorNotificationVisible(false); const languageData = await umbracoApi.language.get(isoCode); expect(languageData.fallbackIsoCode).toBe(defaultLanguageIsoCode); }); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/MediaType/MediaType.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/MediaType/MediaType.spec.ts index c1547ff0eee5..a617b95ae472 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/MediaType/MediaType.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/MediaType/MediaType.spec.ts @@ -22,7 +22,8 @@ test('can create a media type', {tag: '@smoke'}, async ({umbracoApi, umbracoUi}) await umbracoUi.mediaType.clickSaveButton(); // Assert - await umbracoUi.mediaType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + //await umbracoUi.mediaType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + await umbracoUi.mediaType.isErrorNotificationVisible(false); expect(await umbracoApi.mediaType.doesNameExist(mediaTypeName)).toBeTruthy(); }); @@ -38,7 +39,8 @@ test('can rename a media type', async ({umbracoApi, umbracoUi}) => { await umbracoUi.mediaType.clickSaveButton(); // Assert - await umbracoUi.mediaType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.mediaType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.mediaType.isErrorNotificationVisible(false); expect(await umbracoApi.mediaType.doesNameExist(mediaTypeName)).toBeTruthy(); }); @@ -56,7 +58,8 @@ test('can update the alias for a media type', async ({umbracoApi, umbracoUi}) => await umbracoUi.mediaType.clickSaveButton(); // Assert - await umbracoUi.mediaType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.mediaType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.mediaType.isErrorNotificationVisible(false); const mediaTypeData = await umbracoApi.mediaType.getByName(mediaTypeName); expect(mediaTypeData.alias).toBe(updatedAlias); }); @@ -73,7 +76,8 @@ test('can add an icon for a media type', {tag: '@smoke'}, async ({umbracoApi, um await umbracoUi.mediaType.clickSaveButton(); // Assert - await umbracoUi.mediaType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.mediaType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.mediaType.isErrorNotificationVisible(false); const mediaTypeData = await umbracoApi.mediaType.getByName(mediaTypeName); expect(mediaTypeData.icon).toBe(bugIcon); await umbracoUi.mediaType.isTreeItemVisible(mediaTypeName, true); @@ -90,6 +94,7 @@ test('can delete a media type', {tag: '@smoke'}, async ({umbracoApi, umbracoUi}) await umbracoUi.mediaType.clickConfirmToDeleteButton(); // Assert - await umbracoUi.mediaType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.deleted); + //await umbracoUi.mediaType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.deleted); + await umbracoUi.mediaType.isErrorNotificationVisible(false); expect(await umbracoApi.mediaType.doesNameExist(mediaTypeName)).toBeFalsy(); }); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/MediaType/MediaTypeCollectionWorkspace.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/MediaType/MediaTypeCollectionWorkspace.spec.ts index b0ae6fc5dc44..e26954b3c87f 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/MediaType/MediaTypeCollectionWorkspace.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/MediaType/MediaTypeCollectionWorkspace.spec.ts @@ -26,7 +26,8 @@ test('can create a media type using create options', async ({umbracoApi, umbraco await umbracoUi.mediaType.clickSaveButton(); // Assert - await umbracoUi.mediaType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + //await umbracoUi.mediaType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + await umbracoUi.mediaType.isErrorNotificationVisible(false); expect(await umbracoApi.mediaType.doesNameExist(mediaTypeName)).toBeTruthy(); // Check if the created media type is displayed in the collection view and has correct icon await umbracoUi.mediaType.clickMediaTypesMenu(); @@ -44,7 +45,8 @@ test('can create a media type folder using create options', async ({umbracoApi, await umbracoUi.mediaType.clickConfirmCreateFolderButton(); // Assert - await umbracoUi.mediaType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + //await umbracoUi.mediaType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + await umbracoUi.mediaType.isErrorNotificationVisible(false); expect(await umbracoApi.mediaType.doesNameExist(mediaTypeFolderName)).toBeTruthy(); // Check if the created media type is displayed in the collection view and has correct icon await umbracoUi.mediaType.clickMediaTypesMenu(); @@ -63,7 +65,8 @@ test('can create a media type in a folder using create options', async ({umbraco await umbracoUi.mediaType.clickSaveButton(); // Assert - await umbracoUi.mediaType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + //await umbracoUi.mediaType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + await umbracoUi.mediaType.isErrorNotificationVisible(false); expect(await umbracoApi.mediaType.doesNameExist(mediaTypeName)).toBeTruthy(); // Check if the created media type is displayed in the collection view and has correct icon await umbracoUi.mediaType.goToMediaType(mediaTypeFolderName); @@ -84,7 +87,8 @@ test('can create a media type folder in a folder using create options', async ({ await umbracoUi.mediaType.clickConfirmCreateFolderButton(); // Assert - await umbracoUi.mediaType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + //await umbracoUi.mediaType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + await umbracoUi.mediaType.isErrorNotificationVisible(false); expect(await umbracoApi.mediaType.doesNameExist(childFolderName)).toBeTruthy(); // Check if the created media type is displayed in the collection view and has correct icon await umbracoUi.mediaType.doesCollectionTreeItemTableRowHaveName(childFolderName); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/MediaType/MediaTypeDesignTab.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/MediaType/MediaTypeDesignTab.spec.ts index d5bf9e3d529f..db42e9accbb3 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/MediaType/MediaTypeDesignTab.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/MediaType/MediaTypeDesignTab.spec.ts @@ -28,7 +28,8 @@ test('can create a media type with a property', {tag: '@smoke'}, async ({umbraco await umbracoUi.mediaType.clickSaveButton(); // Assert - await umbracoUi.mediaType.isSuccessNotificationVisible(); + //await umbracoUi.mediaType.isSuccessNotificationVisible(); + await umbracoUi.mediaType.isErrorNotificationVisible(false); expect(await umbracoApi.mediaType.doesNameExist(mediaTypeName)).toBeTruthy(); const mediaTypeData = await umbracoApi.mediaType.getByName(mediaTypeName); const dataType = await umbracoApi.dataType.getByName(dataTypeName); @@ -48,7 +49,8 @@ test('can update a property in a media type', async ({umbracoApi, umbracoUi}) => await umbracoUi.mediaType.clickSaveButton(); // Assert - await umbracoUi.mediaType.isSuccessNotificationVisible(); + //await umbracoUi.mediaType.isSuccessNotificationVisible(); + await umbracoUi.mediaType.isErrorNotificationVisible(false); const mediaTypeData = await umbracoApi.mediaType.getByName(mediaTypeName); const dataType = await umbracoApi.dataType.getByName(newDataTypeName); // Checks if the correct property was added to the media type @@ -67,7 +69,8 @@ test('can update group name in a media type', async ({umbracoApi, umbracoUi}) => await umbracoUi.mediaType.clickSaveButton(); // Assert - await umbracoUi.mediaType.isSuccessNotificationVisible(); + //await umbracoUi.mediaType.isSuccessNotificationVisible(); + await umbracoUi.mediaType.isErrorNotificationVisible(false); const mediaTypeData = await umbracoApi.mediaType.getByName(mediaTypeName); expect(mediaTypeData.containers[0].name).toBe(updatedGroupName); }); @@ -83,7 +86,8 @@ test('can delete a property in a media type', async ({umbracoApi, umbracoUi}) => await umbracoUi.mediaType.clickSaveButton(); // Assert - await umbracoUi.mediaType.isSuccessNotificationVisible(); + //await umbracoUi.mediaType.isSuccessNotificationVisible(); + await umbracoUi.mediaType.isErrorNotificationVisible(false); const mediaTypeData = await umbracoApi.mediaType.getByName(mediaTypeName); expect(mediaTypeData.properties.length).toBe(0); }); @@ -102,7 +106,8 @@ test('can add a description to property in a media type', {tag: '@smoke'}, async await umbracoUi.mediaType.clickSaveButton(); // Assert - await umbracoUi.mediaType.isSuccessNotificationVisible(); + //await umbracoUi.mediaType.isSuccessNotificationVisible(); + await umbracoUi.mediaType.isErrorNotificationVisible(false); await expect(umbracoUi.mediaType.enterDescriptionTxt).toBeVisible(); expect(umbracoUi.mediaType.doesDescriptionHaveValue(descriptionText)).toBeTruthy(); const mediaTypeData = await umbracoApi.mediaType.getByName(mediaTypeName); @@ -122,7 +127,8 @@ test('can set a property as mandatory in a media type', {tag: '@smoke'}, async ( await umbracoUi.mediaType.clickSaveButton(); // Assert - await umbracoUi.mediaType.isSuccessNotificationVisible(); + //await umbracoUi.mediaType.isSuccessNotificationVisible(); + await umbracoUi.mediaType.isErrorNotificationVisible(false); const mediaTypeData = await umbracoApi.mediaType.getByName(mediaTypeName); expect(mediaTypeData.properties[0].validation.mandatory).toBeTruthy(); }); @@ -144,7 +150,8 @@ test('can set up validation for a property in a media type', async ({umbracoApi, await umbracoUi.mediaType.clickSaveButton(); // Assert - await umbracoUi.mediaType.isSuccessNotificationVisible(); + //await umbracoUi.mediaType.isSuccessNotificationVisible(); + await umbracoUi.mediaType.isErrorNotificationVisible(false); const mediaTypeData = await umbracoApi.mediaType.getByName(mediaTypeName); expect(mediaTypeData.properties[0].validation.regEx).toBe(regex); expect(mediaTypeData.properties[0].validation.regExMessage).toBe(regexMessage); @@ -163,7 +170,8 @@ test('can set appearance as label on top for property in a media type', async ({ await umbracoUi.mediaType.clickSaveButton(); // Assert - await umbracoUi.mediaType.isSuccessNotificationVisible(); + //await umbracoUi.mediaType.isSuccessNotificationVisible(); + await umbracoUi.mediaType.isErrorNotificationVisible(false); const mediaTypeData = await umbracoApi.mediaType.getByName(mediaTypeName); expect(mediaTypeData.properties[0].appearance.labelOnTop).toBeTruthy(); }); @@ -180,7 +188,8 @@ test('can delete a group in a media type', {tag: '@smoke'}, async ({umbracoApi, await umbracoUi.mediaType.clickSaveButton(); // Assert - await umbracoUi.mediaType.isSuccessNotificationVisible(); + //await umbracoUi.mediaType.isSuccessNotificationVisible(); + await umbracoUi.mediaType.isErrorNotificationVisible(false); const mediaTypeData = await umbracoApi.mediaType.getByName(mediaTypeName); expect(mediaTypeData.containers.length).toBe(0); expect(mediaTypeData.properties.length).toBe(0); @@ -198,7 +207,8 @@ test('can create a media type with a property in a tab', {tag: '@smoke'}, async await umbracoUi.mediaType.clickSaveButton(); // Assert - await umbracoUi.mediaType.isSuccessNotificationVisible(); + //await umbracoUi.mediaType.isSuccessNotificationVisible(); + await umbracoUi.mediaType.isErrorNotificationVisible(false); // Checks if the media type has the correct tab and property const mediaTypeData = await umbracoApi.mediaType.getByName(mediaTypeName); expect(await umbracoApi.mediaType.doesTabContainerCorrectPropertyEditor(mediaTypeName, tabName, mediaTypeData.properties[0].dataType.id)).toBeTruthy(); @@ -220,7 +230,8 @@ test('can create a media type with multiple groups', {tag: '@smoke'}, async ({um await umbracoUi.mediaType.clickSaveButton(); // Assert - await umbracoUi.mediaType.isSuccessNotificationVisible(); + //await umbracoUi.mediaType.isSuccessNotificationVisible(); + await umbracoUi.mediaType.isErrorNotificationVisible(false); expect(await umbracoApi.mediaType.doesNameExist(mediaTypeName)).toBeTruthy(); expect(await umbracoApi.mediaType.doesGroupContainCorrectPropertyEditor(mediaTypeName, dataTypeName, dataTypeData.id, groupName)).toBeTruthy(); expect(await umbracoApi.mediaType.doesGroupContainCorrectPropertyEditor(mediaTypeName, secondDataTypeName, secondDataType.id, secondGroupName)).toBeTruthy(); @@ -245,7 +256,8 @@ test('can create a media type with multiple tabs', async ({umbracoApi, umbracoUi await umbracoUi.mediaType.clickSaveButton(); // Assert - await umbracoUi.mediaType.isSuccessNotificationVisible(); + //await umbracoUi.mediaType.isSuccessNotificationVisible(); + await umbracoUi.mediaType.isErrorNotificationVisible(false); expect(await umbracoApi.mediaType.doesNameExist(mediaTypeName)).toBeTruthy(); expect(await umbracoApi.mediaType.doesTabContainCorrectPropertyEditorInGroup(mediaTypeName, dataTypeName, dataTypeData.id, tabName, groupName)).toBeTruthy(); expect(await umbracoApi.mediaType.doesTabContainCorrectPropertyEditorInGroup(mediaTypeName, secondDataTypeName, secondDataType.id, secondTabName, secondGroupName)).toBeTruthy(); @@ -263,7 +275,8 @@ test('can delete a tab from a media type', async ({umbracoApi, umbracoUi}) => { await umbracoUi.mediaType.clickSaveButton(); // Assert - await umbracoUi.mediaType.isSuccessNotificationVisible(); + //await umbracoUi.mediaType.isSuccessNotificationVisible(); + await umbracoUi.mediaType.isErrorNotificationVisible(false); expect(await umbracoApi.mediaType.doesNameExist(mediaTypeName)).toBeTruthy(); }); @@ -284,7 +297,8 @@ test('can create a media type with a composition', async ({umbracoApi, umbracoUi await umbracoUi.mediaType.clickSaveButton(); // Assert - await umbracoUi.mediaType.isSuccessNotificationVisible(); + //await umbracoUi.mediaType.isSuccessNotificationVisible(); + await umbracoUi.mediaType.isErrorNotificationVisible(false); expect(umbracoUi.mediaType.doesGroupHaveValue(groupName)).toBeTruthy(); // Checks if the composition in the media type is correct const mediaTypeData = await umbracoApi.mediaType.getByName(mediaTypeName); @@ -310,7 +324,8 @@ test('can reorder groups in a media type', async ({umbracoApi, umbracoUi}) => { await umbracoUi.mediaType.clickSaveButton(); // Assert - await umbracoUi.mediaType.isSuccessNotificationVisible(); + //await umbracoUi.mediaType.isSuccessNotificationVisible(); + await umbracoUi.mediaType.isErrorNotificationVisible(false); // Since we swapped sorting order, the firstGroupValue should have sortOrder 1 and the secondGroupValue should have sortOrder 0 expect(await umbracoApi.mediaType.doesMediaTypeGroupNameContainCorrectSortOrder(mediaTypeName, secondGroupValue, 0)).toBeTruthy(); expect(await umbracoApi.mediaType.doesMediaTypeGroupNameContainCorrectSortOrder(mediaTypeName, firstGroupValue, 1)).toBeTruthy(); @@ -333,7 +348,8 @@ test('can reorder properties in a media type', async ({umbracoApi, umbracoUi}) = await umbracoUi.mediaType.clickSaveButton(); // Assert - await umbracoUi.mediaType.isSuccessNotificationVisible(); + //await umbracoUi.mediaType.isSuccessNotificationVisible(); + await umbracoUi.mediaType.isErrorNotificationVisible(false); const mediaTypeData = await umbracoApi.mediaType.getByName(mediaTypeName); expect(mediaTypeData.properties[0].name).toBe(dataTypeNameTwo); }); @@ -355,7 +371,8 @@ test.skip('can reorder tabs in a media type', async ({umbracoApi, umbracoUi}) => await umbracoUi.mediaType.clickSaveButton(); // Assert - await umbracoUi.mediaType.isSuccessNotificationVisible(); + //await umbracoUi.mediaType.isSuccessNotificationVisible(); + await umbracoUi.mediaType.isErrorNotificationVisible(false); expect(await umbracoApi.mediaType.doesMediaTypeTabNameContainCorrectSortOrder(mediaTypeName, secondTabName, 0)).toBeTruthy(); expect(await umbracoApi.mediaType.doesMediaTypeTabNameContainCorrectSortOrder(mediaTypeName, tabName, 1)).toBeTruthy(); }); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/MediaType/MediaTypeFolder.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/MediaType/MediaTypeFolder.spec.ts index f05279eb9f76..24906d2ce45f 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/MediaType/MediaTypeFolder.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/MediaType/MediaTypeFolder.spec.ts @@ -22,7 +22,8 @@ test('can create a empty media type folder', async ({umbracoApi, umbracoUi}) => await umbracoUi.mediaType.clickConfirmCreateFolderButton(); // Assert - await umbracoUi.mediaType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + //await umbracoUi.mediaType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + await umbracoUi.mediaType.isErrorNotificationVisible(false); const folder = await umbracoApi.mediaType.getByName(mediaTypeFolderName); expect(folder.name).toBe(mediaTypeFolderName); // Checks if the folder is in the root @@ -40,7 +41,8 @@ test('can delete a media type folder', async ({umbracoApi, umbracoUi}) => { await umbracoUi.mediaType.deleteFolder(); // Assert - await umbracoUi.mediaType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.deleted); + //await umbracoUi.mediaType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.deleted); + await umbracoUi.mediaType.isErrorNotificationVisible(false); expect(await umbracoApi.mediaType.doesNameExist(mediaTypeFolderName)).toBeFalsy(); }); @@ -59,7 +61,8 @@ test('can rename a media type folder', async ({umbracoApi, umbracoUi}) => { await umbracoUi.mediaType.clickConfirmRenameButton(); // Assert - await umbracoUi.mediaType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.mediaType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.mediaType.isErrorNotificationVisible(false); const folder = await umbracoApi.mediaType.getByName(mediaTypeFolderName); expect(folder.name).toBe(mediaTypeFolderName); }); @@ -79,7 +82,8 @@ test('can create a media type folder in a folder', async ({umbracoApi, umbracoUi await umbracoUi.mediaType.clickConfirmCreateFolderButton(); // Assert - await umbracoUi.mediaType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + //await umbracoUi.mediaType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + await umbracoUi.mediaType.isErrorNotificationVisible(false); await umbracoUi.mediaType.clickCaretButtonForName(mediaTypeFolderName); await umbracoUi.mediaType.isTreeItemVisible(childFolderName, true); const parentFolderChildren = await umbracoApi.mediaType.getChildren(parentFolderId); @@ -108,7 +112,8 @@ test('can create a media type folder in a folder in a folder', async ({umbracoAp await umbracoUi.mediaType.clickConfirmCreateFolderButton(); // Assert - await umbracoUi.mediaType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + //await umbracoUi.mediaType.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + await umbracoUi.mediaType.isErrorNotificationVisible(false); await umbracoUi.mediaType.clickCaretButtonForName(mediaTypeFolderName); await umbracoUi.mediaType.isTreeItemVisible(childFolderName, true); const grandParentFolderChildren = await umbracoApi.mediaType.getChildren(grandParentFolderId); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/MediaType/MediaTypeStructureTab.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/MediaType/MediaTypeStructureTab.spec.ts index 920ba4f3d917..13d3ac2cfdf5 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/MediaType/MediaTypeStructureTab.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/MediaType/MediaTypeStructureTab.spec.ts @@ -24,7 +24,8 @@ test('can create a media type with allow at root enabled', {tag: '@smoke'}, asyn await umbracoUi.mediaType.clickSaveButton(); // Assert - await umbracoUi.mediaType.isSuccessNotificationVisible(); + //await umbracoUi.mediaType.isSuccessNotificationVisible(); + await umbracoUi.mediaType.isErrorNotificationVisible(false); const mediaTypeData = await umbracoApi.mediaType.getByName(mediaTypeName); expect(mediaTypeData.allowedAsRoot).toBeTruthy(); }); @@ -42,7 +43,8 @@ test('can create a media type with an allowed child node type', {tag: '@smoke'}, await umbracoUi.mediaType.clickSaveButton(); // Assert - await umbracoUi.mediaType.isSuccessNotificationVisible(); + //await umbracoUi.mediaType.isSuccessNotificationVisible(); + await umbracoUi.mediaType.isErrorNotificationVisible(false); const mediaTypeData = await umbracoApi.mediaType.getByName(mediaTypeName); expect(mediaTypeData.allowedMediaTypes[0].mediaType.id).toBe(mediaTypeData.id); }); @@ -64,7 +66,8 @@ test('can create a media type with multiple allowed child nodes types', async ({ await umbracoUi.mediaType.clickSaveButton(); // Assert - await umbracoUi.mediaType.isSuccessNotificationVisible(); + //await umbracoUi.mediaType.isSuccessNotificationVisible(); + await umbracoUi.mediaType.isErrorNotificationVisible(false); expect(await umbracoApi.mediaType.doesMediaTypeContainAllowedChildNodeIds(mediaTypeName, [mediaTypeId, secondMediaTypeId])).toBeTruthy(); // Clean @@ -86,7 +89,8 @@ test('can delete an allowed child note from a media type', {tag: '@smoke'}, asyn await umbracoUi.mediaType.clickSaveButton(); // Assert - await umbracoUi.mediaType.isSuccessNotificationVisible(); + //await umbracoUi.mediaType.isSuccessNotificationVisible(); + await umbracoUi.mediaType.isErrorNotificationVisible(false); const mediaTypeData = await umbracoApi.mediaType.getByName(childNodeName); expect(mediaTypeData.allowedMediaTypes.length).toBe(0); @@ -109,7 +113,8 @@ test('can configure a collection for a media type', async ({umbracoApi, umbracoU await umbracoUi.mediaType.clickSaveButton(); // Assert - await umbracoUi.mediaType.isSuccessNotificationVisible(); + //await umbracoUi.mediaType.isSuccessNotificationVisible(); + await umbracoUi.mediaType.isErrorNotificationVisible(false); const mediaTypeData = await umbracoApi.mediaType.getByName(mediaTypeName); expect(mediaTypeData.collection.id).toEqual(collectionDataTypeId); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/PartialView/PartialView.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/PartialView/PartialView.spec.ts index ff81a9899486..5dc7689bed78 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/PartialView/PartialView.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/PartialView/PartialView.spec.ts @@ -26,7 +26,8 @@ test('can create an empty partial view', {tag: '@smoke'}, async ({umbracoApi, um await umbracoUi.partialView.clickSaveButton(); // Assert - await umbracoUi.partialView.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + //await umbracoUi.partialView.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + await umbracoUi.partialView.isErrorNotificationVisible(false); expect(await umbracoApi.partialView.doesNameExist(partialViewFileName)).toBeTruthy(); // Verify the new partial view is displayed under the Partial Views section await umbracoUi.partialView.isPartialViewRootTreeItemVisible(partialViewFileName); @@ -46,7 +47,8 @@ test('can create a partial view from snippet', async ({umbracoApi, umbracoUi}) = await umbracoUi.partialView.clickSaveButton(); // Assert - await umbracoUi.partialView.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + //await umbracoUi.partialView.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + await umbracoUi.partialView.isErrorNotificationVisible(false); expect(await umbracoApi.partialView.doesExist(partialViewFileName)).toBeTruthy(); const partialViewData = await umbracoApi.partialView.getByName(partialViewFileName); @@ -106,7 +108,8 @@ test('can update a partial view content', {tag: '@smoke'}, async ({umbracoApi, u await umbracoUi.partialView.clickSaveButton(); // Assert - await umbracoUi.partialView.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.partialView.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.partialView.isErrorNotificationVisible(false); const updatedPartialView = await umbracoApi.partialView.getByName(partialViewFileName); expect(updatedPartialView.content).toBe(updatedPartialViewContent); }); @@ -146,7 +149,8 @@ test.fixme('can use query builder with Order By statement for a partial view', a await umbracoUi.partialView.clickSaveButton(); // Assert - await umbracoUi.partialView.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.partialView.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.partialView.isErrorNotificationVisible(false); const updatedPartialView = await umbracoApi.partialView.getByName(partialViewFileName); expect(updatedPartialView.content).toBe(expectedTemplateContent); }); @@ -187,7 +191,8 @@ test.fixme('can use query builder with Where statement for a partial view', asyn await umbracoUi.partialView.clickSaveButton(); // Assert - await umbracoUi.partialView.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.partialView.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.partialView.isErrorNotificationVisible(false); const updatedPartialView = await umbracoApi.partialView.getByName(partialViewFileName); expect(updatedPartialView.content).toBe(expectedTemplateContent); }); @@ -208,7 +213,8 @@ test('can insert dictionary item into a partial view', async ({umbracoApi, umbra await umbracoUi.partialView.clickSaveButton(); // Assert - await umbracoUi.partialView.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.partialView.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.partialView.isErrorNotificationVisible(false); const partialViewData = await umbracoApi.partialView.getByName(partialViewFileName); expect(partialViewData.content).toBe(partialViewContent); }); @@ -227,7 +233,8 @@ test('can insert value into a partial view', async ({umbracoApi, umbracoUi}) => await umbracoUi.template.clickSaveButton(); // Assert - await umbracoUi.partialView.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.partialView.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.partialView.isErrorNotificationVisible(false); const partialViewData = await umbracoApi.partialView.getByName(partialViewFileName); expect(partialViewData.content).toBe(partialViewContent); }); @@ -243,7 +250,8 @@ test('can delete a partial view', {tag: '@smoke'}, async ({umbracoApi, umbracoUi await umbracoUi.partialView.clickDeleteAndConfirmButton(); // Assert - await umbracoUi.partialView.doesSuccessNotificationHaveText(NotificationConstantHelper.success.deleted); + //await umbracoUi.partialView.doesSuccessNotificationHaveText(NotificationConstantHelper.success.deleted); + await umbracoUi.partialView.isErrorNotificationVisible(false); expect(await umbracoApi.partialView.doesExist(partialViewFileName)).toBeFalsy(); // Verify the partial view is NOT displayed under the Partial Views section await umbracoUi.partialView.clickRootFolderCaretButton(); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/PartialView/PartialViewFolder.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/PartialView/PartialViewFolder.spec.ts index 0709ede965d7..44e3e8621a12 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/PartialView/PartialViewFolder.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/PartialView/PartialViewFolder.spec.ts @@ -23,7 +23,8 @@ test('can create a folder', async ({umbracoApi, umbracoUi}) => { await umbracoUi.partialView.createPartialViewFolder(folderName); // Assert - await umbracoUi.partialView.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + //await umbracoUi.partialView.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + await umbracoUi.partialView.isErrorNotificationVisible(false); expect(await umbracoApi.partialView.doesFolderExist(folderName)).toBeTruthy(); // Verify the partial view folder is displayed under the Partial Views section await umbracoUi.partialView.clickRootFolderCaretButton(); @@ -42,7 +43,8 @@ test('can delete a folder', {tag: '@smoke'}, async ({umbracoApi, umbracoUi}) => await umbracoUi.partialView.deleteFolder(); // Assert - await umbracoUi.partialView.isSuccessNotificationVisible(); + //await umbracoUi.partialView.isSuccessNotificationVisible(); + await umbracoUi.partialView.isErrorNotificationVisible(false); expect(await umbracoApi.partialView.doesFolderExist(folderName)).toBeFalsy(); // Verify the partial view folder is NOT displayed under the Partial Views section await umbracoUi.partialView.clickRootFolderCaretButton(); @@ -65,7 +67,8 @@ test('can create a partial view in a folder', async ({umbracoApi, umbracoUi}) => await umbracoUi.partialView.clickSaveButton(); // Assert - await umbracoUi.partialView.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + //await umbracoUi.partialView.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + await umbracoUi.partialView.isErrorNotificationVisible(false); const childrenData = await umbracoApi.partialView.getChildren(folderPath); expect(childrenData[0].name).toEqual(partialViewFileName); // Verify the partial view is displayed in the folder under the Partial Views section @@ -94,7 +97,8 @@ test('can create a partial view in a folder in a folder', async ({umbracoApi, um await umbracoUi.partialView.clickSaveButton(); // Assert - await umbracoUi.partialView.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + //await umbracoUi.partialView.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + await umbracoUi.partialView.isErrorNotificationVisible(false); const childFolderChildrenData = await umbracoApi.partialView.getChildren(childFolderPath); expect(childFolderChildrenData[0].name).toEqual(partialViewFileName); @@ -114,7 +118,8 @@ test('can create a folder in a folder', async ({umbracoApi, umbracoUi}) => { await umbracoUi.partialView.createPartialViewFolder(childFolderName); // Assert - await umbracoUi.partialView.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + //await umbracoUi.partialView.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + await umbracoUi.partialView.isErrorNotificationVisible(false); expect(await umbracoApi.partialView.doesNameExist(childFolderName)).toBeTruthy(); const partialViewChildren = await umbracoApi.partialView.getChildren('/' + folderName); expect(partialViewChildren[0].path).toBe('/' + folderName + '/' + childFolderName); @@ -137,7 +142,8 @@ test('can create a folder in a folder in a folder', {tag: '@smoke'}, async ({umb await umbracoUi.partialView.createPartialViewFolder(childOfChildFolderName); // Assert - await umbracoUi.partialView.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + //await umbracoUi.partialView.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + await umbracoUi.partialView.isErrorNotificationVisible(false); expect(await umbracoApi.partialView.doesNameExist(childOfChildFolderName)).toBeTruthy(); const partialViewChildren = await umbracoApi.partialView.getChildren('/' + folderName + '/' + childFolderName); expect(partialViewChildren[0].path).toBe('/' + folderName + '/' + childFolderName + '/' + childOfChildFolderName); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/Script/Script.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/Script/Script.spec.ts index 902082cf196b..5c54224e061a 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/Script/Script.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/Script/Script.spec.ts @@ -25,7 +25,8 @@ test('can create a empty script', {tag: '@smoke'}, async ({umbracoApi, umbracoUi await umbracoUi.script.clickSaveButton(); // Assert - await umbracoUi.script.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + //await umbracoUi.script.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + await umbracoUi.script.isErrorNotificationVisible(false); expect(await umbracoApi.script.doesNameExist(scriptName)).toBeTruthy(); await umbracoUi.script.isScriptRootTreeItemVisible(scriptName); }); @@ -44,7 +45,8 @@ test('can create a script with content', async ({umbracoApi, umbracoUi}) => { await umbracoUi.script.clickSaveButton(); // Assert - await umbracoUi.script.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + //await umbracoUi.script.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + await umbracoUi.script.isErrorNotificationVisible(false); expect(await umbracoApi.script.doesNameExist(scriptName)).toBeTruthy(); const scriptData = await umbracoApi.script.getByName(scriptName); expect(scriptData.content).toBe(scriptContent); @@ -63,7 +65,8 @@ test('can update a script', {tag: '@smoke'}, async ({umbracoApi, umbracoUi}) => await umbracoUi.script.clickSaveButton(); // Assert - await umbracoUi.script.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.script.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.script.isErrorNotificationVisible(false); const updatedScript = await umbracoApi.script.get(scriptPath); expect(updatedScript.content).toBe(updatedScriptContent); }); @@ -79,7 +82,8 @@ test('can delete a script', {tag: '@smoke'}, async ({umbracoApi, umbracoUi}) => await umbracoUi.script.clickDeleteAndConfirmButton(); // Assert - await umbracoUi.script.doesSuccessNotificationHaveText(NotificationConstantHelper.success.deleted); + //await umbracoUi.script.doesSuccessNotificationHaveText(NotificationConstantHelper.success.deleted); + await umbracoUi.script.isErrorNotificationVisible(false); expect(await umbracoApi.script.doesNameExist(scriptName)).toBeFalsy(); await umbracoUi.script.isScriptRootTreeItemVisible(scriptName, false, false); }); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/Script/ScriptFolder.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/Script/ScriptFolder.spec.ts index df4ae1b5eb75..585cf679b66a 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/Script/ScriptFolder.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/Script/ScriptFolder.spec.ts @@ -22,7 +22,8 @@ test('can create a folder', {tag: '@smoke'}, async ({umbracoApi, umbracoUi}) => await umbracoUi.script.createScriptFolder(scriptFolderName); // Assert - await umbracoUi.script.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + //await umbracoUi.script.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + await umbracoUi.script.isErrorNotificationVisible(false); expect(await umbracoApi.script.doesFolderExist(scriptFolderName)).toBeTruthy(); await umbracoUi.script.isScriptRootTreeItemVisible(scriptFolderName); }); @@ -38,7 +39,8 @@ test('can delete a folder', {tag: '@smoke'}, async ({umbracoApi, umbracoUi}) => await umbracoUi.script.deleteFolder(); // Assert - await umbracoUi.script.doesSuccessNotificationHaveText(NotificationConstantHelper.success.deleted); + //await umbracoUi.script.doesSuccessNotificationHaveText(NotificationConstantHelper.success.deleted); + await umbracoUi.script.isErrorNotificationVisible(false); expect(await umbracoApi.script.doesFolderExist(scriptFolderName)).toBeFalsy(); await umbracoUi.script.isScriptRootTreeItemVisible(scriptFolderName, false, false); }); @@ -59,7 +61,8 @@ test('can create a script in a folder', async ({umbracoApi, umbracoUi}) => { await umbracoUi.script.clickSaveButton(); // Assert - await umbracoUi.script.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + //await umbracoUi.script.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + await umbracoUi.script.isErrorNotificationVisible(false); expect(await umbracoApi.script.doesNameExist(scriptName)).toBeTruthy(); const scriptChildren = await umbracoApi.script.getChildren('/' + scriptFolderName); expect(scriptChildren[0].path).toBe('/' + scriptFolderName + '/' + scriptName); @@ -81,7 +84,8 @@ test('can create a folder in a folder', async ({umbracoApi, umbracoUi}) => { await umbracoUi.script.createScriptFolder(childFolderName); // Assert - await umbracoUi.script.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + //await umbracoUi.script.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + await umbracoUi.script.isErrorNotificationVisible(false); expect(await umbracoApi.script.doesNameExist(childFolderName)).toBeTruthy(); const scriptChildren = await umbracoApi.script.getChildren('/' + scriptFolderName); expect(scriptChildren[0].path).toBe('/' + scriptFolderName + '/' + childFolderName); @@ -104,7 +108,8 @@ test('can create a folder in a folder in a folder', {tag: '@smoke'}, async ({umb await umbracoUi.script.createScriptFolder(childOfChildFolderName); // Assert - await umbracoUi.script.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + //await umbracoUi.script.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + await umbracoUi.script.isErrorNotificationVisible(false); expect(await umbracoApi.script.doesNameExist(childOfChildFolderName)).toBeTruthy(); const scriptChildren = await umbracoApi.script.getChildren('/' + scriptFolderName + '/' + childFolderName); expect(scriptChildren[0].path).toBe('/' + scriptFolderName + '/' + childFolderName + '/' + childOfChildFolderName); @@ -129,7 +134,8 @@ test('can create a script in a folder in a folder', async ({umbracoApi, umbracoU await umbracoUi.script.clickSaveButton(); // Assert - await umbracoUi.script.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + //await umbracoUi.script.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + await umbracoUi.script.isErrorNotificationVisible(false); expect(await umbracoApi.script.doesNameExist(scriptName)).toBeTruthy(); const scriptChildren = await umbracoApi.script.getChildren('/' + scriptFolderName + '/' + childFolderName); expect(scriptChildren[0].path).toBe('/' + scriptFolderName + '/' + childFolderName + '/' + scriptName); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/Stylesheet/Stylesheet.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/Stylesheet/Stylesheet.spec.ts index 4067e00d1e57..2faa8d232b25 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/Stylesheet/Stylesheet.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/Stylesheet/Stylesheet.spec.ts @@ -27,7 +27,8 @@ test('can create a empty stylesheet', {tag: '@smoke'}, async ({umbracoApi, umbra await umbracoUi.stylesheet.clickSaveButton(); // Assert - await umbracoUi.stylesheet.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + //await umbracoUi.stylesheet.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + await umbracoUi.stylesheet.isErrorNotificationVisible(false); expect(await umbracoApi.stylesheet.doesNameExist(stylesheetName)).toBeTruthy(); await umbracoUi.stylesheet.isStylesheetRootTreeItemVisible(stylesheetName); }); @@ -46,7 +47,8 @@ test('can create a stylesheet with content', async ({umbracoApi, umbracoUi}) => await umbracoUi.stylesheet.clickSaveButton(); // Assert - await umbracoUi.stylesheet.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + //await umbracoUi.stylesheet.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + await umbracoUi.stylesheet.isErrorNotificationVisible(false); expect(await umbracoApi.stylesheet.doesNameExist(stylesheetName)).toBeTruthy(); const stylesheetData = await umbracoApi.stylesheet.getByName(stylesheetName); expect(stylesheetData.content).toEqual(stylesheetContent); @@ -65,7 +67,8 @@ test.skip('can update a stylesheet', {tag: '@smoke'}, async ({umbracoApi, umbrac await umbracoUi.stylesheet.clickSaveButton(); // Assert - await umbracoUi.stylesheet.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.stylesheet.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.stylesheet.isErrorNotificationVisible(false); const stylesheetData = await umbracoApi.stylesheet.getByName(stylesheetName); expect(stylesheetData.content).toEqual(stylesheetContent); }); @@ -81,7 +84,8 @@ test('can delete a stylesheet', {tag: '@smoke'}, async ({umbracoApi, umbracoUi}) await umbracoUi.stylesheet.clickDeleteAndConfirmButton(); // Assert - await umbracoUi.stylesheet.doesSuccessNotificationHaveText(NotificationConstantHelper.success.deleted); + //await umbracoUi.stylesheet.doesSuccessNotificationHaveText(NotificationConstantHelper.success.deleted); + await umbracoUi.stylesheet.isErrorNotificationVisible(false); expect(await umbracoApi.stylesheet.doesNameExist(stylesheetName)).toBeFalsy(); await umbracoUi.stylesheet.isStylesheetRootTreeItemVisible(stylesheetName, false, false); }); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/Stylesheet/StylesheetFolder.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/Stylesheet/StylesheetFolder.spec.ts index 4c7e831c7225..50f414269b4b 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/Stylesheet/StylesheetFolder.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/Stylesheet/StylesheetFolder.spec.ts @@ -22,7 +22,8 @@ test('can create a folder', async ({umbracoApi, umbracoUi}) => { await umbracoUi.stylesheet.createStylesheetFolder(stylesheetFolderName); // Assert - await umbracoUi.stylesheet.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + //await umbracoUi.stylesheet.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + await umbracoUi.stylesheet.isErrorNotificationVisible(false); expect(await umbracoApi.stylesheet.doesFolderExist(stylesheetFolderName)).toBeTruthy(); await umbracoUi.stylesheet.isStylesheetRootTreeItemVisible(stylesheetFolderName); }); @@ -38,7 +39,8 @@ test('can delete a folder', {tag: '@smoke'}, async ({umbracoApi, umbracoUi}) => await umbracoUi.stylesheet.deleteFolder(); // Assert - await umbracoUi.stylesheet.doesSuccessNotificationHaveText(NotificationConstantHelper.success.deleted); + //await umbracoUi.stylesheet.doesSuccessNotificationHaveText(NotificationConstantHelper.success.deleted); + await umbracoUi.stylesheet.isErrorNotificationVisible(false); expect(await umbracoApi.stylesheet.doesFolderExist(stylesheetFolderName)).toBeFalsy(); await umbracoUi.stylesheet.isStylesheetRootTreeItemVisible(stylesheetFolderName, false, false); }); @@ -55,7 +57,8 @@ test('can create a folder in a folder', async ({umbracoApi, umbracoUi}) => { await umbracoUi.stylesheet.createStylesheetFolder(childFolderName); //Assert - await umbracoUi.stylesheet.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + //await umbracoUi.stylesheet.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + await umbracoUi.stylesheet.isErrorNotificationVisible(false); expect(await umbracoApi.stylesheet.doesNameExist(childFolderName)).toBeTruthy(); const styleChildren = await umbracoApi.stylesheet.getChildren('/' + stylesheetFolderName); expect(styleChildren[0].path).toBe('/' + stylesheetFolderName + '/' + childFolderName); @@ -78,7 +81,8 @@ test('can create a folder in a folder in a folder', {tag: '@smoke'}, async ({umb await umbracoUi.stylesheet.createStylesheetFolder(childOfChildFolderName); // Assert - await umbracoUi.stylesheet.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + //await umbracoUi.stylesheet.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + await umbracoUi.stylesheet.isErrorNotificationVisible(false); expect(await umbracoApi.stylesheet.doesNameExist(childOfChildFolderName)).toBeTruthy(); const styleChildren = await umbracoApi.stylesheet.getChildren('/' + stylesheetFolderName + '/' + childFolderName); expect(styleChildren[0].path).toBe('/' + stylesheetFolderName + '/' + childFolderName + '/' + childOfChildFolderName); @@ -102,7 +106,8 @@ test('can create a stylesheet in a folder', async ({umbracoApi, umbracoUi}) => { await umbracoUi.stylesheet.clickSaveButton(); // Assert - await umbracoUi.stylesheet.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + //await umbracoUi.stylesheet.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + await umbracoUi.stylesheet.isErrorNotificationVisible(false); expect(await umbracoApi.stylesheet.doesNameExist(stylesheetName)).toBeTruthy(); const stylesheetChildren = await umbracoApi.stylesheet.getChildren('/' + stylesheetFolderName); expect(stylesheetChildren[0].path).toBe('/' + stylesheetFolderName + '/' + stylesheetName); @@ -131,7 +136,8 @@ test('can create a stylesheet in a folder in a folder', async ({umbracoApi, umbr await umbracoUi.stylesheet.clickSaveButton(); // Assert - await umbracoUi.stylesheet.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + //await umbracoUi.stylesheet.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + await umbracoUi.stylesheet.isErrorNotificationVisible(false); expect(await umbracoApi.stylesheet.doesNameExist(stylesheetName)).toBeTruthy(); const stylesheetChildren = await umbracoApi.stylesheet.getChildren('/' + stylesheetFolderName + '/' + childFolderName); expect(stylesheetChildren[0].path).toBe('/' + stylesheetFolderName + '/' + childFolderName + '/' + stylesheetName); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/Template/Templates.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/Template/Templates.spec.ts index 0a19f29864da..171d879257ef 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/Template/Templates.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/Template/Templates.spec.ts @@ -24,7 +24,8 @@ test('can create a template', {tag: '@smoke'}, async ({umbracoApi, umbracoUi}) = await umbracoUi.template.clickSaveButton(); // Assert - await umbracoUi.template.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + //await umbracoUi.template.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + await umbracoUi.template.isErrorNotificationVisible(false); expect(await umbracoApi.template.doesNameExist(templateName)).toBeTruthy(); await umbracoUi.template.isTemplateRootTreeItemVisible(templateName); }); @@ -43,7 +44,8 @@ test('can update content of a template', {tag: '@smoke'}, async ({umbracoApi, um await umbracoUi.template.clickSaveButton(); // Assert - await umbracoUi.template.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.template.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.template.isErrorNotificationVisible(false); // Checks if the template was updated const updatedTemplate = await umbracoApi.template.getByName(templateName); expect(updatedTemplate.content).toBe(updatedTemplateContent); @@ -63,7 +65,8 @@ test('can rename a template', async ({umbracoApi, umbracoUi}) => { await umbracoUi.template.clickSaveButton(); // Assert - await umbracoUi.template.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.template.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.template.isErrorNotificationVisible(false); const templateData = await umbracoApi.template.get(templateId); expect(templateData.name).toBe(templateName); }); @@ -79,7 +82,8 @@ test('can delete a template', async ({umbracoApi, umbracoUi}) => { await umbracoUi.template.clickDeleteAndConfirmButton(); // Assert - await umbracoUi.template.doesSuccessNotificationHaveText(NotificationConstantHelper.success.deleted); + //await umbracoUi.template.doesSuccessNotificationHaveText(NotificationConstantHelper.success.deleted); + await umbracoUi.template.isErrorNotificationVisible(false); await umbracoUi.template.reloadTemplateTree(); expect(await umbracoApi.template.doesNameExist(templateName)).toBeFalsy(); await umbracoUi.template.isTemplateRootTreeItemVisible(templateName, false); @@ -100,7 +104,8 @@ test('can set a template as master template', async ({umbracoApi, umbracoUi}) => await umbracoUi.template.clickSaveButton(); // Assert - await umbracoUi.template.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.template.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.template.isErrorNotificationVisible(false); await umbracoUi.template.isMasterTemplateNameVisible(templateName); // Checks if the childTemplate has the masterTemplate set const childTemplateData = await umbracoApi.template.getByName(childTemplateName); @@ -127,7 +132,8 @@ test('can remove a master template', async ({umbracoApi, umbracoUi}) => { await umbracoUi.template.clickSaveButton(); // Assert - await umbracoUi.template.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.template.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.template.isErrorNotificationVisible(false); await umbracoUi.template.isMasterTemplateNameVisible('No master'); const childTemplate = await umbracoApi.template.getByName(childTemplateName); expect(childTemplate.masterTemplate).toBe(null); @@ -170,7 +176,8 @@ test.skip('can use query builder with Order By statement for a template', async await umbracoUi.template.clickSaveButton(); // Assert - await umbracoUi.template.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.template.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.template.isErrorNotificationVisible(false); const templateData = await umbracoApi.template.getByName(templateName); expect(templateData.content).toBe(expectedTemplateContent); }); @@ -210,7 +217,8 @@ test.fixme('can use query builder with Where statement for a template', async ({ await umbracoUi.template.clickSaveButton(); // Assert - await umbracoUi.template.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.template.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.template.isErrorNotificationVisible(false); const templateData = await umbracoApi.template.getByName(templateName); expect(templateData.content).toBe(expectedTemplateContent); }); @@ -228,7 +236,8 @@ test('can insert sections - render child template into a template', async ({umbr await umbracoUi.template.clickSaveButton(); // Assert - await umbracoUi.template.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.template.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.template.isErrorNotificationVisible(false); const templateData = await umbracoApi.template.getByName(templateName); expect(templateData.content).toBe(templateContent); }); @@ -247,7 +256,8 @@ test('can insert sections - render a named section into a template', async ({umb await umbracoUi.template.clickSaveButton(); // Assert - await umbracoUi.template.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.template.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.template.isErrorNotificationVisible(false); const templateData = await umbracoApi.template.getByName(templateName); expect(templateData.content).toBe(templateContent); }); @@ -266,7 +276,8 @@ test('can insert sections - define a named section into a template', async ({umb await umbracoUi.template.clickSaveButton(); // Assert - await umbracoUi.template.isSuccessNotificationVisible(); + //await umbracoUi.template.isSuccessNotificationVisible(); + await umbracoUi.template.isErrorNotificationVisible(false); const templateData = await umbracoApi.template.getByName(templateName); expect(templateData.content).toBe(templateContent); }); @@ -285,7 +296,8 @@ test('can insert dictionary item into a template', async ({umbracoApi, umbracoUi await umbracoUi.template.clickSaveButton(); // Assert - await umbracoUi.template.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.template.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.template.isErrorNotificationVisible(false); const templateData = await umbracoApi.template.getByName(templateName); expect(templateData.content).toBe(templateContent); @@ -308,7 +320,8 @@ test('can insert partial view into a template', async ({umbracoApi, umbracoUi}) await umbracoUi.template.clickSaveButton(); // Assert - await umbracoUi.template.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.template.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.template.isErrorNotificationVisible(false); const templateData = await umbracoApi.template.getByName(templateName); expect(templateData.content).toBe(templateContent); }); @@ -325,7 +338,8 @@ test('can insert value into a template', async ({umbracoApi, umbracoUi}) => { await umbracoUi.template.clickSaveButton(); // Assert - await umbracoUi.template.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.template.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.template.isErrorNotificationVisible(false); const templateData = await umbracoApi.template.getByName(templateName); expect(templateData.content).toBe(templateContent); }); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Users/Permissions/UserGroup/ContentWithTinyMCERichTextEditor.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Users/Permissions/UserGroup/ContentWithTinyMCERichTextEditor.spec.ts index 5912e61a020e..99eea41a1aa8 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Users/Permissions/UserGroup/ContentWithTinyMCERichTextEditor.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Users/Permissions/UserGroup/ContentWithTinyMCERichTextEditor.spec.ts @@ -45,6 +45,7 @@ test('can create content with a rich text editor that has a stylesheet', async ( await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + //await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(documentName)).toBeTruthy(); }); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Users/Permissions/UserGroup/DefaultPermissionsInContent.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Users/Permissions/UserGroup/DefaultPermissionsInContent.spec.ts index d3ac9aeadb00..8d822e8d430e 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Users/Permissions/UserGroup/DefaultPermissionsInContent.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Users/Permissions/UserGroup/DefaultPermissionsInContent.spec.ts @@ -193,7 +193,8 @@ test('can create content with create permission enabled', async ({umbracoApi, um await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + //await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + await umbracoUi.content.isErrorNotificationVisible(false); }); test('can not create content with create permission disabled', async ({umbracoApi, umbracoUi}) => { @@ -349,7 +350,8 @@ test('can update content with update permission enabled', async ({umbracoApi, um await umbracoUi.content.clickSaveButton(); // Assert - await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.content.isErrorNotificationVisible(false); expect(await umbracoApi.document.doesNameExist(testDocumentName)).toBeTruthy(); }); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Users/Permissions/UserGroup/Languages.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Users/Permissions/UserGroup/Languages.spec.ts index 2242683de900..4026dcb5051d 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Users/Permissions/UserGroup/Languages.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Users/Permissions/UserGroup/Languages.spec.ts @@ -80,7 +80,8 @@ test.fixme('can rename content with language set in userGroup', async ({umbracoA await umbracoUi.content.clickSaveAndCloseButton(); // Assert - await umbracoUi.userGroup.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.userGroup.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.userGroup.isErrorNotificationVisible(false); await umbracoUi.content.isContentInTreeVisible(updatedContentName); }); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Users/Permissions/UserGroup/MemberSection.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Users/Permissions/UserGroup/MemberSection.spec.ts index ebd1f6069931..220bd02395e7 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Users/Permissions/UserGroup/MemberSection.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Users/Permissions/UserGroup/MemberSection.spec.ts @@ -69,7 +69,8 @@ test.skip('can create member with members section set', async ({umbracoApi, umbr await umbracoUi.member.clickSaveButton(); // Assert - await umbracoUi.member.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + //await umbracoUi.member.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created) + await umbracoUi.member.isErrorNotificationVisible(false);; await umbracoUi.member.doesErrorNotificationHaveText(NotificationConstantHelper.error.noAccessToResource, false); expect(await umbracoApi.member.doesNameExist(memberName)).toBeTruthy(); }); @@ -92,7 +93,8 @@ test.skip('can update member with members section set', async ({umbracoApi, umbr await umbracoUi.member.clickSaveButton(); // Assert - await umbracoUi.member.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.member.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved) + await umbracoUi.member.isErrorNotificationVisible(false);; await umbracoUi.member.doesErrorNotificationHaveText(NotificationConstantHelper.error.noAccessToResource, false); const memberData = await umbracoApi.member.get(memberId); expect(memberData.username).toBe(updatedUsername); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Users/User.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Users/User.spec.ts index 85b103634dcb..dc174629ab4d 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Users/User.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Users/User.spec.ts @@ -32,7 +32,8 @@ test('can create a user', {tag: '@smoke'}, async ({umbracoApi, umbracoUi}) => { await umbracoUi.user.clickCreateUserButton(); // Assert - await umbracoUi.user.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + //await umbracoUi.user.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + await umbracoUi.user.isErrorNotificationVisible(false); expect(await umbracoApi.user.doesNameExist(nameOfTheUser)).toBeTruthy(); }); @@ -50,7 +51,8 @@ test('can rename a user', async ({umbracoApi, umbracoUi}) => { await umbracoUi.user.clickSaveButton(); // Assert - await umbracoUi.user.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.user.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.user.isErrorNotificationVisible(false); expect(await umbracoApi.user.doesNameExist(nameOfTheUser)).toBeTruthy(); }); @@ -67,7 +69,8 @@ test('can delete a user', {tag: '@smoke'}, async ({umbracoApi, umbracoUi}) => { await umbracoUi.user.clickConfirmToDeleteButton(); // Assert - await umbracoUi.user.doesSuccessNotificationHaveText(NotificationConstantHelper.success.deleted); + //await umbracoUi.user.doesSuccessNotificationHaveText(NotificationConstantHelper.success.deleted); + await umbracoUi.user.isErrorNotificationVisible(false); expect(await umbracoApi.user.doesNameExist(nameOfTheUser)).toBeFalsy(); // Checks if the user is deleted from the list await umbracoUi.user.clickUsersMenu(); @@ -90,7 +93,8 @@ test('can add multiple user groups to a user', async ({umbracoApi, umbracoUi}) = await umbracoUi.user.clickSaveButton(); // Assert - await umbracoUi.user.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.user.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.user.isErrorNotificationVisible(false); expect(await umbracoApi.user.doesUserContainUserGroupIds(nameOfTheUser, [userGroupWriters.id, userGroupTranslators.id])).toBeTruthy(); }); @@ -107,7 +111,8 @@ test('can remove a user group from a user', {tag: '@smoke'}, async ({umbracoApi, await umbracoUi.user.clickSaveButton(); // Assert - await umbracoUi.user.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.user.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.user.isErrorNotificationVisible(false); const userData = await umbracoApi.user.getByName(nameOfTheUser); expect(userData.userGroupIds).toEqual([]); }); @@ -125,7 +130,8 @@ test('can update culture for a user', async ({umbracoApi, umbracoUi}) => { await umbracoUi.user.clickSaveButton(); // Assert - await umbracoUi.user.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.user.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.user.isErrorNotificationVisible(false); const userData = await umbracoApi.user.getByName(nameOfTheUser); expect(userData.languageIsoCode).toEqual(danishIsoCode); }); @@ -150,7 +156,8 @@ test('can add a content start node to a user', {tag: '@smoke'}, async ({umbracoA await umbracoUi.user.clickSaveButton(); // Assert - await umbracoUi.user.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.user.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.user.isErrorNotificationVisible(false); expect(await umbracoApi.user.doesUserContainContentStartNodeIds(nameOfTheUser, [documentId])).toBeTruthy(); // Clean @@ -185,7 +192,8 @@ test('can add multiple content start nodes for a user', async ({umbracoApi, umbr await umbracoUi.user.clickSaveButton(); // Assert - await umbracoUi.user.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.user.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.user.isErrorNotificationVisible(false); expect(await umbracoApi.user.doesUserContainContentStartNodeIds(nameOfTheUser, [documentId, secondDocumentId])).toBeTruthy(); // Clean @@ -218,7 +226,8 @@ test('can remove a content start node from a user', {tag: '@smoke'}, async ({umb await umbracoUi.user.clickSaveButton(); // Assert - await umbracoUi.user.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.user.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.user.isErrorNotificationVisible(false); expect(await umbracoApi.user.doesUserContainContentStartNodeIds(nameOfTheUser, [documentId])).toBeFalsy(); // Clean @@ -243,7 +252,8 @@ test('can add media start nodes for a user', {tag: '@smoke'}, async ({umbracoApi await umbracoUi.user.clickSaveButton(); // Assert - await umbracoUi.user.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.user.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.user.isErrorNotificationVisible(false); expect(await umbracoApi.user.doesUserContainMediaStartNodeIds(nameOfTheUser, [mediaId])).toBeTruthy(); // Clean @@ -275,7 +285,8 @@ test('can add multiple media start nodes for a user', async ({umbracoApi, umbrac await umbracoUi.user.clickSaveButton(); // Assert - await umbracoUi.user.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.user.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.user.isErrorNotificationVisible(false); expect(await umbracoApi.user.doesUserContainMediaStartNodeIds(nameOfTheUser, [firstMediaId, secondMediaId])).toBeTruthy(); // Clean @@ -304,7 +315,8 @@ test('can remove a media start node from a user', async ({umbracoApi, umbracoUi} await umbracoUi.user.clickSaveButton(); // Assert - await umbracoUi.user.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.user.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.user.isErrorNotificationVisible(false); expect(await umbracoApi.user.doesUserContainMediaStartNodeIds(nameOfTheUser, [mediaId])).toBeFalsy(); // Clean @@ -323,7 +335,8 @@ test('can allow access to all documents for a user', async ({umbracoApi, umbraco await umbracoUi.user.clickSaveButton(); // Assert - await umbracoUi.user.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.user.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.user.isErrorNotificationVisible(false); const userData = await umbracoApi.user.getByName(nameOfTheUser); expect(userData.hasDocumentRootAccess).toBeTruthy() }); @@ -340,7 +353,8 @@ test('can allow access to all media for a user', async ({umbracoApi, umbracoUi}) await umbracoUi.user.clickSaveButton(); // Assert - await umbracoUi.user.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.user.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.user.isErrorNotificationVisible(false); const userData = await umbracoApi.user.getByName(nameOfTheUser); expect(userData.hasMediaRootAccess).toBeTruthy(); }); diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Users/UserGroups.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Users/UserGroups.spec.ts index c52f5ed27b65..a2ac69290f91 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Users/UserGroups.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Users/UserGroups.spec.ts @@ -59,7 +59,8 @@ test('can create an empty user group', async ({umbracoApi, umbracoUi}) => { await umbracoUi.userGroup.clickSaveButton(); // Assert - await umbracoUi.userGroup.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + //await umbracoUi.userGroup.doesSuccessNotificationHaveText(NotificationConstantHelper.success.created); + await umbracoUi.userGroup.isErrorNotificationVisible(false); expect(await umbracoApi.userGroup.doesNameExist(userGroupName)).toBeTruthy(); // Checks if the user group was created in the UI as well await umbracoUi.userGroup.clickUserGroupsButton(); @@ -79,7 +80,8 @@ test('can rename a user group', async ({umbracoApi, umbracoUi}) => { await umbracoUi.userGroup.clickSaveButton(); // Assert - await umbracoUi.userGroup.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.userGroup.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.userGroup.isErrorNotificationVisible(false); expect(await umbracoApi.userGroup.doesNameExist(userGroupName)).toBeTruthy(); // Checks if the user group was created in the UI as well await umbracoUi.userGroup.clickUserGroupsButton(); @@ -98,7 +100,8 @@ test('can update a user group', async ({umbracoApi, umbracoUi}) => { await umbracoUi.userGroup.clickSaveButton(); // Assert - await umbracoUi.userGroup.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.userGroup.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.userGroup.isErrorNotificationVisible(false); await umbracoUi.reloadPage(); await umbracoUi.userGroup.doesUserGroupHavePermission(allPermissions.uiPermission[0]); const userGroupData = await umbracoApi.userGroup.getByName(userGroupName); @@ -117,7 +120,8 @@ test('can delete a user group', async ({umbracoApi, umbracoUi}) => { await umbracoUi.userGroup.clickConfirmToDeleteButton(); // Assert - await umbracoUi.userGroup.doesSuccessNotificationHaveText(NotificationConstantHelper.success.deleted); + //await umbracoUi.userGroup.doesSuccessNotificationHaveText(NotificationConstantHelper.success.deleted); + await umbracoUi.userGroup.isErrorNotificationVisible(false); expect(await umbracoApi.userGroup.doesNameExist(userGroupName)).toBeFalsy(); await umbracoUi.userGroup.clickUserGroupsButton(); await umbracoUi.userGroup.isUserGroupWithNameVisible(userGroupName, false); @@ -134,7 +138,8 @@ test('can add a section to a user group', async ({umbracoApi, umbracoUi}) => { await umbracoUi.userGroup.clickSaveButton(); // Assert - await umbracoUi.userGroup.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.userGroup.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.userGroup.isErrorNotificationVisible(false); await umbracoUi.userGroup.clickUserGroupsButton(); await umbracoUi.userGroup.doesUserGroupTableHaveSection(userGroupName, 'Content'); }) @@ -150,7 +155,8 @@ test('can add multiple sections to a user group', async ({umbracoApi, umbracoUi} await umbracoUi.userGroup.clickSaveButton(); // Assert - await umbracoUi.userGroup.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.userGroup.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.userGroup.isErrorNotificationVisible(false); await umbracoUi.userGroup.clickUserGroupsButton(); await umbracoUi.userGroup.doesUserGroupTableHaveSection(userGroupName, 'Content'); await umbracoUi.userGroup.doesUserGroupTableHaveSection(userGroupName, 'Media'); @@ -168,7 +174,8 @@ test('can remove a section from a user group', async ({umbracoApi, umbracoUi}) = await umbracoUi.userGroup.clickSaveButton(); // Assert - await umbracoUi.userGroup.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.userGroup.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.userGroup.isErrorNotificationVisible(false); await umbracoUi.userGroup.clickUserGroupsButton(); await umbracoUi.userGroup.doesUserGroupTableHaveSection(userGroupName, 'Content', false); const userGroupData = await umbracoApi.userGroup.getByName(userGroupName); @@ -186,7 +193,8 @@ test('can add a language to a user group', async ({umbracoApi, umbracoUi}) => { await umbracoUi.userGroup.clickSaveButton(); // Assert - await umbracoUi.userGroup.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.userGroup.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.userGroup.isErrorNotificationVisible(false); await umbracoUi.reloadPage(); await umbracoUi.userGroup.doesUserGroupContainLanguage(englishLanguage); expect(await umbracoApi.userGroup.doesUserGroupContainLanguage(userGroupName, 'en-US')).toBeTruthy(); @@ -203,7 +211,8 @@ test('can enable all languages for a user group', async ({umbracoApi, umbracoUi} await umbracoUi.userGroup.clickSaveButton(); // Assert - await umbracoUi.userGroup.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.userGroup.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.userGroup.isErrorNotificationVisible(false); expect(await umbracoApi.userGroup.doesUserGroupContainAccessToAllLanguages(userGroupName)).toBeTruthy(); }) @@ -221,7 +230,8 @@ test('can add multiple languages to a user group', async ({umbracoApi, umbracoUi await umbracoUi.userGroup.clickSaveButton(); // Assert - await umbracoUi.userGroup.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.userGroup.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.userGroup.isErrorNotificationVisible(false); await umbracoUi.reloadPage(); await umbracoUi.userGroup.doesUserGroupContainLanguage(englishLanguage); await umbracoUi.userGroup.doesUserGroupContainLanguage(danishLanguage); @@ -245,7 +255,8 @@ test('can remove language from a user group', async ({umbracoApi, umbracoUi}) => await umbracoUi.userGroup.clickSaveButton(); // Assert - await umbracoUi.userGroup.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.userGroup.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.userGroup.isErrorNotificationVisible(false); await umbracoUi.reloadPage(); await umbracoUi.userGroup.doesUserGroupContainLanguage(englishLanguage, false); expect(await umbracoApi.userGroup.doesUserGroupContainLanguage(userGroupName, 'en-US')).toBeFalsy(); @@ -269,7 +280,8 @@ test('can add a content start node to a user group', async ({umbracoApi, umbraco await umbracoUi.userGroup.clickSaveButton(); // Assert - await umbracoUi.userGroup.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.userGroup.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.userGroup.isErrorNotificationVisible(false); expect(await umbracoApi.userGroup.doesUserGroupContainContentStartNodeId(userGroupName, documentId)).toBeTruthy(); // Clean @@ -294,7 +306,8 @@ test('can remove a content start node from a user group ', async ({umbracoApi, u await umbracoUi.userGroup.clickSaveButton(); // Assert - await umbracoUi.userGroup.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.userGroup.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.userGroup.isErrorNotificationVisible(false); expect(await umbracoApi.userGroup.doesUserGroupContainContentStartNodeId(userGroupName, documentId)).toBeFalsy(); // Clean @@ -312,7 +325,8 @@ test('can enable access to all content from a user group ', async ({umbracoApi, await umbracoUi.userGroup.clickSaveButton(); // Assert - await umbracoUi.userGroup.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.userGroup.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.userGroup.isErrorNotificationVisible(false); expect(await umbracoApi.userGroup.doesUserGroupContainDocumentRootAccess(userGroupName)).toBeTruthy(); }); @@ -332,7 +346,8 @@ test('can add a media start node to a user group', async ({umbracoApi, umbracoUi await umbracoUi.userGroup.clickSaveButton(); // Assert - await umbracoUi.userGroup.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.userGroup.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.userGroup.isErrorNotificationVisible(false); expect(await umbracoApi.userGroup.doesUserGroupContainMediaStartNodeId(userGroupName, mediaId)).toBeTruthy(); // Clean @@ -355,7 +370,8 @@ test('can remove a media start node from a user group ', async ({umbracoApi, umb await umbracoUi.userGroup.clickSaveButton(); // Assert - await umbracoUi.userGroup.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.userGroup.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.userGroup.isErrorNotificationVisible(false); expect(await umbracoApi.userGroup.doesUserGroupContainMediaStartNodeId(userGroupName, mediaId)).toBeFalsy(); // Clean @@ -373,7 +389,8 @@ test('can enable access to all media in a user group ', async ({umbracoApi, umbr await umbracoUi.userGroup.clickSaveButton(); // Assert - await umbracoUi.userGroup.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.userGroup.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.userGroup.isErrorNotificationVisible(false); expect(await umbracoApi.userGroup.doesUserGroupContainMediaRootAccess(userGroupName)).toBeTruthy(); }); @@ -388,7 +405,8 @@ test('can enable all permissions for a user group', async ({umbracoApi, umbracoU await umbracoUi.userGroup.clickSaveButton(); // Assert - await umbracoUi.userGroup.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.userGroup.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.userGroup.isErrorNotificationVisible(false); await umbracoUi.reloadPage(); await umbracoUi.userGroup.doesUserGroupHavePermissionEnabled(allPermissions.uiPermission); const userGroupData = await umbracoApi.userGroup.getByName(userGroupName); @@ -414,7 +432,8 @@ test('can add granular permission to a specific document for a user group', asyn await umbracoUi.userGroup.clickSaveButton(); // Assert - await umbracoUi.userGroup.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.userGroup.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.userGroup.isErrorNotificationVisible(false); expect(await umbracoApi.userGroup.doesUserGroupContainGranularPermissionsForDocument(userGroupName, documentId, [allPermissions.verbPermission[0]])).toBeTruthy(); // Clean @@ -440,7 +459,8 @@ test('can add all granular permissions to a specific document for a user group', await umbracoUi.userGroup.clickSaveButton(); // Assert - await umbracoUi.userGroup.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.userGroup.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.userGroup.isErrorNotificationVisible(false); await umbracoUi.reloadPage(); await umbracoUi.userGroup.clickGranularPermissionWithName(documentName); await umbracoUi.userGroup.doesUserGroupHavePermissionEnabled(allPermissions.uiPermission); @@ -467,7 +487,8 @@ test('can remove granular permission to a specific document for a user group', a await umbracoUi.userGroup.clickSaveButton(); // Assert - await umbracoUi.userGroup.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + //await umbracoUi.userGroup.doesSuccessNotificationHaveText(NotificationConstantHelper.success.saved); + await umbracoUi.userGroup.isErrorNotificationVisible(false); expect(await umbracoApi.userGroup.doesUserGroupContainGranularPermissionsForDocument(userGroupName, documentId, [allPermissions.verbPermission[0]])).toBeFalsy(); // Clean