perf: Remove foreach statement in SubscribeToPropertyChanged

jeromelaban · jeromelaban · commit 5f0aed5ba2a1 · 2021-04-09T09:13:52.000-04:00
diff --git a/src/Uno.UI/DataBinding/BindingPath.cs b/src/Uno.UI/DataBinding/BindingPath.cs
@@ -802,8 +802,10 @@ private void RaiseValueChanged(object newValue)
 			private IDisposable SubscribeToPropertyChanged(PropertyChangedHandler action)
 			{
 				var disposables = new CompositeDisposable((_propertyChangedHandlers.Count * 3));
-				foreach (var handler in _propertyChangedHandlers)
+
+				for (var i = 0; i < _propertyChangedHandlers.Count; i++)
 				{
+					var handler = _propertyChangedHandlers[i];
 					object previousValue = default;
 
 					Action updateProperty = () =>

Original file line number	Diff line number	Diff line change
`@@ -802,8 +802,10 @@ private void RaiseValueChanged(object newValue)`
`802`	`802`	`private IDisposable SubscribeToPropertyChanged(PropertyChangedHandler action)`
`803`	`803`	`{`
`804`	`804`	`var disposables = new CompositeDisposable((_propertyChangedHandlers.Count * 3));`
`805`		`- foreach (var handler in _propertyChangedHandlers)`
	`805`	`+`
	`806`	`+ for (var i = 0; i < _propertyChangedHandlers.Count; i++)`
`806`	`807`	`{`
	`808`	`+ var handler = _propertyChangedHandlers[i];`
`807`	`809`	`object previousValue = default;`
`808`	`810`
`809`	`811`	`Action updateProperty = () =>`