perf(DependencyObjectAvailabilityGenerator): Avoid calculating property names twice

Author: Youssef1313

src/SourceGenerators/Uno.UI.SourceGenerators/BindableTypeProviders/DependencyObjectAvailabilityGenerator.cs

@@ -50,8 +50,6 @@ internal void Generate(GeneratorExecutionContext context)
 				try
 				{
 					var validPlatform = PlatformHelper.IsValidPlatform(context);
-					var isDesignTime = DesignTimeHelper.IsDesignTime(context);
-					var isApplication = PlatformHelper.IsApplication(context);
 
 					if (!bool.TryParse(context.GetMSBuildPropertyValue("UnoXamlResourcesTrimming"), out _xamlResourcesTrimming))
 					{
@@ -90,17 +88,15 @@ from module in sym.Modules
 
 						modules = modules.Concat(context.Compilation.SourceModule);
 
-						var bindableTypes = from module in modules
-											from type in module.GlobalNamespace.GetNamespaceTypes()
-											where (
-												type.GetAllInterfaces().Any(i => SymbolEqualityComparer.Default.Equals(i, _dependencyObjectSymbol))
-												|| additionalLinkerHintSymbols.Contains(type)
-											)
-											select type;
+						var propertyNames = (from module in modules
+											 from type in module.GlobalNamespace.GetNamespaceTypes()
+											 where (
+												 type.GetAllInterfaces().Any(i => SymbolEqualityComparer.Default.Equals(i, _dependencyObjectSymbol))
+												 || additionalLinkerHintSymbols.Contains(type)
+											 )
+											 select LinkerHintsHelpers.GetPropertyAvailableName(type.GetFullMetadataName())).ToArray();
 
-						bindableTypes = bindableTypes.ToArray();
-
-						context.AddSource("DependencyObjectAvailability", GenerateTypeProviders(bindableTypes));
+						context.AddSource("DependencyObjectAvailability", GenerateTypeProviders(propertyNames));
 
 #if DEBUG
 						context.AddSource("DependencyObjectAvailability_Debug",
@@ -115,7 +111,7 @@ from type in module.GlobalNamespace.GetNamespaceTypes()
 							""");
 #endif
 
-						GenerateLinkerSubstitutionDefinition(bindableTypes, isApplication);
+						GenerateLinkerSubstitutionDefinition(propertyNames);
 					}
 				}
 				catch (OperationCanceledException)
@@ -189,7 +185,7 @@ private HashSet<INamedTypeSymbol> FindAdditionalLinkerHints(GeneratorExecutionCo
 				return types;
 			}
 
-			private void GenerateLinkerSubstitutionDefinition(IEnumerable<INamedTypeSymbol> bindableTypes, bool isApplication)
+			private void GenerateLinkerSubstitutionDefinition(string[] propertyNames)
 			{
 				// <linker>
 				//   <assembly fullname="Uno.UI">
@@ -221,10 +217,8 @@ private void GenerateLinkerSubstitutionDefinition(IEnumerable<INamedTypeSymbol>
 				typeNode.SetAttribute("fullname", LinkerHintsHelpers.GetLinkerHintsClassName(_defaultNamespace));
 				assemblyNode.AppendChild(typeNode);
 
-				foreach (var type in bindableTypes)
+				foreach (var propertyName in propertyNames)
 				{
-					var propertyName = LinkerHintsHelpers.GetPropertyAvailableName(type.GetFullMetadataName());
-
 					var methodNode = doc.CreateElement(string.Empty, "method", string.Empty);
 					methodNode.SetAttribute("signature", $"System.Boolean get_{propertyName}()");
 					methodNode.SetAttribute("body", "stub");
@@ -240,7 +234,7 @@ private void GenerateLinkerSubstitutionDefinition(IEnumerable<INamedTypeSymbol>
 				doc.Save(fileName);
 			}
 
-			private string GenerateTypeProviders(IEnumerable<INamedTypeSymbol> bindableTypes)
+			private string GenerateTypeProviders(string[] propertyNames)
 			{
 				var writer = new IndentedStringBuilder();
 
@@ -252,9 +246,6 @@ private string GenerateTypeProviders(IEnumerable<INamedTypeSymbol> bindableTypes
 				writer.AppendLine();
 				writer.AppendLineIndented("#pragma warning disable 618  // Ignore obsolete members warnings");
 				writer.AppendLineIndented("#pragma warning disable 1591 // Ignore missing XML comment warnings");
-				writer.AppendLineIndented("using System;");
-				writer.AppendLineIndented("using System.Linq;");
-				writer.AppendLineIndented("using System.Diagnostics;");
 
 				writer.AppendLineIndented($"// _intermediatePath: {_intermediatePath}");
 				writer.AppendLineIndented($"// _intermediateOutputPath: {_intermediateOutputPath}");
@@ -263,11 +254,9 @@ private string GenerateTypeProviders(IEnumerable<INamedTypeSymbol> bindableTypes
 				{
 					using (writer.BlockInvariant("internal class " + LinkerHintsHelpers.GetLinkerHintsClassName()))
 					{
-						foreach (var type in bindableTypes)
+						foreach (var propertyName in propertyNames)
 						{
-							var safeTypeName = LinkerHintsHelpers.GetPropertyAvailableName(type.GetFullMetadataName());
-
-							writer.AppendLineIndented($"internal static bool {safeTypeName} => true;");
+							writer.AppendLineIndented($"internal static bool {propertyName} => true;");
 						}
 					}
 				}