Merge pull request #19560 from unoplatform/mergify/bp/release/stable/5.6/pr-19528

fix(hr): Ignore bin and obj folders (backport #19528)

Author: jeromelaban

src/SourceGenerators/Uno.UI.SourceGenerators/RemoteControl/RemoteControlGenerator.cs

@@ -47,7 +47,8 @@ public class RemoteControlGenerator : ISourceGenerator
 			"MSBuildVersion",
 			"UnoHotReloadDiagnosticsLogPath",
 			"AppendRuntimeIdentifierToOutputPath",
-			"OutputPath"
+			"OutputPath",
+			"IntermediateOutputPath"
 		};
 
 		public void Initialize(GeneratorInitializationContext context)

src/Uno.UI.RemoteControl.Server.Processors/HotReload/ServerHotReloadProcessor.MetadataUpdate.cs

@@ -23,7 +23,8 @@ namespace Uno.UI.RemoteControl.Host.HotReload
 {
 	partial class ServerHotReloadProcessor : IServerProcessor, IDisposable
 	{
-		private static readonly StringComparer _pathsComparer = RuntimeInformation.IsOSPlatform(OSPlatform.Windows) ? StringComparer.OrdinalIgnoreCase : StringComparer.Ordinal;
+		private static readonly StringComparer _pathsComparer = OperatingSystem.IsWindows() ? StringComparer.OrdinalIgnoreCase : StringComparer.Ordinal;
+		private static readonly StringComparison _pathsComparison = OperatingSystem.IsWindows() ? StringComparison.OrdinalIgnoreCase : StringComparison.Ordinal;
 
 		private FileSystemWatcher[]? _solutionWatchers;
 		private IDisposable? _solutionWatcherEventsDisposable;
@@ -96,6 +97,7 @@ private void InitializeInner(ConfigureServer configureServer)
 						&& bool.TryParse(appendStr, out var append)
 						&& append;
 					var hasOutputPath = properties.Remove("OutputPath", out var outputPath);
+					properties.Remove("IntermediateOutputPath", out var intermediateOutputPath);
 
 					if (properties.Remove("RuntimeIdentifier", out var runtimeIdentifier))
 					{
@@ -116,7 +118,7 @@ private void InitializeInner(ConfigureServer configureServer)
 						properties,
 						CancellationToken.None);
 
-					ObserveSolutionPaths(result.Item1);
+					ObserveSolutionPaths(result.Item1, intermediateOutputPath, outputPath);
 
 					await _remoteControlServer.SendFrame(new HotReloadWorkspaceLoadResult { WorkspaceInitialized = true });
 					await Notify(HotReloadEvent.Ready);
@@ -136,16 +138,26 @@ private void InitializeInner(ConfigureServer configureServer)
 			CancellationToken.None);
 		}
 
-		private void ObserveSolutionPaths(Solution solution)
+		private void ObserveSolutionPaths(Solution solution, params string?[] excludedDir)
 		{
 			var observedPaths =
 				solution.Projects
-					.SelectMany(p => p
-						.Documents
-						.Select(d => d.FilePath)
-						.Concat(p.AdditionalDocuments
-							.Select(d => d.FilePath)))
-					.Select(Path.GetDirectoryName)
+					.SelectMany(project =>
+					{
+						var projectDir = Path.GetDirectoryName(project.FilePath);
+						ImmutableArray<string> excludedProjectDir = [.. from dir in excludedDir where dir is not null select Path.Combine(projectDir!, dir).TrimEnd(Path.DirectorySeparatorChar, Path.AltDirectorySeparatorChar)];
+
+						var paths = project
+							.Documents
+							.Select(d => d.FilePath)
+							.Concat(project.AdditionalDocuments.Select(d => d.FilePath))
+							.Select(Path.GetDirectoryName)
+							.Where(path => path is not null && !excludedProjectDir.Any(dir => path.StartsWith(dir, _pathsComparison)))
+							.Distinct()
+							.ToArray();
+
+						return paths;
+					})
 					.Distinct()
 					.ToArray();
 

src/Uno.UI.RemoteControl/HotReload/ClientHotReloadProcessor.Common.Status.cs

@@ -215,7 +215,7 @@ private string[] GetCuratedTypes()
 		{
 			return Types
 				.Select(GetFriendlyName)
-				.Where(name => name is { Length: > 0 })
+				.Where(name => name is { Length: > 0 } and not "HotReloadException")
 				.Distinct()
 				.ToArray()!;