Skip to content

Commit 194a493

Browse files
fix: incorrect checkbox state after removing checked items #4549 (#4552)
Co-authored-by: Anubhav Singh <[email protected]>
1 parent 44df17a commit 194a493

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

web/src/components/MemoContent/TaskListItem.tsx

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { Checkbox } from "@usememos/mui";
2-
import { useContext, useState } from "react";
2+
import { useContext } from "react";
33
import { markdownServiceClient } from "@/grpcweb";
44
import { useMemoStore } from "@/store/v1";
55
import { Node, TaskListItemNode } from "@/types/proto/api/v1/markdown_service";
@@ -19,7 +19,6 @@ interface Props {
1919
const TaskListItem: React.FC<Props> = ({ node, complete, children }: Props) => {
2020
const context = useContext(RendererContext);
2121
const memoStore = useMemoStore();
22-
const [checked, setChecked] = useState(complete);
2322

2423
const handleCheckboxChange = async (on: boolean) => {
2524
if (context.readonly || !context.memoName) {
@@ -35,13 +34,12 @@ const TaskListItem: React.FC<Props> = ({ node, complete, children }: Props) => {
3534
},
3635
["content"],
3736
);
38-
setChecked(on);
3937
};
4038

4139
return (
4240
<li className={cn("w-full grid grid-cols-[24px_1fr]")}>
4341
<span className="w-6 h-6 flex justify-start items-center">
44-
<Checkbox size="sm" checked={checked} disabled={context.readonly} onChange={(e) => handleCheckboxChange(e.target.checked)} />
42+
<Checkbox size="sm" checked={complete} disabled={context.readonly} onChange={(e) => handleCheckboxChange(e.target.checked)} />
4543
</span>
4644
<p className={cn(complete && "line-through opacity-80")}>
4745
{children.map((child, index) => (

0 commit comments

Comments
 (0)