Skip to content

Removing Memo Comment Logic From memo_service.go #4677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nathankrieger opened this issue May 7, 2025 · 0 comments
Closed

Removing Memo Comment Logic From memo_service.go #4677

nathankrieger opened this issue May 7, 2025 · 0 comments
Labels
enhancement New feature or request Stale

Comments

@nathankrieger
Copy link

Describe the solution you'd like

Describe the solution you'd like

The memo_service.go file is becoming increasingly long, pulling out comment logic and putting it in its own service will help. Handling memo and memo comment logic violates the single responsibility principle.
Type of feature

API
Additional context

See Discord conversation:
https://discord.com/channels/1017113925776588902/1099725880902815845/1345859707474284634

Type of feature

API

Additional context

No response
@nathankrieger nathankrieger added the enhancement New feature or request label May 7, 2025
@nathankrieger nathankrieger mentioned this issue May 7, 2025
Closed
@github-actions github-actions bot added the Stale label May 22, 2025
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removed comment logic from memo_service nathankrieger/memos
1 participant
@nathankrieger