Revise comment on getLiveVars().

vext01 · vext01 · commit 5613b2570650 · 2022-03-03T10:49:21.000Z
Add a link to an issue with this function.
diff --git a/llvm/lib/Transforms/Yk/ControlPoint.cpp b/llvm/lib/Transforms/Yk/ControlPoint.cpp
@@ -89,6 +89,9 @@ CallInst *findControlPointCall(Module &M) {
 }
 
 /// Extract all live variables that need to be passed into the control point.
+///
+/// YKFIXME: This currently computes an over-approximation of what's live.
+/// https://github.com/ykjit/yk/issues/515
 std::vector<Value *> getLiveVars(DominatorTree &DT, CallInst *OldCtrlPoint) {
   std::vector<Value *> Vec;
   Function *Func = OldCtrlPoint->getFunction();

Original file line number	Diff line number	Diff line change
`@@ -89,6 +89,9 @@ CallInst *findControlPointCall(Module &M) {`
`89`	`89`	`}`
`90`	`90`
`91`	`91`	`/// Extract all live variables that need to be passed into the control point.`
	`92`	`+///`
	`93`	`+/// YKFIXME: This currently computes an over-approximation of what's live.`
	`94`	`+/// https://github.com/ykjit/yk/issues/515`
`92`	`95`	`std::vector<Value > getLiveVars(DominatorTree &DT, CallInst OldCtrlPoint) {`
`93`	`96`	`std::vector<Value *> Vec;`
`94`	`97`	`Function *Func = OldCtrlPoint->getFunction();`