You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@magne4000 I wonder if we could systematically allow the user to add options to internal universal middlewares. Maybe this could be a new Vike setting 🤔. Thinking out loud: maybe we can have a vike-sirv with +sirv, or we keep sirv built-in and let vike-node define the +sirv setting. Not sure which approach is better, I guess there are trade-offs.
The text was updated successfully, but these errors were encountered:
It would be great indeed to give users a quick access to any middleware configurations.
If middlewares are named, retrieving them would not be an issue.
I'll see what kind of implementation makes sense when I'll dive back into vike-node.
👍 No need to think of "where is this setting again" (I often have that with Vite's nested settings)
👎 Maybe users will first look for "server settings" while thinking "where are the server settings related to static files"
I usually prefer flat settings (maybe it's subjective?), but maybe for this one going nested would make more sense.
🤔 Both points are fair. I would say that not everyone knows sirv, so having it inside server helps discovering it. So I think I'll tend a bit more for the non-flat version right now.
Related: #58
@magne4000 I wonder if we could systematically allow the user to add options to internal universal middlewares. Maybe this could be a new Vike setting 🤔. Thinking out loud: maybe we can have a
vike-sirv
with+sirv
, or we keepsirv
built-in and letvike-node
define the+sirv
setting. Not sure which approach is better, I guess there are trade-offs.The text was updated successfully, but these errors were encountered: