Skip to content

Show Vite's --host message when dev server is ready #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
brillout opened this issue Mar 20, 2025 · 3 comments
Open

Show Vite's --host message when dev server is ready #78

brillout opened this issue Mar 20, 2025 · 3 comments
Labels
polish ✨

Comments

@brillout
Copy link
Member

Like when using SSG without vike-server.
@magne4000
Copy link
Member

I'm not sure if we can do that without duplicating some Vite's code 🤔

@brillout
Copy link
Member Author

It should already do it since Vike calls printUrls(): https://github.com/vikejs/vike/blob/78ec4be45272dab3c2fda892ea9cd0f43d373659/vike/node/cli/entry.ts#L38-L39. So I guess removing the following does the trick?

https://github.com/vikejs/vike-node/blob/27a023539bf2889d0ab3b2785f4a24293dfcfde5/packages/vike-server/src/plugin/plugins/devServerPlugin.ts#L187

I guess Dani wrote that because back then we intended to have zero CLI options.

@magne4000
Copy link
Member

Sadly, printUrls throws an Error in middleware mode (and resolvedUrls is not populated either).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
polish ✨
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brillout @magne4000