Fix cache to respect end_date in get_financial_metrics (#254) #271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(My first contribution)
What's new?
This PR corrects a bug in the get_financial_metrics function where cached financial metrics were being returned irrespective of whether they spanned the requested end_date. The cache is now only returned if the recently cached data spans the end_date. Otherwise, new data are retrieved from the API and cache is updated.
Why does this matter?
Earlier, users would receive old financial information when using the cache, resulting in incomplete or inaccurate sets of metrics. This patch guarantees the data returned is always as required by the query's date, enhancing accuracy and dependability.
How was it tested?
Verified cached data is skipped if end_date is more recent than the most recent cached report.
Confirmed new data is retrieved and cached appropriately.
Manual testing against multiple tickers with different end_date values.
Related issue
Fixes #254