Skip to content

Commit d140a50

Browse files
committed
v1: MPClient.proc-handle can be None
Fixes: vllm/v1/engine/core_client.py:196: error: Incompatible types in assignment (expression has type "None", variable has type "EngineCoreProcHandle") [assignment] Signed-off-by: Mark McLoughlin <[email protected]>
1 parent e953f47 commit d140a50

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

vllm/v1/engine/core_client.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import atexit
22
import os
3-
from typing import List
3+
from typing import List, Optional
44

55
import msgspec
66
import zmq
@@ -11,7 +11,8 @@
1111
from vllm.v1.engine import (EngineCoreOutput, EngineCoreOutputs,
1212
EngineCoreProfile, EngineCoreRequest,
1313
EngineCoreRequestType, EngineCoreRequestUnion)
14-
from vllm.v1.engine.core import EngineCore, EngineCoreProc
14+
from vllm.v1.engine.core import (EngineCore, EngineCoreProc,
15+
EngineCoreProcHandle)
1516
from vllm.v1.serial_utils import PickleEncoder
1617

1718
logger = init_logger(__name__)
@@ -155,6 +156,7 @@ def __init__(
155156
self.input_socket.bind(input_path)
156157

157158
# Start EngineCore in background process.
159+
self.proc_handle: Optional[EngineCoreProcHandle]
158160
self.proc_handle = EngineCoreProc.make_engine_core_process(
159161
*args,
160162
input_path=

0 commit comments

Comments
 (0)