Use best practice for array emptiness check

GrahamCampbell · GrahamCampbell · commit 0b32505d67c1 · 2020-05-23T10:43:32.000+01:00
diff --git a/src/Store/FileStore.php b/src/Store/FileStore.php
@@ -50,7 +50,7 @@ public function read()
 
         $contents = Reader::read($this->filePaths, $this->shortCircuit);
 
-        if ($contents) {
+        if (count($contents) > 0) {
             return implode("\n", $contents);
         }
 

Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,7 @@ public function read()`
`50`	`50`
`51`	`51`	`$contents = Reader::read($this->filePaths, $this->shortCircuit);`
`52`	`52`
`53`		`- if ($contents) {`
	`53`	`+ if (count($contents) > 0) {`
`54`	`54`	`return implode("\n", $contents);`
`55`	`55`	`}`
`56`	`56`