govc: fix integer type conversion for guest.chown

tenthirtyam · tenthirtyam · commit b40a2aceb8cd · 2025-03-17T20:01:59.000-04:00
Correct the integer type conversion for the `guest.chown`.

Signed-off-by: Ryan Johnson &lt;ryan.johnson@broadcom.com&gt;
diff --git a/cli/vm/guest/chown.go b/cli/vm/guest/chown.go
@@ -74,22 +74,24 @@ func (cmd *chown) Run(ctx context.Context, f *flag.FlagSet) error {
 		return flag.ErrHelp
 	}
 
-	id, err := strconv.Atoi(ids[0])
+	ownerIDStr := ids[0]
+	ownerID, err := strconv.Atoi(ownerIDStr)
 	if err != nil {
 		return err
 	}
 
 	attr.OwnerId = new(int32)
-	*attr.OwnerId = int32(id)
+	*attr.OwnerId = int32(ownerID)
 
 	if len(ids) == 2 {
-		id, err = strconv.Atoi(ids[1])
+		groupIDStr := ids[1]
+		groupID, err := strconv.Atoi(groupIDStr)
 		if err != nil {
 			return err
 		}
 
 		attr.GroupId = new(int32)
-		*attr.GroupId = int32(id)
+		*attr.GroupId = int32(groupID)
 	}
 
 	return m.ChangeFileAttributes(ctx, cmd.Auth(), f.Arg(1), &attr)

Original file line number	Diff line number	Diff line change
`@@ -74,22 +74,24 @@ func (cmd chown) Run(ctx context.Context, f flag.FlagSet) error {`
`74`	`74`	`return flag.ErrHelp`
`75`	`75`	`}`
`76`	`76`
`77`		`- id, err := strconv.Atoi(ids[0])`
	`77`	`+ ownerIDStr := ids[0]`
	`78`	`+ ownerID, err := strconv.Atoi(ownerIDStr)`
`78`	`79`	`if err != nil {`
`79`	`80`	`return err`
`80`	`81`	`}`
`81`	`82`
`82`	`83`	`attr.OwnerId = new(int32)`
`83`		`- *attr.OwnerId = int32(id)`
	`84`	`+ *attr.OwnerId = int32(ownerID)`
`84`	`85`
`85`	`86`	`if len(ids) == 2 {`
`86`		`- id, err = strconv.Atoi(ids[1])`
	`87`	`+ groupIDStr := ids[1]`
	`88`	`+ groupID, err := strconv.Atoi(groupIDStr)`
`87`	`89`	`if err != nil {`
`88`	`90`	`return err`
`89`	`91`	`}`
`90`	`92`
`91`	`93`	`attr.GroupId = new(int32)`
`92`		`- *attr.GroupId = int32(id)`
	`94`	`+ *attr.GroupId = int32(groupID)`
`93`	`95`	`}`
`94`	`96`
`95`	`97`	`return m.ChangeFileAttributes(ctx, cmd.Auth(), f.Arg(1), &attr)`