Skip to content

Commit f292230

Browse files
mjguziksnajpa
authored andcommitted
Bring per_txg_dirty_frees_percent back to 30
The current value causes significant artificial slowdown during mass parallel file removal, which can be observed both on FreeBSD and Linux when running real workloads. Sample results from Linux doing make -j 96 clean after an allyesconfig modules build: before: 4.14s user 6.79s system 48% cpu 22.631 total after: 4.17s user 6.44s system 153% cpu 6.927 total FreeBSD results in the ticket. Reviewed-by: Alexander Motin <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: Richard Yao <[email protected]> Reviewed-by: George Melikov <[email protected]> Signed-off-by: Mateusz Guzik <[email protected]> Closes openzfs#13932 Closes openzfs#13938
1 parent a817285 commit f292230

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

man/man4/zfs.4

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1626,7 +1626,7 @@ prefetched during a pool traversal, like
16261626
.Nm zfs Cm send
16271627
or other data crawling operations.
16281628
.
1629-
.It Sy zfs_per_txg_dirty_frees_percent Ns = Ns Sy 5 Ns % Pq ulong
1629+
.It Sy zfs_per_txg_dirty_frees_percent Ns = Ns Sy 30 Ns % Pq ulong
16301630
Control percentage of dirtied indirect blocks from frees allowed into one TXG.
16311631
After this threshold is crossed, additional frees will wait until the next TXG.
16321632
.Sy 0 No disables this throttle.

module/zfs/dmu.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ int zfs_nopwrite_enabled = 1;
7070
* will wait until the next TXG.
7171
* A value of zero will disable this throttle.
7272
*/
73-
unsigned long zfs_per_txg_dirty_frees_percent = 5;
73+
static unsigned long zfs_per_txg_dirty_frees_percent = 30;
7474

7575
/*
7676
* Enable/disable forcing txg sync when dirty in dmu_offset_next.

0 commit comments

Comments
 (0)