Skip to content

Commit 98b1926

Browse files
author
Israel Fruchter (ifruchte)
committed
Fixes for the test to run on windows
1 parent f09b206 commit 98b1926

File tree

2 files changed

+20
-4
lines changed

2 files changed

+20
-4
lines changed

client/client_test.go

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -210,7 +210,11 @@ func TestUpdateFeatures(t *testing.T) {
210210
}`)
211211

212212
cfg := config.DefaultConfig()
213-
cfg.Git.RepoPath = "/tmp"
213+
dir, err := ioutil.TempDir("", "example")
214+
if err != nil {
215+
log.Fatal(err)
216+
}
217+
cfg.Git.RepoPath = dir
214218
c, _ := New(cfg)
215219
c.UpdateFeatures(raw)
216220

@@ -235,14 +239,19 @@ func TestClient_UpdateFeatures_Failure(t *testing.T) {
235239
},`)
236240

237241
cfg := config.DefaultConfig()
238-
cfg.Git.RepoPath = "/tmp"
242+
dir, err := ioutil.TempDir("", "example")
243+
if err != nil {
244+
log.Fatal(err)
245+
}
246+
cfg.Git.RepoPath = dir
239247
c, _ := New(cfg)
240248
c.UpdateFeatures(badUpdate)
241249
assert.EqualValues(t, models.EmptyFeatureMap(), c.FeatureMap(), "Assert bad payload returns empty feature map")
242250
}
243251

244252
func TestWatch(t *testing.T) {
245-
p := "/tmp/decider.json"
253+
tmpfile, err := ioutil.TempFile("", "example")
254+
p := tmpfile.Name()
246255
fm, err := models.NewFeatureMap(JSONBytes)
247256
assert.NoError(t, err)
248257
err = ioutil.WriteFile(p, JSONBytes, 0644)

config/config_test.go

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@ import (
44
"os/user"
55
"testing"
66

7+
"io/ioutil"
8+
79
"os"
810

911
"fmt"
@@ -41,7 +43,12 @@ func TestDefaultConfig(t *testing.T) {
4143
}
4244

4345
func TestEnvOverride(t *testing.T) {
44-
os.Setenv(envConfigDirOverride, "/tmp/dcdr")
46+
dir, err := ioutil.TempDir("", "example")
47+
assert.NoError(t, err)
48+
49+
defer os.RemoveAll(dir)
50+
51+
os.Setenv(envConfigDirOverride, dir)
4552
cfg := LoadConfig()
4653

4754
assert.Equal(t, Path(), fmt.Sprintf("%s/%s", os.Getenv(envConfigDirOverride), configFileName))

0 commit comments

Comments
 (0)