Skip to content

Commit 000ffe4

Browse files
wavesheepwavesheep
and
wavesheep
authored
refactor: obj[key] have already triggered the getter (#914)
Co-authored-by: wavesheep <[email protected]>
1 parent b3296db commit 000ffe4

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

src/reactivity/reactive.ts

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -208,14 +208,13 @@ export function shallowReactive(obj: any) {
208208

209209
proxy(observed, key, {
210210
get: function getterHandler() {
211-
const value = getter ? getter.call(obj) : val
212211
ob.dep?.depend()
213-
return value
212+
return val
214213
},
215214
set: function setterHandler(newVal: any) {
216215
if (getter && !setter) return
217-
const value = getter ? getter.call(obj) : val
218-
if (!isForceTrigger() && value === newVal) return
216+
217+
if (!isForceTrigger() && val === newVal) return
219218
if (setter) {
220219
setter.call(obj, newVal)
221220
} else {

0 commit comments

Comments
 (0)