Skip to content

Suggestion: Maybe we can replace the editor change event with Ctrl + s #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
btea opened this issue Jan 24, 2022 · 2 comments · Fixed by #247
Closed

Suggestion: Maybe we can replace the editor change event with Ctrl + s #21

btea opened this issue Jan 24, 2022 · 2 comments · Fixed by #247
Labels
enhancement New feature or request

Comments

@btea
Copy link
Contributor

btea commented Jan 24, 2022

At present, when we edit the file content, the change event of the editor will be triggered, and then the input content will be parsed.

But most of the time, we only wrote a part, so the analysis will report an error. I don't think it's very friendly.

Therefore, I want to confirm the completion of your code by Ctrl + s, and then parse and update it.

I can create an PR if you think this suggestion works. @yyx990803
@sxzz
Copy link
Member

sxzz commented May 23, 2024

I think we can add this option for props. If you submit a PR, I'd be happy to merge it!

@sxzz sxzz added the enhancement New feature or request label May 23, 2024
@btea btea mentioned this issue May 24, 2024
Merged
@btea
Copy link
Contributor Author

btea commented May 24, 2024

Okay, I've created a PR. #247

@sxzz sxzz closed this as completed in #247 May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add autoSave option btea/repl
2 participants
@sxzz @btea