Skip to content

NotFound (404) leaves last pages $page data #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
RegisFrey opened this issue Oct 18, 2020 · 0 comments · Fixed by #497
Closed

NotFound (404) leaves last pages $page data #100

RegisFrey opened this issue Oct 18, 2020 · 0 comments · Fixed by #497

Comments

@RegisFrey
Copy link

RegisFrey commented Oct 18, 2020 •
edited
Loading

Describe the bug
When navigating from an existing page to a NotFound (404). $page retains data from the previous page.

To Reproduce
Navigating to a non-existing page via an <a href> in the page leaves the last $page value in place.

Expected behavior
On navigating to a 404 URL, $page should be empty even if it was set by a previous page.

Navigating to a non-existing page via the URL, or refreshing the current URL, already works correctly ($page is undefined).

System Info

  • vitepress version: v0.6.0
  • vite version: v1.0.0-rc.4
  • Node version: v12.16.2
  • OS version: Mac OS 10.14.6
@RegisFrey RegisFrey added the bug: pending triage Maybe a bug, waiting for confirmation label Oct 18, 2020
@kiaking kiaking added bug and removed bug: pending triage Maybe a bug, waiting for confirmation labels Oct 19, 2020
@brc-dd brc-dd mentioned this issue Jan 14, 2022
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: reset page data on 404
2 participants
@RegisFrey @kiaking