Skip to content

Commit 6cf2906

Browse files
committed
feat: use ESLint v5 by default everywhere (#3775)
BREAKING CHANGE: may cause old projects' linting fail (those scaffolded with Vue CLI 3.0.x).
1 parent 7a15655 commit 6cf2906

File tree

3 files changed

+6
-16
lines changed

3 files changed

+6
-16
lines changed

packages/@vue/cli-plugin-eslint/generator/index.js

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -13,15 +13,7 @@ module.exports = (api, { config, lintOn = [] }, _, invoking) => {
1313
lint: 'vue-cli-service lint'
1414
},
1515
eslintConfig,
16-
// TODO:
17-
// Move these dependencies to package.json in v4.
18-
// Now in v3 we have to add redundant eslint related dependencies
19-
// in order to keep compatibility with v3.0.x users who defaults to ESlint v4.
20-
devDependencies: {
21-
'babel-eslint': '^10.0.1',
22-
'eslint': '^5.16.0',
23-
'eslint-plugin-vue': '^5.0.0'
24-
}
16+
devDependencies: {}
2517
}
2618

2719
const injectEditorConfig = (config) => {

packages/@vue/cli-plugin-eslint/package.json

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -25,12 +25,10 @@
2525
"dependencies": {
2626
"@vue/cli-shared-utils": "^3.7.0",
2727
"babel-eslint": "^10.0.1",
28+
"eslint": "^5.8.0",
2829
"eslint-loader": "^2.1.2",
29-
"globby": "^9.2.0",
30+
"eslint-plugin-vue": "^5.0.0",
31+
"globby": "^9.0.0",
3032
"webpack": ">=4 < 4.29"
31-
},
32-
"optionalDependencies": {
33-
"eslint": "^4.19.1",
34-
"eslint-plugin-vue": "^4.7.1"
3533
}
3634
}

packages/@vue/cli-service-global/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,8 @@
2828
"@vue/cli-service": "^3.7.0",
2929
"babel-eslint": "^10.0.1",
3030
"chalk": "^2.4.2",
31-
"eslint": "^4.19.1",
32-
"eslint-plugin-vue": "^4.7.1",
31+
"eslint": "^5.8.0",
32+
"eslint-plugin-vue": "^5.0.0",
3333
"resolve": "^1.10.0",
3434
"vue": "^2.6.10",
3535
"vue-template-compiler": "^2.6.10"

0 commit comments

Comments
 (0)