Skip to content

Commit 7a1526d

Browse files
committed
#576 warn errors in watcher getters
1 parent ef53a32 commit 7a1526d

File tree

2 files changed

+8
-1
lines changed

2 files changed

+8
-1
lines changed

src/watcher.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,9 @@ p.get = function () {
7272
var value
7373
try {
7474
value = this.getter.call(vm, vm)
75-
} catch (e) {}
75+
} catch (e) {
76+
_.warn(e)
77+
}
7678
// use JSON.stringify to "touch" every property
7779
// so they are all tracked as dependencies for
7880
// deep watching

test/unit/specs/watcher_spec.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -374,4 +374,9 @@ describe('Watcher', function () {
374374
expect(watcher.cbs.length).toBe(2)
375375
})
376376

377+
it('warn getter errors', function () {
378+
var watcher = new Watcher(vm, 'd.e + c', spy)
379+
expect(_.warn).toHaveBeenCalled()
380+
})
381+
377382
})

0 commit comments

Comments
 (0)